Fix performance bug with large number of unnamed parameters

On some occasions where col in (:args) contain a really lot args, 10k+ for instance, this commit fixes a performance (high CPU) bug by NOT traversing the whole map in basically O(n^2) manner

Signed-off-by: Mikhail Fedorov <[email protected]>

Author: Fedorov, Mikhail

spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/QueryMapper.java

@@ -625,16 +625,19 @@ private Expression bind(@Nullable Object mappedValue, SQLType sqlType, MapSqlPar
 	}
 
 	private static String getUniqueName(MapSqlParameterSource parameterSource, String name) {
-		Map<String, Object> parameters = parameterSource.getValues();
-		Object existingName = parameters.get(name);
-		if (existingName == null) {
+
+		Map<String, Object> values = parameterSource.getValues();
+
+		if (!values.containsKey(name)) {
 			return name;
 		}
-		int counter = parameters.size();
+
+		int counter = values.size();
 		String uniqueName;
+
 		do {
 			uniqueName = name + (counter++);
-		} while (parameters.containsKey(uniqueName));
+		} while (values.containsKey(uniqueName));
 		return uniqueName;
 	}