Fix JavaDoc.

Self closing <p/> tags cause build failures now.

See #1059

Author: schauder

spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/AssignValue.java

@@ -19,9 +19,9 @@
 
 /**
  * Assign a {@link Expression} to a {@link Column}.
- * <p/>
+ * <p>
  * Results in a rendered assignment: {@code <column> = <value>} (e.g. {@code col = 'foo'}.
- *
+ * </p>
  * @author Mark Paluch
  * @since 1.1
  */

spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/AsteriskFromTable.java

@@ -17,15 +17,16 @@
 
 /**
  * {@link Segment} to select all columns from a {@link Table}.
- * <p/>
- * * Renders to: {@code
+ * <p>
+ * Renders to: {@code
  *
 <table>
  * .*} as in {@code SELECT
  *
 <table>
  * .* FROM …}.
- *
+ * </p>
+ * 
  * @author Mark Paluch
  * @since 1.1
  * @see Table#asterisk()

spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/Between.java

@@ -19,9 +19,10 @@
 
 /**
  * BETWEEN {@link Condition} comparing between {@link Expression}s.
- * <p/>
+ * <p>
  * Results in a rendered condition: {@code <left> BETWEEN <begin> AND <end>}.
- *
+ * </p>
+ * 
  * @author Mark Paluch
  * @since 2.2
  */

spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/Column.java

@@ -20,9 +20,10 @@
 
 /**
  * Column name within a {@code SELECT … FROM} clause.
- * <p/>
+ * <p>
  * Renders to: {@code <name>} or {@code <table(alias)>.<name>}.
- *
+ * <p>
+ * 
  * @author Mark Paluch
  * @author Jens Schauder
  * @since 1.1

spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/Comparison.java

@@ -19,9 +19,10 @@
 
 /**
  * Comparing {@link Condition} comparing two {@link Expression}s.
- * <p/>
+ * <p>
  * Results in a rendered condition: {@code <left> <comparator> <right>} (e.g. {@code col = 'predicate'}.
- *
+ * </p>
+ * 
  * @author Mark Paluch
  * @author Jens Schauder
  * @since 1.1
@@ -61,11 +62,13 @@ public static Comparison create(Expression leftColumnOrExpression, String compar
 
 	/**
 	 * Creates a new {@link Comparison} from simple {@literal StringP} arguments
-	 * @param unqualifiedColumnName gets turned in a {@link Expressions#just(String)} and is expected to be an unqualified unique column name but also could be an verbatim expression. Must not be {@literal null}.
+	 * 
+	 * @param unqualifiedColumnName gets turned in a {@link Expressions#just(String)} and is expected to be an unqualified
+	 *          unique column name but also could be an verbatim expression. Must not be {@literal null}.
 	 * @param comparator must not be {@literal null}.
 	 * @param rightValue is considered a {@link Literal}. Must not be {@literal null}.
-	 * @return a new {@literal Comparison} of the first with the third argument using the second argument as comparison operator. Guaranteed to be not {@literal null}.
-	 *
+	 * @return a new {@literal Comparison} of the first with the third argument using the second argument as comparison
+	 *         operator. Guaranteed to be not {@literal null}.
 	 * @since 2.3
 	 */
 	public static Comparison create(String unqualifiedColumnName, String comparator, Object rightValue) {

spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/DeleteValidator.java

@@ -17,9 +17,10 @@
 
 /**
  * Validator for {@link Delete} statements.
- * <p/>
+ * <p>
  * Validates that all {@link Column}s using a table qualifier have a table import from the {@code FROM} clause.
- *
+ * </p>
+ * 
  * @author Mark Paluch
  * @since 1.1
  */

spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/Join.java

@@ -17,12 +17,13 @@
 
 /**
  * {@link Segment} for a {@code JOIN} declaration.
- * <p/>
+ * <p>
  * Renders to: {@code JOIN
  *
 <table>
  *  ON <condition>}.
- *
+ * </p>
+ * 
  * @author Mark Paluch
  * @since 1.1
  */

spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/Like.java

@@ -19,9 +19,9 @@
 
 /**
  * LIKE {@link Condition} comparing two {@link Expression}s.
- * <p/>
+ * <p>
  * Results in a rendered condition: {@code <left> LIKE <right>}.
- *
+ * </p>
  * @author Mark Paluch
  * @since 1.1
  */

spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/SQL.java

@@ -22,9 +22,10 @@
 /**
  * Utility to create SQL {@link Segment}s. Typically used as entry point to the Statement Builder. Objects and dependent
  * objects created by the Query AST are immutable except for builders.
- * <p/>
+ * <p>
  * The Statement Builder API is intended for framework usage to produce SQL required for framework operations.
- *
+ * </p>
+ * 
  * @author Mark Paluch
  * @author Jens Schauder
  * @since 1.1

spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/Segment.java

@@ -26,9 +26,10 @@ public interface Segment extends Visitable {
 
 	/**
 	 * Check whether this {@link Segment} is equal to another {@link Segment}.
-	 * <p/>
+	 * <p>
 	 * Equality is typically given if the {@link #toString()} representation matches.
-	 *
+	 * </p>
+	 * 
 	 * @param other the reference object with which to compare.
 	 * @return {@literal true} if this object is the same as the {@code other} argument; {@literal false} otherwise.
 	 */
@@ -37,22 +38,24 @@ public interface Segment extends Visitable {
 
 	/**
 	 * Generate a hash code from this{@link Segment}.
-	 * <p/>
+	 * <p>
 	 * Hashcode typically derives from the {@link #toString()} representation so two {@link Segment}s yield the same
 	 * {@link #hashCode()} if their {@link #toString()} representation matches.
-	 *
+	 * </p>
+	 * 
 	 * @return a hash code value for this object.
 	 */
 	@Override
 	int hashCode();
 
 	/**
 	 * Return a SQL string representation of this {@link Segment}.
-	 * <p/>
+	 * <p>
 	 * The representation is intended for debugging purposes and an approximation to the generated SQL. While it might
 	 * work in the context of a specific dialect, you should not that the {@link #toString()} representation works across
 	 * multiple databases.
-	 *
+	 * </p>
+	 * 
 	 * @return a SQL string representation of this {@link Segment}.
 	 */
 	@Override

spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/SelectValidator.java

@@ -21,10 +21,10 @@
 
 /**
  * Validator for {@link Select} statements.
- * <p/>
+ * <p>
  * Validates that all {@link Column}s using a table qualifier have a table import from either the {@code FROM} or
  * {@code JOIN} clause.
- *
+ * </p>
  * @author Mark Paluch
  * @author Jens Schauder
  * @since 1.1

spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/Table.java

@@ -25,9 +25,10 @@
 /**
  * Represents a table reference within an SQL statement. Typically used to denote {@code FROM} or {@code JOIN} or to
  * prefix a {@link Column}.
- * <p/>
+ * <p>
  * Renders to: {@code <name>} or {@code <name> AS <name>}.
- *
+ * </p>
+ * 
  * @author Mark Paluch
  * @since 1.1
  */
@@ -114,10 +115,10 @@ public Table as(SqlIdentifier alias) {
 
 	/**
 	 * Creates a new {@link Column} associated with this {@link Table}.
-	 * <p/>
+	 * <p>
 	 * Note: This {@link Table} does not track column creation and there is no possibility to enumerate all
 	 * {@link Column}s that were created for this table.
-	 *
+	 *</p>
 	 * @param name column name, must not be {@literal null} or empty.
 	 * @return a new {@link Column} associated with this {@link Table}.
 	 */
@@ -130,10 +131,10 @@ public Column column(String name) {
 
 	/**
 	 * Creates a new {@link Column} associated with this {@link Table}.
-	 * <p/>
+	 * <p>
 	 * Note: This {@link Table} does not track column creation and there is no possibility to enumerate all
 	 * {@link Column}s that were created for this table.
-	 *
+	 *</p>
 	 * @param name column name, must not be {@literal null} or empty.
 	 * @return a new {@link Column} associated with this {@link Table}.
 	 * @since 2.0
@@ -147,10 +148,10 @@ public Column column(SqlIdentifier name) {
 
 	/**
 	 * Creates a {@link List} of {@link Column}s associated with this {@link Table}.
-	 * <p/>
+	 * <p>
 	 * Note: This {@link Table} does not track column creation and there is no possibility to enumerate all
 	 * {@link Column}s that were created for this table.
-	 *
+	 *</p>
 	 * @param names column names, must not be {@literal null} or empty.
 	 * @return a new {@link List} of {@link Column}s associated with this {@link Table}.
 	 */
@@ -163,10 +164,10 @@ public List<Column> columns(String... names) {
 
 	/**
 	 * Creates a {@link List} of {@link Column}s associated with this {@link Table}.
-	 * <p/>
+	 * <p>
 	 * Note: This {@link Table} does not track column creation and there is no possibility to enumerate all
 	 * {@link Column}s that were created for this table.
-	 *
+	 *</p>
 	 * @param names column names, must not be {@literal null} or empty.
 	 * @return a new {@link List} of {@link Column}s associated with this {@link Table}.
 	 * @since 2.0
@@ -185,10 +186,10 @@ public List<Column> columns(SqlIdentifier... names) {
 
 	/**
 	 * Creates a {@link List} of {@link Column}s associated with this {@link Table}.
-	 * <p/>
+	 * <p>
 	 * Note: This {@link Table} does not track column creation and there is no possibility to enumerate all
 	 * {@link Column}s that were created for this table.
-	 *
+	 *</p>
 	 * @param names column names, must not be {@literal null} or empty.
 	 * @return a new {@link List} of {@link Column}s associated with this {@link Table}.
 	 */

spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/package-info.java

@@ -3,9 +3,10 @@
  * Statement Builder implementation. Use {@link org.springframework.data.relational.core.sql.StatementBuilder} to create
  * statements and {@link org.springframework.data.relational.core.sql.SQL} to create SQL objects. Objects and dependent
  * objects created by the Statement Builder are immutable except for builders.
- * <p/>
+ * <p>
  * The Statement Builder API is intended for framework usage to produce SQL required for framework operations.
- *
+ * </p>
+ * 
  * @since 1.1
  */
 @NonNullApi

spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/render/DelegatingVisitor.java

@@ -26,18 +26,21 @@
  * Abstract base class for delegating {@link Visitor} implementations. This class implements a delegation pattern using
  * visitors. A delegating {@link Visitor} can implement {@link #doEnter(Visitable)} and {@link #doLeave(Visitable)}
  * methods to provide its functionality.
- * <p/>
+ * <p>
  * <h3>Delegation</h3> Typically, a {@link Visitor} is scoped to a single responsibility. If a {@link Visitor segment}
  * requires {@link #doEnter(Visitable) processing} that is not directly implemented by the visitor itself, the current
  * {@link Visitor} can delegate processing to a {@link DelegatingVisitor delegate}. Once a delegation is installed, the
  * {@link DelegatingVisitor delegate} is used as {@link Visitor} for the current and all subsequent items until it
  * {@link #doLeave(Visitable) signals} that it is no longer responsible.
- * <p/>
+ * </p>
+ * <p>
  * Nested visitors are required to properly signal once they are no longer responsible for a {@link Visitor segment} to
  * step back from the delegation. Otherwise, parents are no longer involved in the visitation.
- * <p/>
+ * </p>
+ * <p>
  * Delegation is recursive and limited by the stack size.
- *
+ * </p>
+ * 
  * @author Mark Paluch
  * @since 1.1
  * @see FilteredSubtreeVisitor
@@ -49,11 +52,12 @@ abstract class DelegatingVisitor implements Visitor {
 
 	/**
 	 * Invoked for a {@link Visitable segment} when entering the segment.
-	 * <p/>
+	 * <p>
 	 * This method can signal whether it is responsible for handling the {@link Visitor segment} or whether the segment
 	 * requires delegation to a sub-{@link Visitor}. When delegating to a sub-{@link Visitor}, {@link #doEnter(Visitable)}
 	 * is called on the {@link DelegatingVisitor delegate}.
-	 *
+	 * </p>
+	 * 
 	 * @param segment must not be {@literal null}.
 	 * @return
 	 */
@@ -86,11 +90,12 @@ public final void enter(Visitable segment) {
 
 	/**
 	 * Invoked for a {@link Visitable segment} when leaving the segment.
-	 * <p/>
+	 * <p>
 	 * This method can signal whether this {@link Visitor} should remain responsible for handling subsequent
 	 * {@link Visitor segments} or whether it should step back from delegation. When stepping back from delegation,
 	 * {@link #doLeave(Visitable)} is called on the {@link DelegatingVisitor parent delegate}.
-	 *
+	 * </p>
+	 * 
 	 * @param segment must not be {@literal null}.
 	 * @return
 	 */

spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/render/FilteredSubtreeVisitor.java

@@ -25,7 +25,7 @@
  * Filtering {@link DelegatingVisitor visitor} applying a {@link Predicate filter}. Typically used as base class for
  * {@link Visitor visitors} that wish to apply hierarchical processing based on a well-defined entry {@link Visitor
  * segment}.
- * <p/>
+ * <p>
  * Filtering is a three-way process:
  * <ol>
  * <li>Ignores elements that do not match the filter {@link Predicate}.</li>
@@ -35,7 +35,8 @@
  * children of the matched {@link Visitable} until {@link #leaveMatched(Visitable) leaving the matched}
  * {@link Visitable}.</li>
  * </ol>
- *
+ * </p>
+ * 
  * @author Mark Paluch
  * @see TypedSubtreeVisitor
  * @since 1.1

spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/render/TypedSubtreeVisitor.java

@@ -26,7 +26,7 @@
  * Type-filtering {@link DelegatingVisitor visitor} applying a {@link Class type filter} derived from the generic type
  * parameter. Typically used as base class for {@link Visitor visitors} that wish to apply hierarchical processing based
  * on a well-defined entry {@link Visitor segment}.
- * <p/>
+ * <p>
  * Filtering is a three-way process:
  * <ol>
  * <li>Ignores elements that do not match the filter {@link Predicate}.</li>
@@ -36,7 +36,8 @@
  * children of the matched {@link Visitable} until {@link #leaveMatched(Visitable) leaving the matched}
  * {@link Visitable}.</li>
  * </ol>
- *
+ * </p>
+ * 
  * @author Mark Paluch
  * @since 1.1
  * @see FilteredSubtreeVisitor