Skip to content

Commit 2a9977f

Browse files
committed
Change BeforeSaveEvent to BeforeConvertEvent in integration tests where callback was setting id.
+ Ids must be set before the aggregate root is converted to a change, since inserts now depend on whether the id is set.
1 parent 38cb282 commit 2a9977f

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/JdbcRepositoryPropertyConversionIntegrationTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
import org.springframework.data.jdbc.testing.EnabledOnFeature;
4747
import org.springframework.data.jdbc.testing.TestConfiguration;
4848
import org.springframework.data.relational.core.mapping.MappedCollection;
49-
import org.springframework.data.relational.core.mapping.event.BeforeSaveEvent;
49+
import org.springframework.data.relational.core.mapping.event.BeforeConvertEvent;
5050
import org.springframework.data.repository.CrudRepository;
5151
import org.springframework.test.context.ContextConfiguration;
5252
import org.springframework.test.context.TestExecutionListeners;
@@ -182,7 +182,7 @@ DummyEntityRepository dummyEntityRepository() {
182182

183183
@Bean
184184
ApplicationListener<?> applicationListener() {
185-
return (ApplicationListener<BeforeSaveEvent>) beforeInsert -> ((EntityWithColumnsRequiringConversions) beforeInsert
185+
return (ApplicationListener<BeforeConvertEvent>) event -> ((EntityWithColumnsRequiringConversions) event
186186
.getEntity()).setIdTimestamp(getNow());
187187
}
188188
}

spring-data-jdbc/src/test/java/org/springframework/data/jdbc/repository/JdbcRepositoryWithCollectionsAndManuallyAssignedIdHsqlIntegrationTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
import org.springframework.data.annotation.Id;
3737
import org.springframework.data.jdbc.repository.support.JdbcRepositoryFactory;
3838
import org.springframework.data.jdbc.testing.TestConfiguration;
39-
import org.springframework.data.relational.core.mapping.event.BeforeSaveEvent;
39+
import org.springframework.data.relational.core.mapping.event.BeforeConvertEvent;
4040
import org.springframework.data.repository.CrudRepository;
4141
import org.springframework.jdbc.core.namedparam.NamedParameterJdbcTemplate;
4242
import org.springframework.test.context.ActiveProfiles;
@@ -76,7 +76,7 @@ DummyEntityRepository dummyEntityRepository() {
7676
@Bean
7777
public ApplicationListener<?> idSetting() {
7878

79-
return (ApplicationListener<BeforeSaveEvent>) event -> {
79+
return (ApplicationListener<BeforeConvertEvent>) event -> {
8080

8181
if (event.getEntity() instanceof DummyEntity) {
8282
setIds((DummyEntity) event.getEntity());

0 commit comments

Comments
 (0)