RedisScript of method improvement [DATAREDIS-1030]

[spring-projects-issues]

cuillgln opened DATAREDIS-1030 and commented

Hi, when I use redis scripting in spring boot2. with the code following:

@Bean
public RedisScript<Boolean> script() {
  String script = ....;
  return RedisScript.of(script);
}

the I'm tesing the code with IllegalStateException (detail in the attachment).

Finally, I found there is also a method: RedisScript.of(String script, Class<T> classType)
using the RedisScript.of(script, Boolean.class) for the testing is all correct.

But this method DO NOT return a generic RedisScript .

This is the problem, because the IDE complaint...

I think the api should improve. and the RedisScript.of(String script) method without classType parameter can cause problem difficult resolve.

Also this section of the reference document is obsolute.

@Bean
public RedisScript<Boolean> script() {
  ScriptSource scriptSource = new ResourceScriptSource(new ClassPathResource("META-INF/scripts/checkandset.lua"); 
  return RedisScript.of(scriptSource, Boolean.class);
}

the of method first parameter is String type, not the ScriptSource type. It would be update.

 

---

Affects: 2.1.10 (Lovelace SR10)

Attachments:

• eval scrit exception.txt (16.40 kB)

Referenced from: pull request #473