LettuceConnectionFactory.destroy() should release reactiveConnectionProvider resources [DATAREDIS-1027]

[spring-projects-issues]

Kevin Qian opened DATAREDIS-1027 and commented

// code placeholder
public void destroy() {

   resetConnection();

   if (connectionProvider instanceof DisposableBean) {
      try {
         ((DisposableBean) connectionProvider).destroy();
      } catch (Exception e) {

         if (log.isWarnEnabled()) {
            log.warn(connectionProvider + " did not shut down gracefully.", e);
         }
      }
   }

   try {
      Duration timeout = clientConfiguration.getShutdownTimeout();
      client.shutdown(timeout.toMillis(), timeout.toMillis(), TimeUnit.MILLISECONDS);
   } catch (Exception e) {

      if (log.isWarnEnabled()) {
         log.warn((client != null ? ClassUtils.getShortName(client.getClass()) : "LettuceClient")
               + " did not shut down gracefully.", e);
      }
   }

   if (clusterCommandExecutor != null) {

      try {
         clusterCommandExecutor.destroy();
      } catch (Exception ex) {
         log.warn("Cannot properly close cluster command executor", ex);
      }
   }
}

should we need to invoke destroy method of reactiveConnectionProvider object to release resources?

---

Referenced from: pull request #470

Backported to: 2.1.11 (Lovelace SR11)

[spring-projects-issues]

Mark Paluch commented

Good catch. It makes sense to dispose the reactive connection provider to release a backing connection pool