Skip to content

Commit f002bea

Browse files
committed
Make RedisConnectionProxy public.
RedisConnectionProxy is now public so it can be used properly for Java proxy creation across different class loaders. Previously, creating a Java proxy from a different class loader failed because of visibility/access restrictions. Closes #2016
1 parent 3b499c9 commit f002bea

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

Diff for: src/main/java/org/springframework/data/redis/core/RedisConnectionUtils.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -626,7 +626,7 @@ public void clear() {
626626
* @since 2.4.2
627627
* @see RedisConnectionUtils#getTargetConnection(RedisConnection)
628628
*/
629-
interface RedisConnectionProxy extends RedisConnection, RawTargetAccess {
629+
public interface RedisConnectionProxy extends RedisConnection, RawTargetAccess {
630630

631631
/**
632632
* Return the target {@link RedisConnection} of this proxy.

Diff for: src/test/java/org/springframework/data/redis/core/RedisConnectionUtilsUnitTests.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -104,14 +104,15 @@ void getConnectionShouldBindConnectionToTransactionScopeWithReadOnlyTransaction(
104104
assertThat(TransactionSynchronizationManager.hasResource(factoryMock)).isFalse();
105105
}
106106

107-
@Test // DATAREDIS-891
107+
@Test // DATAREDIS-891, GH-2016
108108
void bindConnectionShouldBindConnectionToOngoingTransactionScope() {
109109

110110
TransactionTemplate template = new TransactionTemplate(new DummyTransactionManager());
111111

112112
template.executeWithoutResult(status -> {
113113

114-
assertThat(RedisConnectionUtils.bindConnection(factoryMock, true)).isNotNull();
114+
assertThat(RedisConnectionUtils.bindConnection(factoryMock, true))
115+
.isInstanceOf(RedisConnectionUtils.RedisConnectionProxy.class);
115116
assertThat(TransactionSynchronizationManager.hasResource(factoryMock)).isTrue();
116117
assertThat(RedisConnectionUtils.getConnection(factoryMock)).isNotNull();
117118

0 commit comments

Comments
 (0)