DATAREDIS-974 - Polishing.

Consistently use getClientName() instead of qualified configuration accessor. Add missing Nullable annotation to getPassword() method. Reformat.

Original pull request: #472.

Author: mp911de

src/main/java/org/springframework/data/redis/connection/jedis/JedisConnectionFactory.java

@@ -425,9 +425,9 @@ protected JedisCluster createCluster(RedisClusterConfiguration clusterConfig, Ge
 		int redirects = clusterConfig.getMaxRedirects() != null ? clusterConfig.getMaxRedirects() : 5;
 
 		return new JedisCluster(hostAndPort, getConnectTimeout(), getReadTimeout(), redirects, getPassword(),
-				clientConfiguration.getClientName().orElse(null), poolConfig, isUseSsl(),
-				clientConfiguration.getSslSocketFactory().orElse(null), clientConfiguration.getSslParameters().orElse(null),
-				clientConfiguration.getHostnameVerifier().orElse(null), null);
+				getClientName(), poolConfig, isUseSsl(), clientConfiguration.getSslSocketFactory().orElse(null),
+				clientConfiguration.getSslParameters().orElse(null), clientConfiguration.getHostnameVerifier().orElse(null),
+				null);
 	}
 
 	/*
@@ -473,9 +473,8 @@ public RedisConnection getConnection() {
 		}
 
 		Jedis jedis = fetchJedisConnector();
-		String clientName = clientConfiguration.getClientName().orElse(null);
-		JedisConnection connection = (getUsePool() ? new JedisConnection(jedis, pool, getDatabase(), clientName)
-				: new JedisConnection(jedis, null, getDatabase(), clientName));
+		JedisConnection connection = (getUsePool() ? new JedisConnection(jedis, pool, getDatabase(), getClientName())
+				: new JedisConnection(jedis, null, getDatabase(), getClientName()));
 		connection.setConvertPipelineAndTxResults(convertPipelineAndTxResults);
 		return postProcessConnection(connection);
 	}
@@ -549,6 +548,7 @@ public void setUseSsl(boolean useSsl) {
 	 *
 	 * @return password for authentication.
 	 */
+	@Nullable
 	public String getPassword() {
 		return getRedisPassword().map(String::new).orElse(null);
 	}

src/test/java/org/springframework/data/redis/connection/jedis/JedisConnectionFactoryUnitTests.java

@@ -291,7 +291,7 @@ public void shouldReturnClusterConfiguration() {
 		assertThat(connectionFactory.getClusterConfiguration()).isSameAs(configuration);
 	}
 
-	@Test // DATAREDIS-975
+	@Test // DATAREDIS-974
 	public void shouldApplySslConfigWhenCreatingClusterClient() throws NoSuchAlgorithmException {
 
 		SSLParameters sslParameters = new SSLParameters();