DATAREDIS-1233 - Polishing.

Update license header, use early return for if statements and guard tests against failure when running against a single node instance.

Author: christophstrobl

src/test/java/org/springframework/data/redis/connection/jedis/JedisAclIntegrationTests.java

@@ -26,6 +26,7 @@
 import org.springframework.data.redis.connection.RedisSentinelConfiguration;
 import org.springframework.data.redis.connection.RedisSentinelConnection;
 import org.springframework.data.redis.connection.RedisStandaloneConfiguration;
+import org.springframework.data.redis.test.condition.EnabledOnRedisAvailable;
 import org.springframework.data.redis.test.condition.EnabledOnRedisSentinelAvailable;
 import org.springframework.data.redis.test.condition.EnabledOnRedisVersion;
 
@@ -35,6 +36,7 @@
  * @author Mark Paluch
  */
 @EnabledOnRedisVersion("6.0")
+@EnabledOnRedisAvailable(6382)
 class JedisAclIntegrationTests {
 
 	@Test

src/test/java/org/springframework/data/redis/connection/lettuce/LettuceReactiveCommandsTestSupport.java

@@ -29,10 +29,11 @@
 import java.util.ArrayList;
 import java.util.List;
 
+import org.assertj.core.api.Assumptions;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
-
 import org.springframework.data.redis.connection.lettuce.LettuceReactiveRedisConnection.ByteBufferCodec;
+import org.springframework.data.redis.test.condition.RedisDetector;
 import org.springframework.data.redis.test.extension.LettuceExtension;
 import org.springframework.data.redis.test.extension.parametrized.MethodSource;
 
@@ -151,11 +152,14 @@ public String toString() {
 	public void setUp() {
 
 		if (nativeConnectionProvider instanceof StandaloneConnectionProvider) {
+
 			nativeCommands = nativeConnectionProvider.getConnection(StatefulRedisConnection.class).sync();
 			nativeBinaryCommands = nativeBinaryConnectionProvider.getConnection(StatefulRedisConnection.class).sync();
 			this.connection = new LettuceReactiveRedisConnection(connectionProvider);
-
 		} else {
+
+			Assumptions.assumeThat(RedisDetector.isClusterAvailable()).isTrue();
+
 			ClusterConnectionProvider clusterConnectionProvider = (ClusterConnectionProvider) nativeConnectionProvider;
 			nativeCommands = nativeConnectionProvider.getConnection(StatefulRedisClusterConnection.class).sync();
 			nativeBinaryCommands = nativeBinaryConnectionProvider.getConnection(StatefulRedisClusterConnection.class).sync();

src/test/java/org/springframework/data/redis/test/condition/EnabledIfLongRunningTest.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2018-2020 the original author or authors.
+ * Copyright 2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

src/test/java/org/springframework/data/redis/test/condition/EnabledOnCommand.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2018-2020 the original author or authors.
+ * Copyright 2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

src/test/java/org/springframework/data/redis/test/condition/EnabledOnCommandCondition.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2018-2020 the original author or authors.
+ * Copyright 2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -25,44 +25,42 @@
 import org.junit.jupiter.api.extension.ExecutionCondition;
 import org.junit.jupiter.api.extension.ExtensionContext;
 import org.junit.platform.commons.util.AnnotationUtils;
-
 import org.springframework.data.redis.test.extension.LettuceExtension;
 
 /**
  * {@link ExecutionCondition} for {@link EnabledOnCommandCondition @EnabledOnCommand}.
  *
  * @see EnabledOnCommandCondition
+ * @author Mark Paluch
+ * @author Christoph Strobl
  */
 class EnabledOnCommandCondition implements ExecutionCondition {
 
 	private static final ConditionEvaluationResult ENABLED_BY_DEFAULT = enabled("@EnabledOnCommand is not present");
-	private static final ExtensionContext.Namespace NAMESPACE = ExtensionContext.Namespace
-			.create(RedisConditions.class);
+	private static final ExtensionContext.Namespace NAMESPACE = ExtensionContext.Namespace.create(RedisConditions.class);
 
 	@Override
 	@SuppressWarnings({ "rawtypes", "unchecked" })
 	public ConditionEvaluationResult evaluateExecutionCondition(ExtensionContext context) {
 
 		Optional<EnabledOnCommand> optional = AnnotationUtils.findAnnotation(context.getElement(), EnabledOnCommand.class);
 
-		if (optional.isPresent()) {
-
-			String command = optional.get().value();
+		if (!optional.isPresent()) {
+			return ENABLED_BY_DEFAULT;
+		}
 
-			ExtensionContext.Store store = context.getStore(NAMESPACE);
-			RedisConditions conditions = store.getOrComputeIfAbsent(RedisConditions.class, ignore -> {
+		String command = optional.get().value();
 
-				StatefulRedisConnection connection = new LettuceExtension().resolve(context, StatefulRedisConnection.class);
-				return RedisConditions.of(connection);
-			}, RedisConditions.class);
+		ExtensionContext.Store store = context.getStore(NAMESPACE);
+		RedisConditions conditions = store.getOrComputeIfAbsent(RedisConditions.class, ignore -> {
 
-			boolean hasCommand = conditions.hasCommand(command);
-			return hasCommand ? enabled("Enabled on command " + command)
-					: disabled(
-							"Disabled, command " + command + " not available on Redis version " + conditions.getRedisVersion());
-		}
+			StatefulRedisConnection connection = new LettuceExtension().resolve(context, StatefulRedisConnection.class);
+			return RedisConditions.of(connection);
+		}, RedisConditions.class);
 
-		return ENABLED_BY_DEFAULT;
+		boolean hasCommand = conditions.hasCommand(command);
+		return hasCommand ? enabled("Enabled on command " + command)
+				: disabled("Disabled, command " + command + " not available on Redis version " + conditions.getRedisVersion());
 	}
 
 }

src/test/java/org/springframework/data/redis/test/condition/EnabledOnRedisAvailable.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2018-2020 the original author or authors.
+ * Copyright 2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

src/test/java/org/springframework/data/redis/test/condition/EnabledOnRedisAvailableCondition.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2018-2020 the original author or authors.
+ * Copyright 2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -26,13 +26,13 @@
 import org.junit.jupiter.api.extension.ExecutionCondition;
 import org.junit.jupiter.api.extension.ExtensionContext;
 import org.junit.platform.commons.util.AnnotationUtils;
-
 import org.springframework.data.redis.SettingsUtils;
 
 /**
  * {@link ExecutionCondition} for {@link EnabledOnRedisAvailableCondition @EnabledOnRedisAvailable}.
  *
  * @author Mark Paluch
+ * @author Christoph Strobl
  * @see EnabledOnRedisAvailableCondition
  */
 class EnabledOnRedisAvailableCondition implements ExecutionCondition {
@@ -47,22 +47,21 @@ public ConditionEvaluationResult evaluateExecutionCondition(ExtensionContext con
 		Optional<EnabledOnRedisAvailable> optional = AnnotationUtils.findAnnotation(context.getElement(),
 				EnabledOnRedisAvailable.class);
 
-		if (optional.isPresent()) {
+		if (!optional.isPresent()) {
+			return ENABLED_BY_DEFAULT;
+		}
 
-			EnabledOnRedisAvailable annotation = optional.get();
+		EnabledOnRedisAvailable annotation = optional.get();
 
-			try (Socket socket = new Socket()) {
-				socket.connect(new InetSocketAddress(SettingsUtils.getHost(), annotation.value()), 100);
+		try (Socket socket = new Socket()) {
+			socket.connect(new InetSocketAddress(SettingsUtils.getHost(), annotation.value()), 100);
 
-				return enabled(
-						String.format("Connection successful to Redis at %s:%d", SettingsUtils.getHost(), annotation.value()));
-			} catch (IOException e) {
-				return disabled(
-						String.format("Cannot connect to Redis at %s:%d (%s)", SettingsUtils.getHost(), annotation.value(), e));
-			}
+			return enabled(
+					String.format("Connection successful to Redis at %s:%d", SettingsUtils.getHost(), annotation.value()));
+		} catch (IOException e) {
+			return disabled(
+					String.format("Cannot connect to Redis at %s:%d (%s)", SettingsUtils.getHost(), annotation.value(), e));
 		}
-
-		return ENABLED_BY_DEFAULT;
 	}
 
 }

src/test/java/org/springframework/data/redis/test/condition/EnabledOnRedisClusterAvailable.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2018-2020 the original author or authors.
+ * Copyright 2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

src/test/java/org/springframework/data/redis/test/condition/EnabledOnRedisClusterCondition.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2018-2020 the original author or authors.
+ * Copyright 2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -23,13 +23,13 @@
 import org.junit.jupiter.api.extension.ExecutionCondition;
 import org.junit.jupiter.api.extension.ExtensionContext;
 import org.junit.platform.commons.util.AnnotationUtils;
-
 import org.springframework.data.redis.SettingsUtils;
 
 /**
  * {@link ExecutionCondition} for {@link EnabledOnRedisClusterCondition @EnabledOnRedisClusterAvailable}.
  *
  * @author Mark Paluch
+ * @author Christoph Strobl
  * @see EnabledOnRedisClusterCondition
  */
 class EnabledOnRedisClusterCondition implements ExecutionCondition {
@@ -43,18 +43,17 @@ public ConditionEvaluationResult evaluateExecutionCondition(ExtensionContext con
 		Optional<EnabledOnRedisClusterAvailable> optional = AnnotationUtils.findAnnotation(context.getElement(),
 				EnabledOnRedisClusterAvailable.class);
 
-		if (optional.isPresent()) {
-
-			if (RedisDetector.isClusterAvailable()) {
-				return enabled(String.format("Connection successful to Redis Cluster at %s:%d", SettingsUtils.getHost(),
-						SettingsUtils.getClusterPort()));
-			}
+		if (!optional.isPresent()) {
+			return ENABLED_BY_DEFAULT;
+		}
 
-			return disabled(String.format("Cannot connect to Redis Cluster at %s:%d", SettingsUtils.getHost(),
+		if (RedisDetector.isClusterAvailable()) {
+			return enabled(String.format("Connection successful to Redis Cluster at %s:%d", SettingsUtils.getHost(),
 					SettingsUtils.getClusterPort()));
 		}
 
-		return ENABLED_BY_DEFAULT;
+		return disabled(String.format("Cannot connect to Redis Cluster at %s:%d", SettingsUtils.getHost(),
+				SettingsUtils.getClusterPort()));
 	}
 
 }

src/test/java/org/springframework/data/redis/test/condition/EnabledOnRedisDriverCondition.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2018-2020 the original author or authors.
+ * Copyright 2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -28,13 +28,13 @@
 import org.junit.platform.commons.function.Try;
 import org.junit.platform.commons.util.AnnotationUtils;
 import org.junit.platform.commons.util.ReflectionUtils;
-
 import org.springframework.data.redis.connection.RedisConnectionFactory;
 
 /**
  * {@link ExecutionCondition} for {@link EnabledOnRedisDriverCondition @EnabledOnRedisDriver}.
  *
  * @author Mark Paluch
+ * @author Christoph Strobl
  * @see EnabledOnRedisDriver
  */
 class EnabledOnRedisDriverCondition implements ExecutionCondition {
@@ -47,43 +47,42 @@ public ConditionEvaluationResult evaluateExecutionCondition(ExtensionContext con
 		Optional<EnabledOnRedisDriver> optional = AnnotationUtils.findAnnotation(context.getElement(),
 				EnabledOnRedisDriver.class);
 
-		if (optional.isPresent()) {
-
-			EnabledOnRedisDriver annotation = optional.get();
-			Class<?> testClass = context.getRequiredTestClass();
+		if (!optional.isPresent()) {
+			return ENABLED_BY_DEFAULT;
+		}
 
-			List<Field> annotatedFields = AnnotationUtils.findAnnotatedFields(testClass,
-					EnabledOnRedisDriver.DriverQualifier.class,
-					it -> RedisConnectionFactory.class.isAssignableFrom(it.getType()));
+		EnabledOnRedisDriver annotation = optional.get();
+		Class<?> testClass = context.getRequiredTestClass();
 
-			if (annotatedFields.isEmpty()) {
-				throw new IllegalStateException(
-						"@WithRedisDriver requires a field of type RedisConnectionFactory annotated with @DriverQualifier!");
-			}
+		List<Field> annotatedFields = AnnotationUtils.findAnnotatedFields(testClass,
+				EnabledOnRedisDriver.DriverQualifier.class, it -> RedisConnectionFactory.class.isAssignableFrom(it.getType()));
 
-			for (Field field : annotatedFields) {
-				Try<Object> fieldValue = ReflectionUtils.tryToReadFieldValue(field, context.getRequiredTestInstance());
+		if (annotatedFields.isEmpty()) {
+			throw new IllegalStateException(
+					"@WithRedisDriver requires a field of type RedisConnectionFactory annotated with @DriverQualifier!");
+		}
 
-				RedisConnectionFactory value = (RedisConnectionFactory) fieldValue
-						.getOrThrow(e -> new IllegalStateException("Cannot read field " + field, e));
+		for (Field field : annotatedFields) {
+			Try<Object> fieldValue = ReflectionUtils.tryToReadFieldValue(field, context.getRequiredTestInstance());
 
-				boolean foundMatch = false;
-				for (RedisDriver redisDriver : annotation.value()) {
-					if (redisDriver.matches(value)) {
-						foundMatch = true;
-					}
-				}
+			RedisConnectionFactory value = (RedisConnectionFactory) fieldValue
+					.getOrThrow(e -> new IllegalStateException("Cannot read field " + field, e));
 
-				if (!foundMatch) {
-					return disabled(String.format("Driver %s not supported. Supported driver(s): %s",
-							value, Arrays.toString(annotation.value())));
+			boolean foundMatch = false;
+			for (RedisDriver redisDriver : annotation.value()) {
+				if (redisDriver.matches(value)) {
+					foundMatch = true;
 				}
 			}
 
-			return enabled("Found enabled driver(s): " + Arrays.toString(annotation.value()));
+			if (!foundMatch) {
+				return disabled(String.format("Driver %s not supported. Supported driver(s): %s", value,
+						Arrays.toString(annotation.value())));
+			}
 		}
 
-		return ENABLED_BY_DEFAULT;
+		return enabled("Found enabled driver(s): " + Arrays.toString(annotation.value()));
+
 	}
 
 }

src/test/java/org/springframework/data/redis/test/condition/EnabledOnRedisSentinelAvailable.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2018-2020 the original author or authors.
+ * Copyright 2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

src/test/java/org/springframework/data/redis/test/condition/EnabledOnRedisSentinelCondition.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2018-2020 the original author or authors.
+ * Copyright 2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -23,13 +23,13 @@
 import org.junit.jupiter.api.extension.ExecutionCondition;
 import org.junit.jupiter.api.extension.ExtensionContext;
 import org.junit.platform.commons.util.AnnotationUtils;
-
 import org.springframework.data.redis.SettingsUtils;
 
 /**
  * {@link ExecutionCondition} for {@link EnabledOnRedisSentinelCondition @EnabledOnRedisSentinelAvailable}.
  *
  * @author Mark Paluch
+ * @author Christoph Strobl
  * @see EnabledOnRedisSentinelCondition
  */
 class EnabledOnRedisSentinelCondition implements ExecutionCondition {
@@ -44,21 +44,20 @@ public ConditionEvaluationResult evaluateExecutionCondition(ExtensionContext con
 		Optional<EnabledOnRedisSentinelAvailable> optional = AnnotationUtils.findAnnotation(context.getElement(),
 				EnabledOnRedisSentinelAvailable.class);
 
-		if (optional.isPresent()) {
-
-			EnabledOnRedisSentinelAvailable annotation = optional.get();
+		if (!optional.isPresent()) {
+			return ENABLED_BY_DEFAULT;
+		}
 
-			if (RedisDetector.canConnectToPort(annotation.value())) {
+		EnabledOnRedisSentinelAvailable annotation = optional.get();
 
-				return enabled(String.format("Connection successful to Redis Sentinel at %s:%d", SettingsUtils.getHost(),
-						annotation.value()));
-			}
+		if (RedisDetector.canConnectToPort(annotation.value())) {
 
-			return disabled(
-					String.format("Cannot connect to Redis Sentinel at %s:%d", SettingsUtils.getHost(), annotation.value()));
+			return enabled(String.format("Connection successful to Redis Sentinel at %s:%d", SettingsUtils.getHost(),
+					annotation.value()));
 		}
 
-		return ENABLED_BY_DEFAULT;
-	}
+		return disabled(
+				String.format("Cannot connect to Redis Sentinel at %s:%d", SettingsUtils.getHost(), annotation.value()));
 
+	}
 }