Fix invalid Javadoc references.

See #2175

Author: mp911de

Diff for: src/main/java/org/springframework/data/redis/cache/BatchStrategies.java

@@ -44,7 +44,7 @@ private BatchStrategies() {
 	 * A {@link BatchStrategy} using a single {@code KEYS} and {@code DEL} command to remove all matching keys.
 	 * {@code KEYS} scans the entire keyspace of the Redis database and can block the Redis worker thread for a long time
 	 * on large keyspaces.
-	 * <p/>
+	 * <p>
 	 * {@code KEYS} is supported for standalone and clustered (sharded) Redis operation modes.
 	 *
 	 * @return batching strategy using {@code KEYS}.
@@ -56,7 +56,7 @@ public static BatchStrategy keys() {
 	/**
 	 * A {@link BatchStrategy} using a {@code SCAN} cursors and potentially multiple {@code DEL} commands to remove all
 	 * matching keys. This strategy allows a configurable batch size to optimize for scan batching.
-	 * <p/>
+	 * <p>
 	 * Note that using the {@code SCAN} strategy might be not supported on all drivers and Redis operation modes.
 	 *
 	 * @return batching strategy using {@code SCAN}.

Diff for: src/main/java/org/springframework/data/redis/cache/BatchStrategy.java

@@ -19,9 +19,9 @@
 
 /**
  * A {@link BatchStrategy} to be used with {@link RedisCacheWriter}.
- * <p/>
+ * <p>
  * Mainly used to clear the cache.
- * <p/>
+ * <p>
  * Predefined strategies using the {@link BatchStrategies#keys() KEYS} or {@link BatchStrategies#scan(int) SCAN}
  * commands can be found in {@link BatchStrategies}.
  *

Diff for: src/main/java/org/springframework/data/redis/cache/RedisCache.java

@@ -39,7 +39,7 @@
 
 /**
  * {@link org.springframework.cache.Cache} implementation using for Redis as underlying store.
- * <p/>
+ * <p>
  * Use {@link RedisCacheManager} to create {@link RedisCache} instances.
  *
  * @author Christoph Strobl

Diff for: src/main/java/org/springframework/data/redis/cache/RedisCacheConfiguration.java

@@ -362,6 +362,7 @@ public void configureKeyConverters(Consumer<ConverterRegistry> registryConsumer)
 	 * <ul>
 	 * <li>{@link String} to {@link byte byte[]} using UTF-8 encoding.</li>
 	 * <li>{@link SimpleKey} to {@link String}</li>
+	 * </ul>
 	 *
 	 * @param registry must not be {@literal null}.
 	 */

Diff for: src/main/java/org/springframework/data/redis/cache/RedisCacheManager.java

@@ -32,10 +32,10 @@
 
 /**
  * {@link org.springframework.cache.CacheManager} backed by a {@link RedisCache Redis} cache.
- * <p />
+ * <p>
  * This cache manager creates caches by default upon first write. Empty caches are not visible on Redis due to how Redis
  * represents empty data structures.
- * <p />
+ * <p>
  * Caches requiring a different {@link RedisCacheConfiguration} than the default configuration can be specified via
  * {@link RedisCacheManagerBuilder#withInitialCacheConfigurations(Map)}.
  *
@@ -170,7 +170,7 @@ public RedisCacheManager(RedisCacheWriter cacheWriter, RedisCacheConfiguration d
 	 * <dt>locking</dt>
 	 * <dd>disabled</dd>
 	 * <dt>batch strategy</dt>
-	 * <dd>{@link BatchStrategy#keys() KEYS}</dd>
+	 * <dd>{@link BatchStrategies#keys()}</dd>
 	 * <dt>cache configuration</dt>
 	 * <dd>{@link RedisCacheConfiguration#defaultCacheConfig()}</dd>
 	 * <dt>initial caches</dt>
@@ -423,7 +423,7 @@ public RedisCacheManagerBuilder withCacheConfiguration(String cacheName,
 
 		/**
 		 * Disable in-flight {@link org.springframework.cache.Cache} creation for unconfigured caches.
-		 * <p />
+		 * <p>
 		 * {@link RedisCacheManager#getMissingCache(String)} returns {@literal null} for any unconfigured
 		 * {@link org.springframework.cache.Cache} instead of a new {@link RedisCache} instance. This allows eg.
 		 * {@link org.springframework.cache.support.CompositeCacheManager} to chime in.

Diff for: src/main/java/org/springframework/data/redis/connection/BitFieldSubCommands.java

@@ -113,7 +113,7 @@ protected BitFieldSubCommands set(BitFieldSet set) {
 	}
 
 	/**
-	 * Obtain a new {@link BitFieldIncrByBuilder} for creating and adding a {@link BitFieldIncrby} sub command.
+	 * Obtain a new {@link BitFieldIncrByBuilder} for creating and adding a {@link BitFieldIncrBy} sub command.
 	 *
 	 * @param type must not be {@literal null}.
 	 * @return
@@ -125,7 +125,7 @@ public BitFieldIncrByBuilder incr(BitFieldType type) {
 	/**
 	 * Create new {@link BitFieldSubCommands} adding given {@link BitFieldIncrBy} to the sub commands.
 	 *
-	 * @param get must not be {@literal null}.
+	 * @param incrBy must not be {@literal null}.
 	 * @return
 	 */
 	protected BitFieldSubCommands incr(BitFieldIncrBy incrBy) {

Diff for: src/main/java/org/springframework/data/redis/connection/ReactiveClusterServerCommands.java

@@ -56,7 +56,7 @@ public interface ReactiveClusterServerCommands extends ReactiveServerCommands {
 	 * Get time unix timestamp of last successful {@link #bgSave()} operation in seconds.
 	 *
 	 * @param node must not be {@literal null}.
-	 * @return @return {@link Mono} wrapping unix timestamp.
+	 * @return {@link Mono} wrapping unix timestamp.
 	 * @throws IllegalArgumentException when {@code node} is {@literal null}.
 	 * @see RedisServerCommands#lastSave()
 	 */
@@ -108,7 +108,6 @@ public interface ReactiveClusterServerCommands extends ReactiveServerCommands {
 	 * <li>cpu utilization</li>
 	 * <li>replication</li>
 	 * </ul>
-	 * <p>
 	 *
 	 * @param node must not be {@literal null}.
 	 * @return {@link Mono} wrapping server information.

Diff for: src/main/java/org/springframework/data/redis/connection/ReactiveGeoCommands.java

@@ -17,8 +17,6 @@
 
 import static org.springframework.data.redis.connection.RedisGeoCommands.*;
 
-import org.springframework.data.redis.domain.geo.GeoReference;
-import org.springframework.data.redis.domain.geo.GeoShape;
 import reactor.core.publisher.Flux;
 import reactor.core.publisher.Mono;
 
@@ -43,6 +41,8 @@
 import org.springframework.data.redis.connection.ReactiveRedisConnection.MultiValueResponse;
 import org.springframework.data.redis.connection.ReactiveRedisConnection.NumericResponse;
 import org.springframework.data.redis.connection.RedisGeoCommands.GeoRadiusCommandArgs.Flag;
+import org.springframework.data.redis.domain.geo.GeoReference;
+import org.springframework.data.redis.domain.geo.GeoShape;
 import org.springframework.lang.Nullable;
 import org.springframework.util.Assert;
 
@@ -1279,7 +1279,7 @@ public static GeoSearchCommand within(GeoShape shape) {
 		/**
 		 * Sets the geoset {@literal key}. Constructs a new command instance with all previously configured properties.
 		 *
-		 * @param member must not be {@literal null}.
+		 * @param reference must not be {@literal null}.
 		 * @return a new {@link GeoSearchCommand} with {@literal key} applied.
 		 */
 		public GeoSearchCommand at(GeoReference<ByteBuffer> reference) {
@@ -1292,7 +1292,7 @@ public GeoSearchCommand at(GeoReference<ByteBuffer> reference) {
 		/**
 		 * Sets the geoset {@literal key}. Constructs a new command instance with all previously configured properties.
 		 *
-		 * @param member must not be {@literal null}.
+		 * @param key must not be {@literal null}.
 		 * @return a new {@link GeoSearchCommand} with {@literal key} applied.
 		 */
 		public GeoSearchCommand in(ByteBuffer key) {
@@ -1370,7 +1370,7 @@ public static GeoSearchStoreCommand within(GeoShape shape) {
 		/**
 		 * Sets the geoset {@literal key}. Constructs a new command instance with all previously configured properties.
 		 *
-		 * @param member must not be {@literal null}.
+		 * @param reference must not be {@literal null}.
 		 * @return a new {@link GeoSearchStoreCommand} with {@literal key} applied.
 		 */
 		public GeoSearchStoreCommand at(GeoReference<ByteBuffer> reference) {
@@ -1383,7 +1383,7 @@ public GeoSearchStoreCommand at(GeoReference<ByteBuffer> reference) {
 		/**
 		 * Sets the geoset {@literal key}. Constructs a new command instance with all previously configured properties.
 		 *
-		 * @param member must not be {@literal null}.
+		 * @param key must not be {@literal null}.
 		 * @return a new {@link GeoSearchStoreCommand} with {@literal key} applied.
 		 */
 		public GeoSearchStoreCommand in(ByteBuffer key) {
@@ -1396,7 +1396,7 @@ public GeoSearchStoreCommand in(ByteBuffer key) {
 		/**
 		 * Sets the geoset {@literal destKey}. Constructs a new command instance with all previously configured properties.
 		 *
-		 * @param member must not be {@literal null}.
+		 * @param destKey must not be {@literal null}.
 		 * @return a new {@link GeoSearchStoreCommand} with {@literal destKey} applied.
 		 */
 		public GeoSearchStoreCommand storeAt(ByteBuffer destKey) {

Diff for: src/main/java/org/springframework/data/redis/connection/ReactiveKeyCommands.java

@@ -93,7 +93,7 @@ public CopyCommand to(ByteBuffer targetKey) {
 		/**
 		 * Applies {@code replace}. Constructs a new command instance with all previously configured properties.
 		 *
-		 * @param key must not be {@literal null}.
+		 * @param replace
 		 * @return a new {@link CopyCommand} with {@literal replace} applied.
 		 */
 		public CopyCommand replace(boolean replace) {

Diff for: src/main/java/org/springframework/data/redis/connection/ReactiveListCommands.java

@@ -830,7 +830,7 @@ default Mono<ByteBuffer> bLMove(ByteBuffer sourceKey, ByteBuffer destinationKey,
 	 * Atomically returns and removes the first/last element (head/tail depending on the {@code from} argument) of the
 	 * list stored at {@code sourceKey}, and pushes the element at the first/last element (head/tail depending on the
 	 * {@code to} argument) of the list stored at {@code destinationKey}.
-	 * <p/>
+	 * <p>
 	 * <b>Blocks connection</b> until element available or {@code timeout} reached.
 	 *
 	 * @param commands must not be {@literal null}.

Diff for: src/main/java/org/springframework/data/redis/connection/ReactivePubSubCommands.java

@@ -34,7 +34,7 @@ public interface ReactivePubSubCommands {
 
 	/**
 	 * Creates a subscription for this connection. Connections can have multiple {@link ReactiveSubscription}s.
-	 * <p/>
+	 * <p>
 	 * Use {@link #createSubscription(SubscriptionListener)} to get notified when the subscription completes.
 	 *
 	 * @return the subscription.
@@ -77,7 +77,7 @@ default Mono<Long> publish(ByteBuffer channel, ByteBuffer message) {
 	 * Subscribes the connection to the given {@code channels}. Once subscribed, a connection enters listening mode and
 	 * can only subscribe to other channels or unsubscribe. No other commands are accepted until the connection is
 	 * unsubscribed.
-	 * <p />
+	 * <p>
 	 * Note that cancellation of the {@link Flux} will unsubscribe from {@code channels}.
 	 *
 	 * @param channels channel names, must not be {@literal null}.
@@ -89,7 +89,7 @@ default Mono<Long> publish(ByteBuffer channel, ByteBuffer message) {
 	 * Subscribes the connection to all channels matching the given {@code patterns}. Once subscribed, a connection enters
 	 * listening mode and can only subscribe to other channels or unsubscribe. No other commands are accepted until the
 	 * connection is unsubscribed.
-	 * <p />
+	 * <p>
 	 * Note that cancellation of the {@link Flux} will unsubscribe from {@code patterns}.
 	 *
 	 * @param patterns channel name patterns, must not be {@literal null}.

Diff for: src/main/java/org/springframework/data/redis/connection/ReactiveServerCommands.java

@@ -96,7 +96,6 @@ public interface ReactiveServerCommands {
 	 * <li>cpu utilization</li>
 	 * <li>replication</li>
 	 * </ul>
-	 * <p>
 	 *
 	 * @return {@link Mono} wrapping server information.
 	 * @see <a href="https://redis.io/commands/info">Redis Documentation: INFO</a>

Diff for: src/main/java/org/springframework/data/redis/connection/ReactiveSetCommands.java

@@ -576,7 +576,7 @@ private SMIsMemberCommand(@Nullable ByteBuffer key, List<ByteBuffer> values) {
 		/**
 		 * Creates a new {@link SMIsMemberCommand} given one or more {@literal values}.
 		 *
-		 * @param value must not be {@literal null}.
+		 * @param values must not be {@literal null}.
 		 * @return a new {@link SMIsMemberCommand} for a {@literal value}.
 		 */
 		public static SMIsMemberCommand values(List<ByteBuffer> values) {

Diff for: src/main/java/org/springframework/data/redis/connection/ReactiveStringCommands.java

@@ -276,7 +276,7 @@ public static GetExCommand key(ByteBuffer key) {
 		/**
 		 * Applies {@link Expiration}. Constructs a new command instance with all previously configured properties.
 		 *
-		 * @param options must not be {@literal null}.
+		 * @param expiration must not be {@literal null}.
 		 * @return a new {@link GetExCommand} with {@link Expiration} applied.
 		 */
 		public GetExCommand withExpiration(Expiration expiration) {

Diff for: src/main/java/org/springframework/data/redis/connection/ReactiveSubscription.java

@@ -29,7 +29,7 @@
  * {@link #subscribe(ByteBuffer...) channels} and {@link #pSubscribe(ByteBuffer...) patterns}. It provides access to the
  * {@link ChannelMessage} {@link #receive() stream} that emits only messages for channels and patterns registered in
  * this {@link ReactiveSubscription}.
- * <p />
+ * <p>
  * A reactive Redis connection can have multiple subscriptions. If two or more subscriptions subscribe to the same
  * target (channel/pattern) and one unsubscribes, then the other one will no longer receive messages for the target due
  * to how Redis handled Pub/Sub subscription.
@@ -103,7 +103,7 @@ public interface ReactiveSubscription {
 	/**
 	 * Retrieve the message stream emitting {@link Message messages}. The resulting message stream contains only messages
 	 * for subscribed and registered {@link #getChannels() channels} and {@link #getPatterns() patterns}.
-	 * <p />
+	 * <p>
 	 * Stream publishing uses {@link reactor.core.publisher.ConnectableFlux} turning the stream into a hot sequence.
 	 * Emission is paused if there is no demand. Messages received in that time are buffered. This stream terminates
 	 * either if all subscribers unsubscribe or if this {@link Subscription} is {@link #cancel() is terminated}.

Diff for: src/main/java/org/springframework/data/redis/connection/ReactiveZSetCommands.java

@@ -1540,7 +1540,7 @@ public BZPopCommand blockingFor(Duration timeout) {
 		 * Applies a {@link Duration timeout}. Constructs a new command instance with all previously configured properties.
 		 *
 		 * @param timeout value.
-		 * @param timeout must not be {@literal null}.
+		 * @param timeUnit must not be {@literal null}.
 		 * @return a new {@link BZPopCommand} with {@link Duration timeout} applied.
 		 */
 		public BZPopCommand blockingFor(long timeout, TimeUnit timeUnit) {

Diff for: src/main/java/org/springframework/data/redis/connection/RedisClusterConfiguration.java

@@ -67,8 +67,7 @@ public RedisClusterConfiguration() {
 	 * clusterHostAndPorts[0] = 127.0.0.1:23679
 	 * clusterHostAndPorts[1] = 127.0.0.1:23680 ...
 	 * </code>
-	 *
-	 * <pre>
+	 * </pre>
 	 *
 	 * @param clusterNodes must not be {@literal null}.
 	 */

Diff for: src/main/java/org/springframework/data/redis/connection/RedisListCommands.java

@@ -218,7 +218,7 @@ default Long lPos(byte[] key, byte[] element) {
 	 * Atomically returns and removes the first/last element (head/tail depending on the {@code from} argument) of the
 	 * list stored at {@code sourceKey}, and pushes the element at the first/last element (head/tail depending on the
 	 * {@code to} argument) of the list stored at {@code destinationKey}.
-	 * <p/>
+	 * <p>
 	 * <b>Blocks connection</b> until element available or {@code timeout} reached.
 	 *
 	 * @param sourceKey must not be {@literal null}.

Diff for: src/main/java/org/springframework/data/redis/connection/RedisPassword.java

@@ -27,9 +27,9 @@
 
 /**
  * Value object which may or may not contain a Redis password.
- * <p/>
+ * <p>
  * If a password is present, {@code isPresent()} will return {@code true} and {@code get()} will return the value.
- * <p/>
+ * <p>
  * The password is stored as character array.
  *
  * @author Mark Paluch
@@ -109,7 +109,7 @@ public char[] get() throws NoSuchElementException {
 
 	/**
 	 * Map the password using a {@link Function} and return a {@link Optional} containing the mapped value.
-	 * <p/>
+	 * <p>
 	 * Absent passwords return a {@link Optional#empty()}.
 	 *
 	 * @param mapper must not be {@literal null}.
@@ -124,7 +124,7 @@ public <R> Optional<R> map(Function<char[], R> mapper) {
 
 	/**
 	 * Adopt the password to {@link Optional} containing the password value.
-	 * <p/>
+	 * <p>
 	 * Absent passwords return a {@link Optional#empty()}.
 	 *
 	 * @return the {@link Optional} containing the password value.

Diff for: src/main/java/org/springframework/data/redis/connection/RedisSentinelConfiguration.java

@@ -67,8 +67,7 @@ public RedisSentinelConfiguration() {
 	 *
 	 * <pre>
 	 * sentinelHostAndPorts[0] = 127.0.0.1:23679 sentinelHostAndPorts[1] = 127.0.0.1:23680 ...
-	 *
-	 * <pre>
+	 * </pre>
 	 *
 	 * @param sentinelHostAndPorts must not be {@literal null}.
 	 * @since 1.5

Diff for: src/main/java/org/springframework/data/redis/connection/RedisServerCommands.java

@@ -115,7 +115,6 @@ default void bgWriteAof() {
 	 * <li>cpu utilization</li>
 	 * <li>replication</li>
 	 * </ul>
-	 * <p>
 	 *
 	 * @return {@literal null} when used in pipeline / transaction.
 	 * @see <a href="https://redis.io/commands/info">Redis Documentation: INFO</a>

Diff for: src/main/java/org/springframework/data/redis/connection/RedisStreamCommands.java

@@ -87,9 +87,8 @@ default RecordId xAdd(byte[] key, Map<byte[], byte[]> content) {
 	}
 
 	/**
-	 * Append the given {@link MapRecord record} to the stream stored at {@link Record#getStream()}. <br />
-	 * If you prefer manual id assignment over server generated ones make sure to provide an id via
-	 * {@link Record#withId(RecordId)}.
+	 * Append the given {@link MapRecord record} to the stream stored at {@code Record#getStream}. If you prefer manual id
+	 * assignment over server generated ones make sure to provide an id via {@code Record#withId}.
 	 *
 	 * @param record the {@link MapRecord record} to append.
 	 * @return the {@link RecordId id} after save. {@literal null} when used in pipeline / transaction.
@@ -100,9 +99,8 @@ default RecordId xAdd(MapRecord<byte[], byte[], byte[]> record) {
 	}
 
 	/**
-	 * Append the given {@link MapRecord record} to the stream stored at {@link Record#getStream()}. <br />
-	 * If you prefer manual id assignment over server generated ones make sure to provide an id via
-	 * {@link Record#withId(RecordId)}.
+	 * Append the given {@link MapRecord record} to the stream stored at {@code Record#getStream}. If you prefer manual id
+	 * assignment over server generated ones make sure to provide an id via {@code Record#withId}.
 	 *
 	 * @param record the {@link MapRecord record} to append.
 	 * @param options additional options (eg. {@literal MAXLEN}). Must not be {@literal null}, use