Skip to content

Commit ee46695

Browse files
committed
#350 - Use Testcontainers constructor with image name.
Create database containers using the constructor accepting the image name to make sure that the exposed port gets registered. A recent change in Testcontainers caused that the port is no longer registered when using the default constructor.
1 parent 6cf4ae1 commit ee46695

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

src/test/java/org/springframework/data/r2dbc/testing/MariaDbTestSupport.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ private static ExternalDatabase testContainer() {
107107
if (testContainerDatabase == null) {
108108

109109
try {
110-
MariaDBContainer container = new MariaDBContainer();
110+
MariaDBContainer container = new MariaDBContainer(MariaDBContainer.IMAGE + ":" + MariaDBContainer.DEFAULT_TAG);
111111
container.start();
112112

113113
testContainerDatabase = ProvidedDatabase.builder(container) //

src/test/java/org/springframework/data/r2dbc/testing/MySqlTestSupport.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ private static ExternalDatabase testContainer() {
107107
if (testContainerDatabase == null) {
108108

109109
try {
110-
MySQLContainer container = new MySQLContainer();
110+
MySQLContainer container = new MySQLContainer(MySQLContainer.IMAGE + ":" + MySQLContainer.DEFAULT_TAG);
111111
container.start();
112112

113113
testContainerDatabase = ProvidedDatabase.builder(container) //

src/test/java/org/springframework/data/r2dbc/testing/PostgresTestSupport.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,8 @@ private static ExternalDatabase testContainer() {
8888
if (testContainerDatabase == null) {
8989

9090
try {
91-
PostgreSQLContainer container = new PostgreSQLContainer();
91+
PostgreSQLContainer container = new PostgreSQLContainer(
92+
PostgreSQLContainer.IMAGE + ":" + PostgreSQLContainer.DEFAULT_TAG);
9293
container.start();
9394

9495
testContainerDatabase = ProvidedDatabase.from(container);

0 commit comments

Comments
 (0)