Skip to content

Commit ed79d92

Browse files
committed
Polishing.
Extract docker credentials into properties file. See #715
1 parent 53d46b7 commit ed79d92

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

Jenkinsfile

+5-5
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ pipeline {
3737

3838
steps {
3939
script {
40-
docker.withRegistry('', 'hub.docker.com-springbuildmaster') {
40+
docker.withRegistry(p['docker.registry'], p['docker.credentials']) {
4141
docker.image(p['docker.java.main.image']).inside(p['docker.java.inside.docker']) {
4242
sh "docker login --username ${DOCKER_HUB_USR} --password ${DOCKER_HUB_PSW}"
4343
sh 'PROFILE=ci ci/test.sh'
@@ -69,7 +69,7 @@ pipeline {
6969

7070
steps {
7171
script {
72-
docker.withRegistry('', 'hub.docker.com-springbuildmaster') {
72+
docker.withRegistry(p['docker.registry'], p['docker.credentials']) {
7373
docker.image(p['docker.java.11.image']).inside(p['docker.java.inside.docker']) {
7474
sh "docker login --username ${DOCKER_HUB_USR} --password ${DOCKER_HUB_PSW}"
7575
sh 'PROFILE=ci,java11 ci/test.sh'
@@ -93,7 +93,7 @@ pipeline {
9393

9494
steps {
9595
script {
96-
docker.withRegistry('', 'hub.docker.com-springbuildmaster') {
96+
docker.withRegistry(p['docker.registry'], p['docker.credentials']) {
9797
docker.image(p['docker.java.15.image']).inside(p['docker.java.inside.docker']) {
9898
sh "docker login --username ${DOCKER_HUB_USR} --password ${DOCKER_HUB_PSW}"
9999
sh 'PROFILE=ci,java11 ci/test.sh'
@@ -124,7 +124,7 @@ pipeline {
124124

125125
steps {
126126
script {
127-
docker.withRegistry('', 'hub.docker.com-springbuildmaster') {
127+
docker.withRegistry(p['docker.registry'], p['docker.credentials']) {
128128
docker.image(p['docker.java.main.image']).inside(p['docker.java.inside.basic']) {
129129
sh 'MAVEN_OPTS="-Duser.name=jenkins -Duser.home=/tmp/jenkins-home" ./mvnw -s settings.xml -Pci,artifactory -Dmaven.repo.local=/tmp/jenkins-home/.m2/spring-data-r2dbc-non-root ' +
130130
'-Dartifactory.server=https://repo.spring.io ' +
@@ -155,7 +155,7 @@ pipeline {
155155

156156
steps {
157157
script {
158-
docker.withRegistry('', 'hub.docker.com-springbuildmaster') {
158+
docker.withRegistry(p['docker.registry'], p['docker.credentials']) {
159159
docker.image('adoptopenjdk/openjdk8:latest').inside('-v $HOME:/tmp/jenkins-home') {
160160
sh 'MAVEN_OPTS="-Duser.name=jenkins -Duser.home=/tmp/jenkins-home" ./mvnw -s settings.xml -Pci,distribute -Dmaven.repo.local=/tmp/jenkins-home/.m2/spring-data-r2dbc-non-root ' +
161161
'-Dartifactory.server=https://repo.spring.io ' +

ci/pipeline.properties

+8-4
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
# Java versions
22
java.main.tag=8u312-b07-jdk
3-
java.next.tag=11.0.13_8-jdk
4-
java.lts.tag=17.0.1_12-jdk
3+
java.11.tag=11.0.13_8-jdk
4+
java.15.tag=15.0.2_7-jdk-hotspot
55

66
# Docker container images - standard
77
docker.java.main.image=eclipse-temurin:${java.main.tag}
8-
docker.java.next.image=eclipse-temurin:${java.next.tag}
9-
docker.java.lts.image=eclipse-temurin:${java.lts.tag}
8+
docker.java.11.image=eclipse-temurin:${java.11.tag}
9+
docker.java.15.image=adoptopenjdk:${java.15.tag}
1010

1111
# Supported versions of MongoDB
1212
docker.mongodb.4.0.version=4.0.23
@@ -22,3 +22,7 @@ docker.cassandra.3.version=3.11.10
2222
# Docker environment settings
2323
docker.java.inside.basic=-v $HOME:/tmp/jenkins-home
2424
docker.java.inside.docker=-u root -v /var/run/docker.sock:/var/run/docker.sock -v /usr/bin/docker:/usr/bin/docker -v $HOME:/tmp/jenkins-home
25+
26+
# Credentials
27+
docker.registry=
28+
docker.credentials=hub.docker.com-springbuildmaster

0 commit comments

Comments
 (0)