Skip to content

Commit a46b675

Browse files
committed
Polishing.
Improve default converter setup by considering R2dbcCustomConversions.STORE_CONVERSIONS to register built-in converters in default configurations. See #612
1 parent 9b12bce commit a46b675

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

src/main/java/org/springframework/data/r2dbc/convert/MappingR2dbcConverter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public class MappingR2dbcConverter extends BasicRelationalConverter implements R
7070
*/
7171
public MappingR2dbcConverter(
7272
MappingContext<? extends RelationalPersistentEntity<?>, ? extends RelationalPersistentProperty> context) {
73-
super(context, new R2dbcCustomConversions(CustomConversions.StoreConversions.NONE, Collections.emptyList()));
73+
super(context, new R2dbcCustomConversions(R2dbcCustomConversions.STORE_CONVERSIONS, Collections.emptyList()));
7474
}
7575

7676
/**

src/main/java/org/springframework/data/r2dbc/convert/R2dbcCustomConversions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public class R2dbcCustomConversions extends CustomConversions {
2424

2525
public static final List<Object> STORE_CONVERTERS;
2626

27-
private static final StoreConversions STORE_CONVERSIONS;
27+
public static final StoreConversions STORE_CONVERSIONS;
2828

2929
static {
3030

src/test/java/org/springframework/data/r2dbc/repository/query/StringBasedR2dbcQueryUnitTests.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
import org.springframework.data.r2dbc.convert.MappingR2dbcConverter;
4343
import org.springframework.data.r2dbc.core.DefaultReactiveDataAccessStrategy;
4444
import org.springframework.data.r2dbc.core.R2dbcEntityOperations;
45+
import org.springframework.data.r2dbc.core.R2dbcEntityTemplate;
4546
import org.springframework.data.r2dbc.core.ReactiveDataAccessStrategy;
4647
import org.springframework.data.r2dbc.dialect.PostgresDialect;
4748
import org.springframework.data.r2dbc.mapping.R2dbcMappingContext;
@@ -54,6 +55,7 @@
5455
import org.springframework.data.repository.query.Param;
5556
import org.springframework.data.repository.query.ReactiveQueryMethodEvaluationContextProvider;
5657
import org.springframework.expression.spel.standard.SpelExpressionParser;
58+
import org.springframework.r2dbc.core.DatabaseClient;
5759
import org.springframework.r2dbc.core.Parameter;
5860
import org.springframework.r2dbc.core.PreparedOperation;
5961
import org.springframework.r2dbc.core.binding.BindTarget;
@@ -216,8 +218,7 @@ void bindsPositionalNamedSpelQuery() {
216218

217219
PreparedOperation<?> stringQuery = query.createQuery(accessor).block();
218220

219-
assertThat(stringQuery.get())
220-
.isEqualTo("SELECT * FROM person WHERE lastname = $1 and firstname = $2");
221+
assertThat(stringQuery.get()).isEqualTo("SELECT * FROM person WHERE lastname = $1 and firstname = $2");
221222
stringQuery.bindTo(bindTarget);
222223

223224
verify(bindTarget).bind(0, "White");
@@ -284,7 +285,7 @@ void usesDtoTypeForDtoResultMapping() {
284285
assertThat(query.resolveResultType(query.getQueryMethod().getResultProcessor())).isEqualTo(PersonDto.class);
285286
}
286287

287-
@Test // gh-475
288+
@Test // gh-612
288289
void selectsSimpleType() {
289290

290291
MockRowMetadata metadata = MockRowMetadata.builder()
@@ -296,9 +297,10 @@ void selectsSimpleType() {
296297
StatementRecorder recorder = StatementRecorder.newInstance();
297298
recorder.addStubbing(s -> s.equals("SELECT MAX(DATE)"), result);
298299

299-
databaseClient = DatabaseClient.builder() //
300+
DatabaseClient databaseClient = DatabaseClient.builder() //
300301
.connectionFactory(recorder) //
301302
.bindMarkers(PostgresDialect.INSTANCE.getBindMarkersFactory()).build();
303+
entityOperations = new R2dbcEntityTemplate(databaseClient, PostgresDialect.INSTANCE, converter);
302304

303305
StringBasedR2dbcQuery query = getQueryMethod("findAllLocalDates");
304306

0 commit comments

Comments
 (0)