#95 - Use customized ConnectionFactory lookup to avoid AbstractR2dbcConfiguration proxying.

We now attempt to lookup ConnectionFactory from ApplicationContext and fall back to a local
method call if ConnectionFactory is not exposed as bean.

Author: mp911de

src/main/java/org/springframework/data/r2dbc/config/AbstractR2dbcConfiguration.java

@@ -20,6 +20,9 @@
 import java.util.Collections;
 import java.util.Optional;
 
+import org.springframework.beans.BeansException;
+import org.springframework.context.ApplicationContext;
+import org.springframework.context.ApplicationContextAware;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.core.convert.converter.Converter;
@@ -37,6 +40,7 @@
 import org.springframework.data.relational.core.conversion.BasicRelationalConverter;
 import org.springframework.data.relational.core.mapping.NamingStrategy;
 import org.springframework.data.relational.core.mapping.RelationalMappingContext;
+import org.springframework.lang.Nullable;
 import org.springframework.util.Assert;
 
 /**
@@ -48,8 +52,19 @@
  * @see DatabaseClient
  * @see org.springframework.data.r2dbc.repository.config.EnableR2dbcRepositories
  */
-@Configuration
-public abstract class AbstractR2dbcConfiguration {
+@Configuration(proxyBeanMethods = false)
+public abstract class AbstractR2dbcConfiguration implements ApplicationContextAware {
+
+	private @Nullable ApplicationContext context;
+
+	/*
+	 * (non-Javadoc)
+	 * @see org.springframework.context.ApplicationContextAware#setApplicationContext(org.springframework.context.ApplicationContext)
+	 */
+	@Override
+	public void setApplicationContext(ApplicationContext applicationContext) throws BeansException {
+		this.context = applicationContext;
+	}
 
 	/**
 	 * Return a R2DBC {@link ConnectionFactory}. Annotate with {@link Bean} in case you want to expose a
@@ -91,7 +106,7 @@ public DatabaseClient databaseClient(ReactiveDataAccessStrategy dataAccessStrate
 		Assert.notNull(exceptionTranslator, "ExceptionTranslator must not be null!");
 
 		return DatabaseClient.builder() //
-				.connectionFactory(connectionFactory()) //
+				.connectionFactory(lookupConnectionFactory()) //
 				.dataAccessStrategy(dataAccessStrategy) //
 				.exceptionTranslator(exceptionTranslator) //
 				.build();
@@ -137,7 +152,7 @@ public ReactiveDataAccessStrategy reactiveDataAccessStrategy(RelationalMappingCo
 
 		MappingR2dbcConverter converter = new MappingR2dbcConverter(mappingContext, r2dbcCustomConversions);
 
-		return new DefaultReactiveDataAccessStrategy(getDialect(connectionFactory()), converter);
+		return new DefaultReactiveDataAccessStrategy(getDialect(lookupConnectionFactory()), converter);
 	}
 
 	/**
@@ -160,7 +175,7 @@ public R2dbcCustomConversions r2dbcCustomConversions() {
 	 */
 	protected StoreConversions getStoreConversions() {
 
-		Dialect dialect = getDialect(connectionFactory());
+		Dialect dialect = getDialect(lookupConnectionFactory());
 		return StoreConversions.of(dialect.getSimpleTypeHolder(), R2dbcCustomConversions.STORE_CONVERTERS);
 	}
 
@@ -172,6 +187,18 @@ protected StoreConversions getStoreConversions() {
 	 */
 	@Bean
 	public R2dbcExceptionTranslator exceptionTranslator() {
-		return new SqlErrorCodeR2dbcExceptionTranslator(connectionFactory());
+		return new SqlErrorCodeR2dbcExceptionTranslator(lookupConnectionFactory());
+	}
+
+	private ConnectionFactory lookupConnectionFactory() {
+
+		ApplicationContext context = this.context;
+		Assert.notNull(context, "ApplicationContext is not yet initialized");
+
+		if (context.getBeanNamesForType(ConnectionFactory.class).length != 0) {
+			return context.getBean(ConnectionFactory.class);
+		}
+
+		return connectionFactory();
 	}
 }

src/test/java/org/springframework/data/r2dbc/config/R2dbcConfigurationTests.java

@@ -0,0 +1,94 @@
+/*
+ * Copyright 2019 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.springframework.data.r2dbc.config;
+
+import static org.assertj.core.api.Assertions.*;
+
+import io.r2dbc.h2.H2ConnectionConfiguration;
+import io.r2dbc.h2.H2ConnectionFactory;
+import io.r2dbc.spi.ConnectionFactory;
+
+import org.junit.Test;
+
+import org.springframework.context.annotation.AnnotationConfigApplicationContext;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+import org.springframework.data.r2dbc.function.DatabaseClient;
+
+/**
+ * Tests for {@link AbstractR2dbcConfiguration}.
+ *
+ * @author Mark Paluch
+ */
+public class R2dbcConfigurationTests {
+
+	@Test // gh-95
+	public void shouldLookupConnectionFactoryThroughLocalCall() {
+
+		AnnotationConfigApplicationContext context = new AnnotationConfigApplicationContext(
+				NonBeanConnectionFactoryConfiguration.class);
+
+		context.getBean(DatabaseClient.class);
+
+		NonBeanConnectionFactoryConfiguration bean = context.getBean(NonBeanConnectionFactoryConfiguration.class);
+
+		assertThat(context.getBeanNamesForType(ConnectionFactory.class)).isEmpty();
+		assertThat(bean.callCounter).isGreaterThan(2);
+
+		context.stop();
+	}
+
+	@Test // gh-95
+	public void shouldRegisterConnectionFactory() {
+
+		AnnotationConfigApplicationContext context = new AnnotationConfigApplicationContext(
+				BeanConnectionFactoryConfiguration.class);
+
+		context.getBean(DatabaseClient.class);
+
+		BeanConnectionFactoryConfiguration bean = context.getBean(BeanConnectionFactoryConfiguration.class);
+
+		assertThat(bean.callCounter).isEqualTo(1);
+		assertThat(context.getBeanNamesForType(ConnectionFactory.class)).hasSize(1);
+
+		context.stop();
+	}
+
+	@Configuration(proxyBeanMethods = false)
+	static class NonBeanConnectionFactoryConfiguration extends AbstractR2dbcConfiguration {
+
+		int callCounter;
+
+		@Override
+		public ConnectionFactory connectionFactory() {
+
+			callCounter++;
+			return new H2ConnectionFactory(
+					H2ConnectionConfiguration.builder().inMemory("foo").username("sa").password("").build());
+		}
+	}
+
+	@Configuration(proxyBeanMethods = false)
+	static class BeanConnectionFactoryConfiguration extends NonBeanConnectionFactoryConfiguration {
+
+		@Override
+		@Bean
+		public ConnectionFactory connectionFactory() {
+			return super.connectionFactory();
+		}
+	}
+
+}