Skip to content

Commit 81ccfb3

Browse files
committed
Disable Oracle integration tests.
Disabling tests until the driver no longer throws NullPointerException on Statement.returnGeneratedKeys(). See #710
1 parent c1c6ebf commit 81ccfb3

File tree

4 files changed

+6
-1
lines changed

4 files changed

+6
-1
lines changed

src/test/java/org/springframework/data/r2dbc/core/OracleDatabaseClientIntegrationTests.java

+1
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
* @author Mark Paluch
3333
*/
3434
@EnabledOnClass("oracle.r2dbc.impl.OracleConnectionFactoryProviderImpl")
35+
@Disabled("See https://github.com/oracle/oracle-r2dbc/issues/63")
3536
public class OracleDatabaseClientIntegrationTests extends AbstractDatabaseClientIntegrationTests {
3637

3738
@RegisterExtension public static final ExternalDatabase database = OracleTestSupport.database();

src/test/java/org/springframework/data/r2dbc/repository/OracleR2dbcRepositoryIntegrationTests.java

+2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
import javax.sql.DataSource;
2323

24+
import org.junit.jupiter.api.Disabled;
2425
import org.junit.jupiter.api.extension.ExtendWith;
2526
import org.junit.jupiter.api.extension.RegisterExtension;
2627

@@ -45,6 +46,7 @@
4546
@ExtendWith(SpringExtension.class)
4647
@ContextConfiguration
4748
@EnabledOnClass("oracle.r2dbc.impl.OracleConnectionFactoryProviderImpl")
49+
@Disabled("See https://github.com/oracle/oracle-r2dbc/issues/63")
4850
public class OracleR2dbcRepositoryIntegrationTests extends AbstractR2dbcRepositoryIntegrationTests {
4951

5052
@RegisterExtension public static final ExternalDatabase database = OracleTestSupport.database();

src/test/java/org/springframework/data/r2dbc/repository/OracleR2dbcRepositoryWithMixedCaseNamesIntegrationTests.java

+2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
import javax.sql.DataSource;
2323

24+
import org.junit.jupiter.api.Disabled;
2425
import org.junit.jupiter.api.extension.ExtendWith;
2526
import org.junit.jupiter.api.extension.RegisterExtension;
2627

@@ -48,6 +49,7 @@
4849
@ExtendWith(SpringExtension.class)
4950
@ContextConfiguration
5051
@EnabledOnClass("oracle.r2dbc.impl.OracleConnectionFactoryProviderImpl")
52+
@Disabled("See https://github.com/oracle/oracle-r2dbc/issues/63")
5153
public class OracleR2dbcRepositoryWithMixedCaseNamesIntegrationTests
5254
extends AbstractR2dbcRepositoryWithMixedCaseNamesIntegrationTests {
5355

src/test/java/org/springframework/data/r2dbc/testing/OracleTestSupport.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ private static ExternalDatabase testContainer() {
124124
if (testContainerDatabase == null) {
125125

126126
try {
127-
OracleContainer container = new OracleContainer("springci/spring-data-oracle-xe-prebuild:18.4.0")
127+
OracleContainer container = new OracleContainer("gvenzl/oracle-xe:18.4.0")
128128
.withReuse(true);
129129
container.start();
130130

0 commit comments

Comments
 (0)