Skip to content

Commit 7ed68ee

Browse files
committed
#311 - Use R2dbcMappingContext in AbstractR2dbcConfiguration instead of RelationalMappingContext.
We use now a more concrete type in the configuration to avoid clashes when Spring Data JDBC is on the class path.
1 parent 6027e29 commit 7ed68ee

File tree

1 file changed

+9
-11
lines changed

1 file changed

+9
-11
lines changed

src/main/java/org/springframework/data/r2dbc/config/AbstractR2dbcConfiguration.java

+9-11
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
import org.springframework.data.r2dbc.support.SqlStateR2dbcExceptionTranslator;
4545
import org.springframework.data.relational.core.conversion.BasicRelationalConverter;
4646
import org.springframework.data.relational.core.mapping.NamingStrategy;
47-
import org.springframework.data.relational.core.mapping.RelationalMappingContext;
4847
import org.springframework.lang.Nullable;
4948
import org.springframework.util.Assert;
5049

@@ -95,7 +94,7 @@ public R2dbcDialect getDialect(ConnectionFactory connectionFactory) {
9594
}
9695

9796
/**
98-
* Register a {@link DatabaseClient} using {@link #connectionFactory()} and {@link RelationalMappingContext}.
97+
* Register a {@link DatabaseClient} using {@link #connectionFactory()} and {@link ReactiveDataAccessStrategy}.
9998
*
10099
* @return must not be {@literal null}.
101100
* @throws IllegalArgumentException if any of the required args is {@literal null}.
@@ -122,39 +121,38 @@ public DatabaseClient databaseClient(ReactiveDataAccessStrategy dataAccessStrate
122121
}
123122

124123
/**
125-
* Register a {@link RelationalMappingContext} and apply an optional {@link NamingStrategy}.
124+
* Register a {@link R2dbcMappingContext} and apply an optional {@link NamingStrategy}.
126125
*
127126
* @param namingStrategy optional {@link NamingStrategy}. Use {@link NamingStrategy#INSTANCE} as fallback.
128127
* @param r2dbcCustomConversions customized R2DBC conversions.
129128
* @return must not be {@literal null}.
130129
* @throws IllegalArgumentException if any of the required args is {@literal null}.
131130
*/
132131
@Bean
133-
public RelationalMappingContext r2dbcMappingContext(Optional<NamingStrategy> namingStrategy,
132+
public R2dbcMappingContext r2dbcMappingContext(Optional<NamingStrategy> namingStrategy,
134133
R2dbcCustomConversions r2dbcCustomConversions) {
135134

136135
Assert.notNull(namingStrategy, "NamingStrategy must not be null!");
137136

138-
R2dbcMappingContext relationalMappingContext = new R2dbcMappingContext(
139-
namingStrategy.orElse(NamingStrategy.INSTANCE));
140-
relationalMappingContext.setSimpleTypeHolder(r2dbcCustomConversions.getSimpleTypeHolder());
137+
R2dbcMappingContext context = new R2dbcMappingContext(namingStrategy.orElse(NamingStrategy.INSTANCE));
138+
context.setSimpleTypeHolder(r2dbcCustomConversions.getSimpleTypeHolder());
141139

142-
return relationalMappingContext;
140+
return context;
143141
}
144142

145143
/**
146144
* Creates a {@link ReactiveDataAccessStrategy} using the configured
147-
* {@link #r2dbcMappingContext(Optional, R2dbcCustomConversions)} RelationalMappingContext}.
145+
* {@link #r2dbcMappingContext(Optional, R2dbcCustomConversions)} R2dbcMappingContext}.
148146
*
149-
* @param mappingContext the configured {@link RelationalMappingContext}.
147+
* @param mappingContext the configured {@link R2dbcMappingContext}.
150148
* @param r2dbcCustomConversions customized R2DBC conversions.
151149
* @return must not be {@literal null}.
152150
* @see #r2dbcMappingContext(Optional, R2dbcCustomConversions)
153151
* @see #getDialect(ConnectionFactory)
154152
* @throws IllegalArgumentException if any of the {@literal mappingContext} is {@literal null}.
155153
*/
156154
@Bean
157-
public ReactiveDataAccessStrategy reactiveDataAccessStrategy(RelationalMappingContext mappingContext,
155+
public ReactiveDataAccessStrategy reactiveDataAccessStrategy(R2dbcMappingContext mappingContext,
158156
R2dbcCustomConversions r2dbcCustomConversions) {
159157

160158
Assert.notNull(mappingContext, "MappingContext must not be null!");

0 commit comments

Comments
 (0)