GH-2491 - Replace usage of deprecated PersistenceConstructor with PersistentCreator.

Closes #2491.

Author: michael-simons

src/main/asciidoc/object-mapping/mapping.adoc

@@ -46,7 +46,7 @@ See <<conversions>> for more information on that.
 * `@CreatedDate`: Applied at the field level to indicate the creation date of a node.
 * `@LastModifiedBy`: Applied at the field level to indicate the author of the last change to a node.
 * `@LastModifiedDate`: Applied at the field level to indicate the last modification date of a node.
-* `@PersistenceConstructor`: Applied at one constructor to mark it as the preferred constructor when reading entities.
+* `@PersistenceCreator`: Applied at one constructor to mark it as the preferred constructor when reading entities.
 * `@Persistent`: Applied at the class level to indicate this class is a candidate for mapping to the database.
 * `@Version`: Applied at field level it is used for optimistic locking and checked for modification on save operations.
  The initial value is zero which is bumped automatically on every update.

src/main/asciidoc/object-mapping/sdc-object-mapping.adoc

@@ -18,7 +18,7 @@ The resolution algorithm works as follows:
 1. If there is a no-argument constructor, it will be used.
 Other constructors will be ignored.
 2. If there is a single constructor taking arguments, it will be used.
-3. If there are multiple constructors taking arguments, the one to be used by Spring Data will have to be annotated with `@PersistenceConstructor`.
+3. If there are multiple constructors taking arguments, the one to be used by Spring Data will have to be annotated with `@PersistenceCreator`.
 
 The value resolution assumes constructor argument names to match the property names of the entity, i.e. the resolution will be performed as if the property was to be populated, including all customizations in mapping (different datastore column or field name etc.).
 This also requires either parameter names information available in the class file or an `@ConstructorProperties` annotation being present on the constructor.
@@ -201,7 +201,7 @@ Even if the intent is that the calculation should be preferred, it's important t
 <.> The `comment` property is mutable is populated by setting its field directly.
 <.> The `remarks` properties are mutable and populated by setting the `comment` field directly or by invoking the setter method for
 <.> The class exposes a factory method and a constructor for object creation.
-The core idea here is to use factory methods instead of additional constructors to avoid the need for constructor disambiguation through `@PersistenceConstructor`.
+The core idea here is to use factory methods instead of additional constructors to avoid the need for constructor disambiguation through `@PersistenceCreator`.
 Instead, defaulting of properties is handled within the factory method.
 
 [[mapping.fundamentals.recommendations]]
@@ -214,7 +214,7 @@ If you need those, prefer to make them package protected so that they can only b
 Constructor-only materialization is up to 30% faster than properties population.
 * _Provide an all-args constructor_ --
 Even if you cannot or don't want to model your entities as immutable values, there's still value in providing a constructor that takes all properties of the entity as arguments, including the mutable ones, as this allows the object mapping to skip the property population for optimal performance.
-* _Use factory methods instead of overloaded constructors to avoid ``@PersistenceConstructor``_ --
+* _Use factory methods instead of overloaded constructors to avoid ``@PersistenceCreator``_ --
 With an all-argument constructor needed for optimal performance, we usually want to expose more application use case specific constructors that omit things like auto-generated identifiers etc.
 It's an established pattern to rather use static factory methods to expose these variants of the all-args constructor.
 * _Make sure you adhere to the constraints that allow the generated instantiator and property accessor classes to be used_
@@ -251,14 +251,14 @@ data class Person(val id: String, val name: String)
 ====
 
 The class above compiles to a typical class with an explicit constructor.
-We can customize this class by adding another constructor and annotate it with `@PersistenceConstructor` to indicate a constructor preference:
+We can customize this class by adding another constructor and annotate it with `@PersistenceCreator` to indicate a constructor preference:
 
 ====
 [source,java]
 ----
 data class Person(var id: String, val name: String) {
 
-    @PersistenceConstructor
+    @PersistenceCreator
     constructor(id: String) : this(id, "unknown")
 }
 ----

src/test/java/org/springframework/data/neo4j/integration/movies/shared/Person.java

@@ -18,7 +18,7 @@
 import java.util.ArrayList;
 import java.util.List;
 
-import org.springframework.data.annotation.PersistenceConstructor;
+import org.springframework.data.annotation.PersistenceCreator;
 import org.springframework.data.neo4j.core.schema.GeneratedValue;
 import org.springframework.data.neo4j.core.schema.Id;
 import org.springframework.data.neo4j.core.schema.Node;
@@ -44,7 +44,7 @@ public final class Person {
 	@Relationship("ACTED_IN")
 	private List<Movie> actedIn = new ArrayList<>();
 
-	@PersistenceConstructor
+	@PersistenceCreator
 	private Person(Long id, String name, Integer born) {
 		this.id = id;
 		this.born = born;

src/test/java/org/springframework/data/neo4j/integration/shared/common/ImmutableAuditableThing.java

@@ -26,7 +26,7 @@
 import org.springframework.data.annotation.Id;
 import org.springframework.data.annotation.LastModifiedBy;
 import org.springframework.data.annotation.LastModifiedDate;
-import org.springframework.data.annotation.PersistenceConstructor;
+import org.springframework.data.annotation.PersistenceCreator;
 import org.springframework.data.annotation.Persistent;
 import org.springframework.data.neo4j.core.schema.GeneratedValue;
 
@@ -35,7 +35,7 @@
  */
 @Value
 @With
-@AllArgsConstructor(onConstructor = @__(@PersistenceConstructor))
+@AllArgsConstructor(onConstructor = @__(@PersistenceCreator))
 @Persistent
 public class ImmutableAuditableThing implements AuditableThing {
 

src/test/java/org/springframework/data/neo4j/integration/shared/common/ImmutableAuditableThingWithGeneratedId.java

@@ -26,7 +26,7 @@
 import org.springframework.data.annotation.Id;
 import org.springframework.data.annotation.LastModifiedBy;
 import org.springframework.data.annotation.LastModifiedDate;
-import org.springframework.data.annotation.PersistenceConstructor;
+import org.springframework.data.annotation.PersistenceCreator;
 import org.springframework.data.annotation.Persistent;
 import org.springframework.data.neo4j.core.schema.GeneratedValue;
 import org.springframework.data.neo4j.core.support.UUIDStringGenerator;
@@ -36,7 +36,7 @@
  */
 @Value
 @With
-@AllArgsConstructor(onConstructor = @__(@PersistenceConstructor))
+@AllArgsConstructor(onConstructor = @__(@PersistenceCreator))
 @Persistent
 public class ImmutableAuditableThingWithGeneratedId implements AuditableThing {
 

src/test/java/org/springframework/data/neo4j/integration/shared/common/ImmutablePersonWithAssignedId.java

@@ -15,7 +15,7 @@
  */
 package org.springframework.data.neo4j.integration.shared.common;
 
-import org.springframework.data.annotation.PersistenceConstructor;
+import org.springframework.data.annotation.PersistenceCreator;
 import org.springframework.data.neo4j.core.schema.Id;
 import org.springframework.data.neo4j.core.schema.Node;
 import org.springframework.data.neo4j.core.schema.Relationship;
@@ -57,7 +57,7 @@ public class ImmutablePersonWithAssignedId {
 	public final Map<String, ImmutablePersonWithAssignedIdRelationshipProperties> relationshipPropertiesDynamic;
 	public final Map<String, List<ImmutableSecondPersonWithAssignedIdRelationshipProperties>> relationshipPropertiesDynamicCollection;
 
-	@PersistenceConstructor
+	@PersistenceCreator
 	public ImmutablePersonWithAssignedId(
 		Long id,
 		List<ImmutablePersonWithAssignedId> wasOnboardedBy,

src/test/java/org/springframework/data/neo4j/integration/shared/common/ImmutablePersonWithExternallyGeneratedId.java

@@ -15,7 +15,7 @@
  */
 package org.springframework.data.neo4j.integration.shared.common;
 
-import org.springframework.data.annotation.PersistenceConstructor;
+import org.springframework.data.annotation.PersistenceCreator;
 import org.springframework.data.neo4j.core.schema.GeneratedValue;
 import org.springframework.data.neo4j.core.schema.Id;
 import org.springframework.data.neo4j.core.schema.Node;
@@ -57,7 +57,7 @@ public class ImmutablePersonWithExternallyGeneratedId {
 	public final Map<String, ImmutablePersonWithExternallyGeneratedIdRelationshipProperties> relationshipPropertiesDynamic;
 	public final Map<String, List<ImmutableSecondPersonWithExternallyGeneratedIdRelationshipProperties>> relationshipPropertiesDynamicCollection;
 
-	@PersistenceConstructor
+	@PersistenceCreator
 	public ImmutablePersonWithExternallyGeneratedId(
 		UUID id,
 		List<ImmutablePersonWithExternallyGeneratedId> wasOnboardedBy,

src/test/java/org/springframework/data/neo4j/integration/shared/common/ImmutablePersonWithGeneratedId.java

@@ -15,7 +15,7 @@
  */
 package org.springframework.data.neo4j.integration.shared.common;
 
-import org.springframework.data.annotation.PersistenceConstructor;
+import org.springframework.data.annotation.PersistenceCreator;
 import org.springframework.data.neo4j.core.schema.GeneratedValue;
 import org.springframework.data.neo4j.core.schema.Id;
 import org.springframework.data.neo4j.core.schema.Node;
@@ -55,7 +55,7 @@ public class ImmutablePersonWithGeneratedId {
 	public final Map<String, ImmutablePersonWithGeneratedIdRelationshipProperties> relationshipPropertiesDynamic;
 	public final Map<String, List<ImmutableSecondPersonWithGeneratedIdRelationshipProperties>> relationshipPropertiesDynamicCollection;
 
-	@PersistenceConstructor
+	@PersistenceCreator
 	public ImmutablePersonWithGeneratedId(
 		Long id,
 		List<ImmutablePersonWithGeneratedId> wasOnboardedBy,

src/test/java/org/springframework/data/neo4j/integration/shared/common/ImmutablePet.java

@@ -15,7 +15,7 @@
  */
 package org.springframework.data.neo4j.integration.shared.common;
 
-import org.springframework.data.annotation.PersistenceConstructor;
+import org.springframework.data.annotation.PersistenceCreator;
 import org.springframework.data.neo4j.core.schema.GeneratedValue;
 import org.springframework.data.neo4j.core.schema.Id;
 import org.springframework.data.neo4j.core.schema.Node;
@@ -38,7 +38,7 @@ public class ImmutablePet {
 	@Relationship("Has")
 	public final Set<ImmutablePet> friends;
 
-	@PersistenceConstructor
+	@PersistenceCreator
 	public ImmutablePet(Long id, String name) {
 		this.id = id;
 		this.name = name;

src/test/java/org/springframework/data/neo4j/integration/shared/common/ImmutableSecondPersonWithAssignedId.java

@@ -15,7 +15,7 @@
  */
 package org.springframework.data.neo4j.integration.shared.common;
 
-import org.springframework.data.annotation.PersistenceConstructor;
+import org.springframework.data.annotation.PersistenceCreator;
 import org.springframework.data.neo4j.core.schema.Id;
 import org.springframework.data.neo4j.core.schema.Node;
 import org.springframework.data.neo4j.core.schema.Relationship;
@@ -55,7 +55,7 @@ public class ImmutableSecondPersonWithAssignedId {
 	public final Map<String, ImmutablePersonWithAssignedIdRelationshipProperties> relationshipPropertiesDynamic;
 	public final Map<String, List<ImmutableSecondPersonWithAssignedIdRelationshipProperties>> relationshipPropertiesDynamicCollection;
 
-	@PersistenceConstructor
+	@PersistenceCreator
 	public ImmutableSecondPersonWithAssignedId(
 			Long id,
 			List<ImmutableSecondPersonWithAssignedId> wasOnboardedBy,

src/test/java/org/springframework/data/neo4j/integration/shared/common/ImmutableSecondPersonWithExternallyGeneratedId.java

@@ -15,7 +15,7 @@
  */
 package org.springframework.data.neo4j.integration.shared.common;
 
-import org.springframework.data.annotation.PersistenceConstructor;
+import org.springframework.data.annotation.PersistenceCreator;
 import org.springframework.data.neo4j.core.schema.GeneratedValue;
 import org.springframework.data.neo4j.core.schema.Id;
 import org.springframework.data.neo4j.core.schema.Node;
@@ -57,7 +57,7 @@ public class ImmutableSecondPersonWithExternallyGeneratedId {
 	public final Map<String, ImmutablePersonWithExternallyGeneratedIdRelationshipProperties> relationshipPropertiesDynamic;
 	public final Map<String, List<ImmutableSecondPersonWithExternallyGeneratedIdRelationshipProperties>> relationshipPropertiesDynamicCollection;
 
-	@PersistenceConstructor
+	@PersistenceCreator
 	public ImmutableSecondPersonWithExternallyGeneratedId(
 		UUID id,
 		List<ImmutableSecondPersonWithExternallyGeneratedId> wasOnboardedBy,

src/test/java/org/springframework/data/neo4j/integration/shared/common/ImmutableSecondPersonWithGeneratedId.java

@@ -15,7 +15,7 @@
  */
 package org.springframework.data.neo4j.integration.shared.common;
 
-import org.springframework.data.annotation.PersistenceConstructor;
+import org.springframework.data.annotation.PersistenceCreator;
 import org.springframework.data.neo4j.core.schema.GeneratedValue;
 import org.springframework.data.neo4j.core.schema.Id;
 import org.springframework.data.neo4j.core.schema.Node;
@@ -54,7 +54,7 @@ public class ImmutableSecondPersonWithGeneratedId {
 	public final Map<String, ImmutablePersonWithGeneratedIdRelationshipProperties> relationshipPropertiesDynamic;
 	public final Map<String, List<ImmutableSecondPersonWithGeneratedIdRelationshipProperties>> relationshipPropertiesDynamicCollection;
 
-	@PersistenceConstructor
+	@PersistenceCreator
 	public ImmutableSecondPersonWithGeneratedId(
 		Long id,
 		List<ImmutableSecondPersonWithGeneratedId> wasOnboardedBy,

src/test/java/org/springframework/data/neo4j/integration/shared/common/PersonWithRelationshipWithProperties.java

@@ -18,7 +18,7 @@
 import java.util.List;
 import java.util.Set;
 
-import org.springframework.data.annotation.PersistenceConstructor;
+import org.springframework.data.annotation.PersistenceCreator;
 import org.springframework.data.neo4j.core.schema.GeneratedValue;
 import org.springframework.data.neo4j.core.schema.Id;
 import org.springframework.data.neo4j.core.schema.Node;
@@ -44,7 +44,7 @@ public class PersonWithRelationshipWithProperties {
 
 	@Relationship("OWNS") private List<ClubRelationship> clubs;
 
-	@PersistenceConstructor
+	@PersistenceCreator
 	public PersonWithRelationshipWithProperties(Long id, String name, List<LikesHobbyRelationship> hobbies, WorksInClubRelationship club) {
 		this.id = id;
 		this.name = name;

src/test/java/org/springframework/data/neo4j/integration/shared/common/Pet.java

@@ -22,7 +22,7 @@
 import java.util.List;
 import java.util.Set;
 
-import org.springframework.data.annotation.PersistenceConstructor;
+import org.springframework.data.annotation.PersistenceCreator;
 import org.springframework.data.neo4j.core.schema.GeneratedValue;
 import org.springframework.data.neo4j.core.schema.Id;
 import org.springframework.data.neo4j.core.schema.Node;
@@ -31,7 +31,7 @@
 /**
  * @author Gerrit Meier
  */
-@RequiredArgsConstructor(onConstructor = @__(@PersistenceConstructor))
+@RequiredArgsConstructor(onConstructor = @__(@PersistenceCreator))
 @Getter
 @EqualsAndHashCode(of = { "id", "name" })
 @Node