Add support for fluent QueryResultConverter
#4949
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit decouples queryable encryption from explicit encryption and introduces the Queryable annotation to represent different query types like range and equality. Additionally it removes value conversion from range encryption and fixes update mapping of range encrypted fields. Original Pull Request: #4885
Original Pull Request: #4885
Original Pull Request: #4885
Guard tests for encryption functionality. Original Pull Request: #4885
Closes: #4947 Signed-off-by: Jeff Yemin <[email protected]>
Remove quantization from VectorSearch docs. Closes: #4931 Signed-off-by: Alex Bevilacqua <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 21 out of 24 changed files in this pull request and generated no comments.
Files not reviewed (3)
- pom.xml: Language not supported
- spring-data-mongodb-distribution/pom.xml: Language not supported
- spring-data-mongodb/pom.xml: Language not supported
Comments suppressed due to low confidence (2)
spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/MongoTemplate.java:3010
- [nitpick] The unchecked cast used when comparing 'resultConverter' to QueryResultConverter.entity() could potentially lead to runtime issues. Consider refactoring this comparison to improve type safety, for example by using a more explicit identity check or redesigning the converter composition.
return resultConverter == QueryResultConverter.entity() ? (DocumentCallback<R>) readCallback : new QueryResultConverterCallback<T, R>(resultConverter, readCallback);
spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/ReactiveFindOperationSupport.java:101
- [nitpick] Resetting the result converter to QueryResultConverter.entity() in the 'as()' method may inadvertently discard any existing custom converter chain. Consider preserving or composing with the current converter to ensure intended behavior when mapping to a new return type.
return new ReactiveFindSupport<>(template, domainType, returnType, QueryResultConverter.entity(), collection, query);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now support configuring a
QueryResultConverterthat has access to the raw resultDocumentand the mapped result object that has been materialized fromMongoConverter:This is useful to either wrap, post-process results contextually or apply further transformations based on the result
Document. Changes apply for imperative and reactive find, geoNear and aggregations.TODO:
QueryResultConverter.entity()(returning the converted object) is a good naming fit for queries, but with projections or aggregations we might to name it differently