Skip to content

How to perform an Upsert on a bulk with Reactive Streams? #3994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apffa opened this issue Mar 15, 2022 · 6 comments
Closed

How to perform an Upsert on a bulk with Reactive Streams? #3994

apffa opened this issue Mar 15, 2022 · 6 comments
Labels
status: duplicate A duplicate of another issue

Comments

@apffa
Copy link

apffa commented Mar 15, 2022

As for what I've seen, the ReactiveMongoTemplate doesn't support a multi update when upserting. I wonder if there's any reason for this, or whether it will be possible to submit a simple PR to fix that.

@apffa
Copy link
Author

apffa commented Mar 15, 2022

I'd really like to get answers to this one. There's also a SO question in the subject. I think adding reactive support for bulkOps can be super useful. I'd like that to be added to the ReactiveMongoTemplate

@apffa
Copy link
Author

apffa commented Mar 15, 2022

@mp911de @christophstrobl

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 16, 2022
@almogtavor
Copy link

There's a non-Spring Data implementation specified here. I think there is no reason to not simplify this in Spring Data Mongo. Bulk operations should be supported in spring-data-mongo-reactive

@christophstrobl
Copy link
Member

seem to be a duplicate of #2821 - a PR is always welcome.

@christophstrobl christophstrobl added waiting for feedback and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 17, 2022
@almogtavor
Copy link

@christophstrobl Ok. Can you specify what path should the ReactiveBulkOperations interface be? I guess the implementation should be in a class named ReactiveBulkOperationsSupport. If you may, some guidelines for what needed to be implemented.

@christophstrobl christophstrobl added for: team-attention An issue we need to discuss as a team to make progress and removed waiting for feedback labels Mar 21, 2022
@mp911de mp911de added status: duplicate A duplicate of another issue and removed for: team-attention An issue we need to discuss as a team to make progress labels Apr 6, 2022
@mp911de
Copy link
Member

mp911de commented Apr 6, 2022

Both, the implementation and interface should reside in the core (org.springframework.data.mongodb.core) package. Closing this one as duplicate of #2821.

@mp911de mp911de closed this as completed Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

5 participants