Backwards incompatibilities on @Query [DATAMONGO-2545]

[spring-projects-issues]

Steve Jerman opened DATAMONGO-2545 and commented

I posted this to /. but I think its actually a bug:

https://stackoverflow.com/questions/61740106/moving-query-to-2-2-6
 
I am moving our code to Spring Data MongoDB 2.2.6 from 2.1.X and am having some issues with some repository queries (that have worked in the past).

One example:

 {{ @Query(
 " ?#{ hasRole('ROLE_ADMIN') ? {'_class': { '$eq' : 
 'region }} : { '$and' : { {'_class': { '$eq' : 'region' }}, {'$or': {{'users._id': 
 { '$oid' :principal.id}},{'usersFromHierarchy._id':{ '$oid' :principal.id}}} } } } } ")
 List<Region> findRegions();}}

Doesn't get evaluated since the evaluation seems to expect a valid BSON document at the start of the query string. It only evaluates parameters.

Another:

 `@Query("{ 'name' : ?#{ hasRole('ROLE_ADMIN') ? '?0' : '?1' `")
 Optional<TestObject> findByAuthName(String name, String name2);}}

Doesn't work ... it always selects the first parameter.

Looking at the code, seems like org.springframework.data.mongodb.util.json.ParameterBindingJsonReader is interpreting the ?#{..} as a parameter binding (line 369) and munging down to the first call param...

Is there any guidance on this? What are the restrictions?

 

---

Affects: 2.2.7 (Moore SR7)

Referenced from: pull request #864

Backported to: 3.0.1 (Neumann SR1), 2.2.8 (Moore SR8)

[spring-projects-issues]

Christoph Strobl commented

Good catch - thanks for reporting!

[spring-projects-issues]

Steve Jerman commented

Thanks for having a look. Happy to help if needed...