Remove punctuation in Exception messages.

Closes #4079.

Author: jxblum

spring-data-mongodb-benchmarks/src/main/java/org/springframework/data/mongodb/microbenchmark/AbstractMicrobenchmark.java

@@ -322,7 +322,7 @@ private void publishResults(Collection<RunResult> results) {
 		try {
 			ResultsWriter.forUri(uri).write(results);
 		} catch (Exception e) {
-			System.err.println(String.format("Cannot save benchmark results to '%s'. Error was %s.", uri, e));
+			System.err.println(String.format("Cannot save benchmark results to '%s'; Error was %s", uri, e));
 		}
 	}
 }

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/CodecRegistryProvider.java

@@ -62,7 +62,7 @@ default boolean hasCodecFor(Class<?> type) {
 	 */
 	default <T> Optional<Codec<T>> getCodecFor(Class<T> type) {
 
-		Assert.notNull(type, "Type must not be null!");
+		Assert.notNull(type, "Type must not be null");
 
 		try {
 			return Optional.of(getCodecRegistry().get(type));

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/MongoDatabaseUtils.java

@@ -102,7 +102,7 @@ public static MongoDatabase getDatabase(@Nullable String dbName, MongoDatabaseFa
 	private static MongoDatabase doGetMongoDatabase(@Nullable String dbName, MongoDatabaseFactory factory,
 			SessionSynchronization sessionSynchronization) {
 
-		Assert.notNull(factory, "Factory must not be null!");
+		Assert.notNull(factory, "Factory must not be null");
 
 		if (sessionSynchronization == SessionSynchronization.NEVER
 				|| !TransactionSynchronizationManager.isSynchronizationActive()) {

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/MongoResourceHolder.java

@@ -68,7 +68,7 @@ ClientSession getRequiredSession() {
 		ClientSession session = getSession();
 
 		if (session == null) {
-			throw new IllegalStateException("No session available!");
+			throw new IllegalStateException("No session available");
 		}
 
 		return session;

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/MongoTransactionManager.java

@@ -100,7 +100,7 @@ public MongoTransactionManager(MongoDatabaseFactory dbFactory) {
 	 */
 	public MongoTransactionManager(MongoDatabaseFactory dbFactory, @Nullable TransactionOptions options) {
 
-		Assert.notNull(dbFactory, "DbFactory must not be null!");
+		Assert.notNull(dbFactory, "DbFactory must not be null");
 
 		this.dbFactory = dbFactory;
 		this.options = options;
@@ -266,7 +266,7 @@ protected void doCleanupAfterCompletion(Object transaction) {
 	 */
 	public void setDbFactory(MongoDatabaseFactory dbFactory) {
 
-		Assert.notNull(dbFactory, "DbFactory must not be null!");
+		Assert.notNull(dbFactory, "DbFactory must not be null");
 		this.dbFactory = dbFactory;
 	}
 
@@ -315,7 +315,7 @@ private MongoResourceHolder newResourceHolder(TransactionDefinition definition,
 	private MongoDatabaseFactory getRequiredDbFactory() {
 
 		Assert.state(dbFactory != null,
-				"MongoTransactionManager operates upon a MongoDbFactory. Did you forget to provide one? It's required.");
+				"MongoTransactionManager operates upon a MongoDbFactory; Did you forget to provide one; It's required");
 
 		return dbFactory;
 	}
@@ -450,14 +450,14 @@ public ClientSession getSession() {
 
 		private MongoResourceHolder getRequiredResourceHolder() {
 
-			Assert.state(resourceHolder != null, "MongoResourceHolder is required but not present. o_O");
+			Assert.state(resourceHolder != null, "MongoResourceHolder is required but not present; o_O");
 			return resourceHolder;
 		}
 
 		private ClientSession getRequiredSession() {
 
 			ClientSession session = getSession();
-			Assert.state(session != null, "A Session is required but it turned out to be null.");
+			Assert.state(session != null, "A Session is required but it turned out to be null");
 			return session;
 		}
 

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/ReactiveMongoDatabaseUtils.java

@@ -136,7 +136,7 @@ public static Mono<MongoDatabase> getDatabase(String dbName, ReactiveMongoDataba
 	private static Mono<MongoDatabase> doGetMongoDatabase(@Nullable String dbName, ReactiveMongoDatabaseFactory factory,
 			SessionSynchronization sessionSynchronization) {
 
-		Assert.notNull(factory, "DatabaseFactory must not be null!");
+		Assert.notNull(factory, "DatabaseFactory must not be null");
 
 		if (sessionSynchronization == SessionSynchronization.NEVER) {
 			return getMongoDatabaseOrDefault(dbName, factory);

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/ReactiveMongoTransactionManager.java

@@ -104,7 +104,7 @@ public ReactiveMongoTransactionManager(ReactiveMongoDatabaseFactory databaseFact
 	public ReactiveMongoTransactionManager(ReactiveMongoDatabaseFactory databaseFactory,
 			@Nullable TransactionOptions options) {
 
-		Assert.notNull(databaseFactory, "DatabaseFactory must not be null!");
+		Assert.notNull(databaseFactory, "DatabaseFactory must not be null");
 
 		this.databaseFactory = databaseFactory;
 		this.options = options;
@@ -281,7 +281,7 @@ protected Mono<Void> doCleanupAfterCompletion(TransactionSynchronizationManager
 	 */
 	public void setDatabaseFactory(ReactiveMongoDatabaseFactory databaseFactory) {
 
-		Assert.notNull(databaseFactory, "DatabaseFactory must not be null!");
+		Assert.notNull(databaseFactory, "DatabaseFactory must not be null");
 		this.databaseFactory = databaseFactory;
 	}
 
@@ -323,7 +323,7 @@ private Mono<ReactiveMongoResourceHolder> newResourceHolder(TransactionDefinitio
 	private ReactiveMongoDatabaseFactory getRequiredDatabaseFactory() {
 
 		Assert.state(databaseFactory != null,
-				"ReactiveMongoTransactionManager operates upon a ReactiveMongoDatabaseFactory. Did you forget to provide one? It's required.");
+				"ReactiveMongoTransactionManager operates upon a ReactiveMongoDatabaseFactory; Did you forget to provide one; It's required");
 
 		return databaseFactory;
 	}
@@ -458,14 +458,14 @@ public ClientSession getSession() {
 
 		private ReactiveMongoResourceHolder getRequiredResourceHolder() {
 
-			Assert.state(resourceHolder != null, "ReactiveMongoResourceHolder is required but not present. o_O");
+			Assert.state(resourceHolder != null, "ReactiveMongoResourceHolder is required but not present; o_O");
 			return resourceHolder;
 		}
 
 		private ClientSession getRequiredSession() {
 
 			ClientSession session = getSession();
-			Assert.state(session != null, "A Session is required but it turned out to be null.");
+			Assert.state(session != null, "A Session is required but it turned out to be null");
 			return session;
 		}
 

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/SessionAwareMethodInterceptor.java

@@ -76,13 +76,13 @@ public <T> SessionAwareMethodInterceptor(ClientSession session, T target, Class<
 			Class<D> databaseType, ClientSessionOperator<D> databaseDecorator, Class<C> collectionType,
 			ClientSessionOperator<C> collectionDecorator) {
 
-		Assert.notNull(session, "ClientSession must not be null!");
-		Assert.notNull(target, "Target must not be null!");
-		Assert.notNull(sessionType, "SessionType must not be null!");
-		Assert.notNull(databaseType, "Database type must not be null!");
-		Assert.notNull(databaseDecorator, "Database ClientSessionOperator must not be null!");
-		Assert.notNull(collectionType, "Collection type must not be null!");
-		Assert.notNull(collectionDecorator, "Collection ClientSessionOperator must not be null!");
+		Assert.notNull(session, "ClientSession must not be null");
+		Assert.notNull(target, "Target must not be null");
+		Assert.notNull(sessionType, "SessionType must not be null");
+		Assert.notNull(databaseType, "Database type must not be null");
+		Assert.notNull(databaseDecorator, "Database ClientSessionOperator must not be null");
+		Assert.notNull(collectionType, "Collection type must not be null");
+		Assert.notNull(collectionDecorator, "Collection ClientSessionOperator must not be null");
 
 		this.session = session;
 		this.target = target;

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/config/MappingMongoConverterParser.java

@@ -255,7 +255,7 @@ private static void parseFieldNamingStrategy(Element element, ReaderContext cont
 				&& Boolean.parseBoolean(abbreviateFieldNames);
 
 		if (fieldNamingStrategyReferenced && abbreviationActivated) {
-			context.error("Field name abbreviation cannot be activated if a field-naming-strategy-ref is configured!",
+			context.error("Field name abbreviation cannot be activated if a field-naming-strategy-ref is configured",
 					element);
 			return;
 		}

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/config/MongoAuditingRegistrar.java

@@ -55,16 +55,16 @@ protected String getAuditingHandlerBeanName() {
 	@Override
 	public void registerBeanDefinitions(AnnotationMetadata annotationMetadata, BeanDefinitionRegistry registry) {
 
-		Assert.notNull(annotationMetadata, "AnnotationMetadata must not be null!");
-		Assert.notNull(registry, "BeanDefinitionRegistry must not be null!");
+		Assert.notNull(annotationMetadata, "AnnotationMetadata must not be null");
+		Assert.notNull(registry, "BeanDefinitionRegistry must not be null");
 
 		super.registerBeanDefinitions(annotationMetadata, registry);
 	}
 
 	@Override
 	protected BeanDefinitionBuilder getAuditHandlerBeanDefinitionBuilder(AuditingConfiguration configuration) {
 
-		Assert.notNull(configuration, "AuditingConfiguration must not be null!");
+		Assert.notNull(configuration, "AuditingConfiguration must not be null");
 
 		BeanDefinitionBuilder builder = BeanDefinitionBuilder.rootBeanDefinition(IsNewAwareAuditingHandler.class);
 
@@ -79,8 +79,8 @@ protected BeanDefinitionBuilder getAuditHandlerBeanDefinitionBuilder(AuditingCon
 	protected void registerAuditListenerBeanDefinition(BeanDefinition auditingHandlerDefinition,
 			BeanDefinitionRegistry registry) {
 
-		Assert.notNull(auditingHandlerDefinition, "BeanDefinition must not be null!");
-		Assert.notNull(registry, "BeanDefinitionRegistry must not be null!");
+		Assert.notNull(auditingHandlerDefinition, "BeanDefinition must not be null");
+		Assert.notNull(registry, "BeanDefinitionRegistry must not be null");
 
 		BeanDefinitionBuilder listenerBeanDefinitionBuilder = BeanDefinitionBuilder
 				.rootBeanDefinition(AuditingEntityCallback.class);

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/config/MongoCredentialPropertyEditor.java

@@ -117,7 +117,7 @@ public void setAsText(@Nullable String text) throws IllegalArgumentException {
 								userNameAndPassword[1].toCharArray()));
 					} else {
 						throw new IllegalArgumentException(
-								String.format("Cannot create MongoCredentials for unknown auth mechanism '%s'!", authMechanism));
+								String.format("Cannot create MongoCredentials for unknown auth mechanism '%s'", authMechanism));
 					}
 				}
 			} else {
@@ -194,7 +194,7 @@ private static Properties extractOptions(String text) {
 			String[] optionArgs = option.split("=");
 
 			if (optionArgs.length == 1) {
-				throw new IllegalArgumentException(String.format("Query parameter '%s' has no value!", optionArgs[0]));
+				throw new IllegalArgumentException(String.format("Query parameter '%s' has no value", optionArgs[0]));
 			}
 
 			properties.put(optionArgs[0], optionArgs[1]);
@@ -209,29 +209,29 @@ private static void verifyUsernameAndPasswordPresent(String[] source) {
 
 		if (source.length != 2) {
 			throw new IllegalArgumentException(
-					"Credentials need to specify username and password like in 'username:password@database'!");
+					"Credentials need to specify username and password like in 'username:password@database'");
 		}
 	}
 
 	private static void verifyDatabasePresent(String source) {
 
 		if (!StringUtils.hasText(source)) {
-			throw new IllegalArgumentException("Credentials need to specify database like in 'username:password@database'!");
+			throw new IllegalArgumentException("Credentials need to specify database like in 'username:password@database'");
 		}
 	}
 
 	private static void verifyUserNamePresent(String[] source) {
 
 		if (source.length == 0 || !StringUtils.hasText(source[0])) {
-			throw new IllegalArgumentException("Credentials need to specify username!");
+			throw new IllegalArgumentException("Credentials need to specify username");
 		}
 	}
 
 	private static String decodeParameter(String it) {
 		try {
 			return URLDecoder.decode(it, "UTF-8");
 		} catch (UnsupportedEncodingException e) {
-			throw new IllegalArgumentException("o_O UTF-8 not supported!", e);
+			throw new IllegalArgumentException("o_O UTF-8 not supported", e);
 		}
 	}
 }

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/config/MongoDbFactoryParser.java

@@ -163,7 +163,7 @@ private BeanDefinition getConnectionString(Element element, ParserContext parser
 
 		if (element.getAttributes().getLength() > allowedAttributesCount) {
 
-			parserContext.getReaderContext().error("Configure either MongoDB " + type + " or details individually!",
+			parserContext.getReaderContext().error("Configure either MongoDB " + type + " or details individually",
 					parserContext.extractSource(element));
 		}
 

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/config/ReactiveMongoAuditingRegistrar.java

@@ -51,7 +51,7 @@ protected String getAuditingHandlerBeanName() {
 	@Override
 	protected BeanDefinitionBuilder getAuditHandlerBeanDefinitionBuilder(AuditingConfiguration configuration) {
 
-		Assert.notNull(configuration, "AuditingConfiguration must not be null!");
+		Assert.notNull(configuration, "AuditingConfiguration must not be null");
 
 		BeanDefinitionBuilder builder = BeanDefinitionBuilder.rootBeanDefinition(ReactiveIsNewAwareAuditingHandler.class);
 
@@ -66,8 +66,8 @@ protected BeanDefinitionBuilder getAuditHandlerBeanDefinitionBuilder(AuditingCon
 	protected void registerAuditListenerBeanDefinition(BeanDefinition auditingHandlerDefinition,
 			BeanDefinitionRegistry registry) {
 
-		Assert.notNull(auditingHandlerDefinition, "BeanDefinition must not be null!");
-		Assert.notNull(registry, "BeanDefinitionRegistry must not be null!");
+		Assert.notNull(auditingHandlerDefinition, "BeanDefinition must not be null");
+		Assert.notNull(registry, "BeanDefinitionRegistry must not be null");
 
 		BeanDefinitionBuilder builder = BeanDefinitionBuilder.rootBeanDefinition(ReactiveAuditingEntityCallback.class);
 

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/config/ServerAddressPropertyEditor.java

@@ -43,7 +43,7 @@ public class ServerAddressPropertyEditor extends PropertyEditorSupport {
 	 * A port is a number without a leading 0 at the end of the address that is proceeded by just a single :.
 	 */
 	private static final String HOST_PORT_SPLIT_PATTERN = "(?<!:):(?=[123456789]\\d*$)";
-	private static final String COULD_NOT_PARSE_ADDRESS_MESSAGE = "Could not parse address %s '%s'. Check your replica set configuration!";
+	private static final String COULD_NOT_PARSE_ADDRESS_MESSAGE = "Could not parse address %s '%s'; Check your replica set configuration";
 	private static final Log LOG = LogFactory.getLog(ServerAddressPropertyEditor.class);
 
 	@Override
@@ -68,7 +68,7 @@ public void setAsText(@Nullable String replicaSetString) {
 
 		if (serverAddresses.isEmpty()) {
 			throw new IllegalArgumentException(
-					"Could not resolve at least one server of the replica set configuration! Validate your config!");
+					"Could not resolve at least one server of the replica set configuration; Validate your config");
 		}
 
 		setValue(serverAddresses.toArray(new ServerAddress[serverAddresses.size()]));
@@ -125,7 +125,7 @@ private ServerAddress parseServerAddress(String source) {
 	 */
 	private String[] extractHostAddressAndPort(String addressAndPortSource) {
 
-		Assert.notNull(addressAndPortSource, "Address and port source must not be null!");
+		Assert.notNull(addressAndPortSource, "Address and port source must not be null");
 
 		String[] hostAndPort = addressAndPortSource.split(HOST_PORT_SPLIT_PATTERN);
 		String hostAddress = hostAndPort[0];

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/ChangeStreamOptions.java

@@ -148,7 +148,7 @@ private static <T> Object doGetTimestamp(Object timestamp, Class<T> targetType)
 		}
 
 		throw new IllegalArgumentException(
-				"o_O that should actually not happen. The timestamp should be an Instant or a BsonTimestamp but was "
+				"o_O that should actually not happen; The timestamp should be an Instant or a BsonTimestamp but was "
 						+ ObjectUtils.nullSafeClassName(timestamp));
 	}
 
@@ -234,7 +234,7 @@ private ChangeStreamOptionsBuilder() {}
 		 */
 		public ChangeStreamOptionsBuilder collation(Collation collation) {
 
-			Assert.notNull(collation, "Collation must not be null nor empty!");
+			Assert.notNull(collation, "Collation must not be null nor empty");
 
 			this.collation = collation;
 			return this;
@@ -258,7 +258,7 @@ public ChangeStreamOptionsBuilder collation(Collation collation) {
 		 */
 		public ChangeStreamOptionsBuilder filter(Aggregation filter) {
 
-			Assert.notNull(filter, "Filter must not be null!");
+			Assert.notNull(filter, "Filter must not be null");
 
 			this.filter = filter;
 			return this;
@@ -287,7 +287,7 @@ public ChangeStreamOptionsBuilder filter(Document... filter) {
 		 */
 		public ChangeStreamOptionsBuilder resumeToken(BsonValue resumeToken) {
 
-			Assert.notNull(resumeToken, "ResumeToken must not be null!");
+			Assert.notNull(resumeToken, "ResumeToken must not be null");
 
 			this.resumeToken = resumeToken;
 
@@ -316,7 +316,7 @@ public ChangeStreamOptionsBuilder returnFullDocumentOnUpdate() {
 		 */
 		public ChangeStreamOptionsBuilder fullDocumentLookup(FullDocument lookup) {
 
-			Assert.notNull(lookup, "Lookup must not be null!");
+			Assert.notNull(lookup, "Lookup must not be null");
 
 			this.fullDocumentLookup = lookup;
 			return this;
@@ -330,7 +330,7 @@ public ChangeStreamOptionsBuilder fullDocumentLookup(FullDocument lookup) {
 		 */
 		public ChangeStreamOptionsBuilder resumeAt(Instant resumeTimestamp) {
 
-			Assert.notNull(resumeTimestamp, "ResumeTimestamp must not be null!");
+			Assert.notNull(resumeTimestamp, "ResumeTimestamp must not be null");
 
 			this.resumeTimestamp = resumeTimestamp;
 			return this;
@@ -345,7 +345,7 @@ public ChangeStreamOptionsBuilder resumeAt(Instant resumeTimestamp) {
 		 */
 		public ChangeStreamOptionsBuilder resumeAt(BsonTimestamp resumeTimestamp) {
 
-			Assert.notNull(resumeTimestamp, "ResumeTimestamp must not be null!");
+			Assert.notNull(resumeTimestamp, "ResumeTimestamp must not be null");
 
 			this.resumeTimestamp = resumeTimestamp;
 			return this;