DATAMONGO-2119 - Polishing.

Convert anonymous JSON callback class into a private static one. Use an expressive Pattern constant.

Original pull request: #621.

Author: mp911de

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/repository/query/StringBasedMongoQuery.java

@@ -228,36 +228,8 @@ public String parseAndCollectParameterBindingsFromQueryIntoBindings(String input
 			String transformedInput = transformQueryAndCollectExpressionParametersIntoBindings(input, bindings);
 			String parseableInput = makeParameterReferencesParseable(transformedInput);
 
-			collectParameterReferencesIntoBindings(bindings, JSON.parse(parseableInput, new JSONCallback() {
-
-				/*
-				 * (non-Javadoc)
-				 * @see com.mongodb.util.JSONCallback#objectDone()
-				 */
-				@Override
-				public Object objectDone() {
-					return exceptionSwallowingStackReducingObjectDone();
-				}
-
-				private Object exceptionSwallowingStackReducingObjectDone/*CauseWeJustNeedTheStructureNotTheActualValue*/() {
-
-					Object value;
-
-					try {
-						return super.objectDone();
-					} catch (PatternSyntaxException e) {
-						value = Pattern.compile("");
-					}
-
-					if (!isStackEmpty()) {
-						_put(curName(), value);
-					} else {
-						value = !BSON.hasDecodeHooks() ? value : BSON.applyDecodingHooks(value);
-						setRoot(value);
-					}
-					return value;
-				}
-			}));
+			collectParameterReferencesIntoBindings(bindings,
+					JSON.parse(parseableInput, new LenientPatternDecodingCallback()));
 
 			return transformedInput;
 		}
@@ -392,6 +364,43 @@ private static int getIndexOfExpressionParameter(String input, int position) {
 		}
 	}
 
+	/**
+	 * {@link JSONCallback} with lenient handling for {@link PatternSyntaxException} falling back to a placeholder
+	 * {@link Pattern} for intermediate query document rendering.
+	 */
+	private static class LenientPatternDecodingCallback extends JSONCallback {
+
+		private static final Pattern EMPTY_MARKER = Pattern.compile("__Spring_Data_MongoDB_Bind_Marker__");
+
+		/*
+		 * (non-Javadoc)
+		 * @see com.mongodb.util.JSONCallback#objectDone()
+		 */
+		@Override
+		public Object objectDone() {
+			return exceptionSwallowingStackReducingObjectDone();
+		}
+
+		private Object exceptionSwallowingStackReducingObjectDone/*CauseWeJustNeedTheStructureNotTheActualValue*/() {
+
+			Object value;
+
+			try {
+				return super.objectDone();
+			} catch (PatternSyntaxException e) {
+				value = EMPTY_MARKER;
+			}
+
+			if (!isStackEmpty()) {
+				_put(curName(), value);
+			} else {
+				value = !BSON.hasDecodeHooks() ? value : BSON.applyDecodingHooks(value);
+				setRoot(value);
+			}
+			return value;
+		}
+	}
+
 	/**
 	 * A generic parameter binding with name or position information.
 	 *