DATAMONGO-2545 - Polishing.

Fix warnings and typos.

Original pull request: #864.

Author: mp911de

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/util/json/ParameterBindingDocumentCodec.java

@@ -176,6 +176,7 @@ public Document decode(@Nullable String json, ParameterBindingContext bindingCon
 		return this.decode(reader, DecoderContext.builder().build());
 	}
 
+	@SuppressWarnings({ "rawtypes", "unchecked" })
 	@Override
 	public Document decode(final BsonReader reader, final DecoderContext decoderContext) {
 
@@ -203,12 +204,13 @@ public Document decode(final BsonReader reader, final DecoderContext decoderCont
 			try {
 
 				Object value = readValue(reader, decoderContext);
-				if (value instanceof Map) {
+				if (value instanceof Map<?, ?>) {
 					if (!((Map) value).isEmpty()) {
-						return new Document((Map) value);
+						return new Document((Map<String, Object>) value);
 					}
 				}
 			} catch (Exception ex) {
+				e.addSuppressed(ex);
 				throw e;
 			}
 		}

spring-data-mongodb/src/test/java/org/springframework/data/mongodb/util/json/ParameterBindingJsonReaderUnitTests.java

@@ -269,7 +269,7 @@ public void bindQuotedMulitParameterInArray() {
 	}
 
 	@Test // DATAMONGO-2545
-	void shouldABindArgumentsViaIndexInSpelExpressions() {
+	public void shouldABindArgumentsViaIndexInSpelExpressions() {
 
 		Object[] args = new Object[] { "yess", "nooo" };
 		StandardEvaluationContext evaluationContext = (StandardEvaluationContext) EvaluationContextProvider.DEFAULT
@@ -284,7 +284,7 @@ void shouldABindArgumentsViaIndexInSpelExpressions() {
 	}
 
 	@Test // DATAMONGO-2545
-	void shouldAllowMethodArgumentPlaceholdersInSpelExpressions/*becuase this worked before*/() {
+	public void shouldAllowMethodArgumentPlaceholdersInSpelExpressions/*becuase this worked before*/() {
 
 		Object[] args = new Object[] { "yess", "nooo" };
 		StandardEvaluationContext evaluationContext = (StandardEvaluationContext) EvaluationContextProvider.DEFAULT
@@ -299,7 +299,7 @@ void shouldABindArgumentsViaIndexInSpelExpressions() {
 	}
 
 	@Test // DATAMONGO-2545
-	void shouldAllowMethodArgumentPlaceholdersInQuotedSpelExpressions/*becuase this worked before*/() {
+	public void shouldAllowMethodArgumentPlaceholdersInQuotedSpelExpressions/*because this worked before*/() {
 
 		Object[] args = new Object[] { "yess", "nooo" };
 		StandardEvaluationContext evaluationContext = (StandardEvaluationContext) EvaluationContextProvider.DEFAULT
@@ -314,23 +314,23 @@ void shouldABindArgumentsViaIndexInSpelExpressions() {
 	}
 
 	@Test // DATAMONGO-2545
-	void evaluatesSpelExpressionDefiningEntireQuery() {
+	public void evaluatesSpelExpressionDefiningEntireQuery() {
 
 		Object[] args = new Object[] {};
 		StandardEvaluationContext evaluationContext = (StandardEvaluationContext) EvaluationContextProvider.DEFAULT
 				.getEvaluationContext(args);
 		evaluationContext.setRootObject(new DummySecurityObject(new DummyWithId("wonderwoman")));
 
 		String json = "?#{  T(" + this.getClass().getName()
-				+ ").isBatman() ? {'_class': { '$eq' : 'region' }} : { '$and' : { {'_class': { '$eq' : 'region' } }, {'user.superviser':  principal.id } } } }";
+				+ ").isBatman() ? {'_class': { '$eq' : 'region' }} : { '$and' : { {'_class': { '$eq' : 'region' } }, {'user.supervisor':  principal.id } } } }";
 
 		ParameterBindingJsonReader reader = new ParameterBindingJsonReader(json,
 				new ParameterBindingContext((index) -> args[index], new SpelExpressionParser(), evaluationContext));
 		Document target = new ParameterBindingDocumentCodec().decode(reader, DecoderContext.builder().build());
 
 		assertThat(target)
 				.isEqualTo(new Document("$and", Arrays.asList(new Document("_class", new Document("$eq", "region")),
-						new Document("user.superviser", "wonderwoman"))));
+						new Document("user.supervisor", "wonderwoman"))));
 	}
 
 	private static Document parse(String json, Object... args) {