Skip to content

Commit 49ef3fb

Browse files
christophstroblmp911de
authored andcommitted
Polishing.
Fix typo in class name and make sure MongoTestTemplate uses the configured simple types. See: #3659 Original pull request: #3661.
1 parent 0114150 commit 49ef3fb

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/QueryMapper.java

+1
Original file line numberDiff line numberDiff line change
@@ -1139,6 +1139,7 @@ private PersistentPropertyPath<MongoPersistentProperty> getPath(String pathExpre
11391139
return propertyPath;
11401140
}
11411141

1142+
@Nullable
11421143
private PersistentPropertyPath<MongoPersistentProperty> tryToResolvePersistentPropertyPath(PropertyPath path) {
11431144

11441145
try {

spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/convert/QueryMapperUnitTests.java

+7-6
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import java.util.Map;
2929
import java.util.Optional;
3030

31-
import lombok.Data;
3231
import org.bson.conversions.Bson;
3332
import org.bson.types.Code;
3433
import org.bson.types.ObjectId;
@@ -37,9 +36,11 @@
3736
import org.junit.jupiter.api.extension.ExtendWith;
3837
import org.mockito.Mock;
3938
import org.mockito.junit.jupiter.MockitoExtension;
39+
import org.mockito.junit.jupiter.MockitoSettings;
40+
import org.mockito.quality.Strictness;
41+
4042
import org.springframework.core.convert.converter.Converter;
4143
import org.springframework.data.annotation.Id;
42-
import org.springframework.data.annotation.Transient;
4344
import org.springframework.data.convert.WritingConverter;
4445
import org.springframework.data.domain.Sort;
4546
import org.springframework.data.domain.Sort.Direction;
@@ -56,7 +57,6 @@
5657
import org.springframework.data.mongodb.core.mapping.FieldType;
5758
import org.springframework.data.mongodb.core.mapping.MongoMappingContext;
5859
import org.springframework.data.mongodb.core.mapping.MongoPersistentEntity;
59-
import org.springframework.data.mongodb.core.mapping.MongoPersistentProperty;
6060
import org.springframework.data.mongodb.core.mapping.TextScore;
6161
import org.springframework.data.mongodb.core.query.BasicQuery;
6262
import org.springframework.data.mongodb.core.query.Criteria;
@@ -77,6 +77,7 @@
7777
* @author Mark Paluch
7878
*/
7979
@ExtendWith(MockitoExtension.class)
80+
@MockitoSettings(strictness = Strictness.LENIENT)
8081
public class QueryMapperUnitTests {
8182

8283
private QueryMapper mapper;
@@ -1267,18 +1268,18 @@ static class ClassWithGeoTypes {
12671268
@Field("geoJsonPointWithNameViaFieldAnnotation") GeoJsonPoint namedGeoJsonPoint;
12681269
}
12691270

1270-
static class SimpeEntityWithoutId {
1271+
static class SimpleEntityWithoutId {
12711272

12721273
String stringProperty;
12731274
Integer integerProperty;
12741275
}
12751276

12761277
static class EntityWithComplexValueTypeMap {
1277-
Map<Integer, SimpeEntityWithoutId> map;
1278+
Map<Integer, SimpleEntityWithoutId> map;
12781279
}
12791280

12801281
static class EntityWithComplexValueTypeList {
1281-
List<SimpeEntityWithoutId> list;
1282+
List<SimpleEntityWithoutId> list;
12821283
}
12831284

12841285
static class WithExplicitTargetTypes {

spring-data-mongodb/src/test/java/org/springframework/data/mongodb/test/util/MongoTestTemplateConfiguration.java

+3
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,9 @@ MongoMappingContext mappingContext() {
119119
mappingContext = new MongoMappingContext();
120120
mappingContext.setInitialEntitySet(mappingContextConfigurer.initialEntitySet());
121121
mappingContext.setAutoIndexCreation(mappingContextConfigurer.autocreateIndex);
122+
if(mongoConverterConfigurer.customConversions != null) {
123+
mappingContext.setSimpleTypeHolder(mongoConverterConfigurer.customConversions.getSimpleTypeHolder());
124+
}
122125
mappingContext.afterPropertiesSet();
123126
}
124127

0 commit comments

Comments
 (0)