Skip to content

Commit 28efb3a

Browse files
christophstroblmp911de
authored andcommitted
Polishing.
Fix typo in class name and make sure MongoTestTemplate uses the configured simple types. See: #3659 Original pull request: #3661.
1 parent 99eb849 commit 28efb3a

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/QueryMapper.java

+1
Original file line numberDiff line numberDiff line change
@@ -1222,6 +1222,7 @@ private PersistentPropertyPath<MongoPersistentProperty> getPath(String pathExpre
12221222
return propertyPath;
12231223
}
12241224

1225+
@Nullable
12251226
private PersistentPropertyPath<MongoPersistentProperty> tryToResolvePersistentPropertyPath(PropertyPath path) {
12261227

12271228
try {

spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/convert/QueryMapperUnitTests.java

+7-5
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import java.util.Map;
2929
import java.util.Optional;
3030

31-
import lombok.Data;
3231
import org.bson.conversions.Bson;
3332
import org.bson.types.Code;
3433
import org.bson.types.ObjectId;
@@ -37,6 +36,9 @@
3736
import org.junit.jupiter.api.extension.ExtendWith;
3837
import org.mockito.Mock;
3938
import org.mockito.junit.jupiter.MockitoExtension;
39+
import org.mockito.junit.jupiter.MockitoSettings;
40+
import org.mockito.quality.Strictness;
41+
4042
import org.springframework.core.convert.converter.Converter;
4143
import org.springframework.data.annotation.Id;
4244
import org.springframework.data.annotation.Transient;
@@ -55,7 +57,6 @@
5557
import org.springframework.data.mongodb.core.mapping.FieldType;
5658
import org.springframework.data.mongodb.core.mapping.MongoMappingContext;
5759
import org.springframework.data.mongodb.core.mapping.MongoPersistentEntity;
58-
import org.springframework.data.mongodb.core.mapping.MongoPersistentProperty;
5960
import org.springframework.data.mongodb.core.mapping.TextScore;
6061
import org.springframework.data.mongodb.core.mapping.Unwrapped;
6162
import org.springframework.data.mongodb.core.query.BasicQuery;
@@ -77,6 +78,7 @@
7778
* @author Mark Paluch
7879
*/
7980
@ExtendWith(MockitoExtension.class)
81+
@MockitoSettings(strictness = Strictness.LENIENT)
8082
public class QueryMapperUnitTests {
8183

8284
private QueryMapper mapper;
@@ -1439,18 +1441,18 @@ static class ClassWithGeoTypes {
14391441
@Field("geoJsonPointWithNameViaFieldAnnotation") GeoJsonPoint namedGeoJsonPoint;
14401442
}
14411443

1442-
static class SimpeEntityWithoutId {
1444+
static class SimpleEntityWithoutId {
14431445

14441446
String stringProperty;
14451447
Integer integerProperty;
14461448
}
14471449

14481450
static class EntityWithComplexValueTypeMap {
1449-
Map<Integer, SimpeEntityWithoutId> map;
1451+
Map<Integer, SimpleEntityWithoutId> map;
14501452
}
14511453

14521454
static class EntityWithComplexValueTypeList {
1453-
List<SimpeEntityWithoutId> list;
1455+
List<SimpleEntityWithoutId> list;
14541456
}
14551457

14561458
static class WithExplicitTargetTypes {

spring-data-mongodb/src/test/java/org/springframework/data/mongodb/test/util/MongoTestTemplateConfiguration.java

+3
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,9 @@ MongoMappingContext mappingContext() {
119119
mappingContext = new MongoMappingContext();
120120
mappingContext.setInitialEntitySet(mappingContextConfigurer.initialEntitySet());
121121
mappingContext.setAutoIndexCreation(mappingContextConfigurer.autocreateIndex);
122+
if(mongoConverterConfigurer.customConversions != null) {
123+
mappingContext.setSimpleTypeHolder(mongoConverterConfigurer.customConversions.getSimpleTypeHolder());
124+
}
122125
mappingContext.afterPropertiesSet();
123126
}
124127

0 commit comments

Comments
 (0)