Skip to content

Commit 0a7949d

Browse files
enhance test and add todo
1 parent 7a6f392 commit 0a7949d

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/convert/MongoCustomConversions.java

+1
Original file line numberDiff line numberDiff line change
@@ -312,6 +312,7 @@ public MongoConverterConfigurationAdapter useSpringDataJavaTimeCodecs() {
312312
return useNativeDriverJavaTimeCodecs(false);
313313
}
314314

315+
// TODO: might just be a flag like the time codec?
315316
public MongoConverterConfigurationAdapter numericFormat(String format) {
316317
this.numericFormat = format;
317318
return this;

spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/convert/MappingMongoConverterUnitTests.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -3395,14 +3395,13 @@ void usesConfiguredNumericFormat() {
33953395

33963396
BigDecimalContainer container = new BigDecimalContainer();
33973397
container.value = BigDecimal.valueOf(2.5d);
3398-
// container.map = Collections.singletonMap("foo", container.value);
3398+
container.map = Collections.singletonMap("foo", container.value);
33993399

34003400
org.bson.Document document = new org.bson.Document();
34013401
converter.write(container, document);
34023402

34033403
assertThat(document.get("value")).isInstanceOf(Decimal128.class);
3404-
// assertThat((String) document.get("value")).isEqualTo("2.5");
3405-
// assertThat(((org.bson.Document) document.get("map")).get("foo")).isInstanceOf(String.class);
3404+
assertThat(((org.bson.Document) document.get("map")).get("foo")).isInstanceOf(Decimal128.class);
34063405
}
34073406

34083407
org.bson.Document write(Object source) {

0 commit comments

Comments
 (0)