Skip to content

Align Spring Data JPA annotations with Spring Framework annotations #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue Aug 22, 2013 · 1 comment
Assignees
Labels
type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link

Xavier Dury opened DATAJPA-394 and commented

None of the configuration annotations (@Configuration, @ComponentScan, @EnableTransactionManagement, @EnableCaching, @EnableXXXX) in Spring is @Inherited. So, to align with those annotations in Spring, @EnableJpaRepositories should not be @Inherited


Affects: 1.3.4

1 votes, 2 watchers

@spring-projects-issues
Copy link
Author

Neale Upstone commented

I just discovered this issue while looking to see if anyone had hit the same problem as me with @EnableTransactionManagement not being @Inherited.

To me it's a WTF, and instinctively I expect annotations to be @Inherited.

Even if someone is extending an @Configuration specifically in order to override an annotation, I'd expect this to work, ah, except there's no way to disabled it, hence perhaps it is sane, but needs documenting as such.

@spring-projects-issues spring-projects-issues added the type: bug A general bug label Dec 30, 2020
@gregturn gregturn self-assigned this Jun 8, 2022
@gregturn gregturn added type: enhancement A general enhancement and removed type: bug A general bug labels Jun 8, 2022
@gregturn gregturn added this to the 3.0 M5 (2022.0.0) milestone Jun 8, 2022
@gregturn gregturn changed the title @EnableJpaRepositories should not be @Inherited [DATAJPA-394] Align Spring Data JPA annotations with Spring Framework annotations Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants