Code Clean-Up and Refactoring Suggestions in JpaMetamodel

[arefbehboudi]

I have been reviewing the code and noticed some areas in JpaMetamodel where small improvements can be made to enhance code readability and maintainability. Here are my suggestions:

1. These fields can be defined as final fields:

               private Lazy<Collection<Class<?>>> managedTypes;
	       private Lazy<Collection<Class<?>>> jpaEmbeddables;

2. In some code, lambda expressions can be replaced with method references, for example:

		this.managedTypes = Lazy.of(() -> metamodel.getManagedTypes().stream()
				.map(ManagedType::getJavaType) 
				.filter(it -> it != null)  // It can be repalced with lambda expressions
				.collect(StreamUtils.toUnmodifiableSet()));

		this.jpaEmbeddables = Lazy.of(() -> metamodel.getEmbeddables().stream()
				.map(ManagedType::getJavaType)
				.filter(it -> it != null)  // It can be repalced with lambda expressions
				.filter(it -> AnnotatedElementUtils.isAnnotated(it, Embeddable.class))
				.collect(StreamUtils.toUnmodifiableSet()));

		return metamodel.getEntities().stream()
				.filter(it -> entity.equals(it.getJavaType()))
				.findFirst()
				.flatMap(it -> getSingularIdAttribute(it)) // It can be repalced with lambda expressions
				.filter(it -> it.getJavaType().equals(attributeType))
				.map(it -> it.getName().equals(name))
				.orElse(false);

[christophstrobl]

Thank you @arefbehboudi for bringing this up. Do you want to submit a PR for this change?

[arefbehboudi]

Yes, I'd be happy to submit a PR for this change. I'll start working on it and will notify you once it's ready.

[arefbehboudi]

Hi @christophstrobl,
I created a pull request; I would appreciate it if you could take a look at it.

[christophstrobl]

thank you @arefbehboudi - it's on the list.