Skip to content

Shouldn't JpaRepository extend ListCrudRepository/ListPagingAndSortingRepository? #2688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ullenboom opened this issue Oct 26, 2022 · 1 comment
Assignees
Labels
type: enhancement A general enhancement

Comments

@ullenboom
Copy link

In Spring Data 3 JpaRepository does not extend the new interfaces ListCrudRepository/ListPagingAndSortingRepository but MongoRepository does. Was this forgotten?

Currently, it looks like this:

grafik

Both JpaRepository and MongoRepository use covariant return types and return List anyway.

JpaRepositoryImplementation and SimpleJpaRepository are also extending CrudRepository and PagingAndSortingRepository not List[CrudRepository|PagingAndSortingRepository].

I put this issue here in the Commons project because it's related to several projects ...

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 26, 2022
@schauder schauder transferred this issue from spring-projects/spring-data-commons Nov 2, 2022
@schauder schauder added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 2, 2022
@schauder
Copy link
Contributor

schauder commented Nov 2, 2022

Yes, this was an oversight. Thanks for bringing this up.

@schauder schauder added this to the 3.0 RC2 (2022.0.0) milestone Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants