Skip to content

Commit c6f7ca6

Browse files
committed
Remove unnecessary parameter.
Remove unnecessary boolean nativeQuery from checkHasNamedParameter of StringQueryUnitTests class.
1 parent dbd4e53 commit c6f7ca6

File tree

1 file changed

+28
-27
lines changed

1 file changed

+28
-27
lines changed

spring-data-jpa/src/test/java/org/springframework/data/jpa/repository/query/StringQueryUnitTests.java

+28-27
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
* @author Diego Krupitza
4343
* @author Mark Paluch
4444
* @author Aleksei Elin
45+
* @author Gunha Hwang
4546
*/
4647
class StringQueryUnitTests {
4748

@@ -735,32 +736,32 @@ private void checkAlias(String query, String expected, String description, boole
735736
@Test // DATAJPA-1200
736737
void testHasNamedParameter() {
737738

738-
checkHasNamedParameter("select something from x where id = :id", true, "named parameter", true);
739-
checkHasNamedParameter("in the :id middle", true, "middle", false);
740-
checkHasNamedParameter(":id start", true, "beginning", false);
741-
checkHasNamedParameter(":id", true, "alone", false);
742-
checkHasNamedParameter("select something from x where id = :id", true, "named parameter", true);
743-
checkHasNamedParameter(":UPPERCASE", true, "uppercase", false);
744-
checkHasNamedParameter(":lowercase", true, "lowercase", false);
745-
checkHasNamedParameter(":2something", true, "beginning digit", false);
746-
checkHasNamedParameter(":2", true, "only digit", false);
747-
checkHasNamedParameter(":.something", true, "dot", false);
748-
checkHasNamedParameter(":_something", true, "underscore", false);
749-
checkHasNamedParameter(":$something", true, "dollar", false);
750-
checkHasNamedParameter(":\uFE0F", true, "non basic latin emoji", false); //
751-
checkHasNamedParameter(":\u4E01", true, "chinese japanese korean", false);
752-
753-
checkHasNamedParameter("no bind variable", false, "no bind variable", false);
754-
checkHasNamedParameter(":\u2004whitespace", false, "non basic latin whitespace", false);
755-
checkHasNamedParameter("select something from x where id = ?1", false, "indexed parameter", true);
756-
checkHasNamedParameter("::", false, "double colon", false);
757-
checkHasNamedParameter(":", false, "end of query", false);
758-
checkHasNamedParameter(":\u0003", false, "non-printable", false);
759-
checkHasNamedParameter(":*", false, "basic latin emoji", false);
760-
checkHasNamedParameter("\\:", false, "escaped colon", false);
761-
checkHasNamedParameter("::id", false, "double colon with identifier", false);
762-
checkHasNamedParameter("\\:id", false, "escaped colon with identifier", false);
763-
checkHasNamedParameter("select something from x where id = #something", false, "hash", true);
739+
checkHasNamedParameter("select something from x where id = :id", true, "named parameter");
740+
checkHasNamedParameter("in the :id middle", true, "middle");
741+
checkHasNamedParameter(":id start", true, "beginning");
742+
checkHasNamedParameter(":id", true, "alone");
743+
checkHasNamedParameter("select something from x where id = :id", true, "named parameter");
744+
checkHasNamedParameter(":UPPERCASE", true, "uppercase");
745+
checkHasNamedParameter(":lowercase", true, "lowercase");
746+
checkHasNamedParameter(":2something", true, "beginning digit");
747+
checkHasNamedParameter(":2", true, "only digit");
748+
checkHasNamedParameter(":.something", true, "dot");
749+
checkHasNamedParameter(":_something", true, "underscore");
750+
checkHasNamedParameter(":$something", true, "dollar");
751+
checkHasNamedParameter(":\uFE0F", true, "non basic latin emoji"); //
752+
checkHasNamedParameter(":\u4E01", true, "chinese japanese korean");
753+
754+
checkHasNamedParameter("no bind variable", false, "no bind variable");
755+
checkHasNamedParameter(":\u2004whitespace", false, "non basic latin whitespace");
756+
checkHasNamedParameter("select something from x where id = ?1", false, "indexed parameter");
757+
checkHasNamedParameter("::", false, "double colon");
758+
checkHasNamedParameter(":", false, "end of query");
759+
checkHasNamedParameter(":\u0003", false, "non-printable");
760+
checkHasNamedParameter(":*", false, "basic latin emoji");
761+
checkHasNamedParameter("\\:", false, "escaped colon");
762+
checkHasNamedParameter("::id", false, "double colon with identifier");
763+
checkHasNamedParameter("\\:id", false, "escaped colon with identifier");
764+
checkHasNamedParameter("select something from x where id = #something", false, "hash");
764765
}
765766

766767
@Test // DATAJPA-1235
@@ -921,7 +922,7 @@ void checkNumberOfNamedParameters(String query, int expectedSize, String label,
921922
.hasSize(expectedSize);
922923
}
923924

924-
private void checkHasNamedParameter(String query, boolean expected, String label, boolean nativeQuery) {
925+
private void checkHasNamedParameter(String query, boolean expected, String label) {
925926

926927
List<ParameterBinding> bindings = new ArrayList<>();
927928
StringQuery.ParameterBindingParser.INSTANCE.parseParameterBindingsOfQueryIntoBindingsAndReturnCleanedQuery(query,

0 commit comments

Comments
 (0)