Skip to content

Commit 8c1ca08

Browse files
committed
DATAJPA-1652 - Polishing.
Streamlined assertion. Removed a superfluous `public`. Signed-off-by: Jens Schauder <[email protected]> Original pull request: #405.
1 parent 60241e7 commit 8c1ca08

File tree

1 file changed

+7
-13
lines changed

1 file changed

+7
-13
lines changed

src/test/java/org/springframework/data/jpa/repository/query/StringQueryUnitTests.java

+7-13
Original file line numberDiff line numberDiff line change
@@ -547,12 +547,9 @@ public void usingPipesWithNamedParameter() {
547547
String queryString = "SELECT u FROM User u WHERE u.lastname LIKE '%'||:name||'%'";
548548
StringQuery query = new StringQuery(queryString);
549549

550-
softly.assertThat(query.getQueryString()).isEqualTo(queryString);
551-
softly.assertThat(query.hasParameterBindings()).isTrue();
552-
softly.assertThat(query.getParameterBindings()).hasSize(1);
553-
softly.assertThat(query.getParameterBindings().get(0).getName()).isEqualTo("name");
554-
555-
softly.assertAll();
550+
assertThat(query.getParameterBindings()) //
551+
.extracting(ParameterBinding::getName) //
552+
.containsExactly("name");
556553
}
557554

558555
@Test // DATAJPA-1652
@@ -561,15 +558,12 @@ public void usingGreaterThanWithNamedParameter() {
561558
String queryString = "SELECT u FROM User u WHERE :age>u.age";
562559
StringQuery query = new StringQuery(queryString);
563560

564-
softly.assertThat(query.getQueryString()).isEqualTo(queryString);
565-
softly.assertThat(query.hasParameterBindings()).isTrue();
566-
softly.assertThat(query.getParameterBindings()).hasSize(1);
567-
softly.assertThat(query.getParameterBindings().get(0).getName()).isEqualTo("age");
568-
569-
softly.assertAll();
561+
assertThat(query.getParameterBindings()) //
562+
.extracting(ParameterBinding::getName) //
563+
.containsExactly("age");
570564
}
571565

572-
public void checkNumberOfNamedParameters(String query, int expectedSize, String label) {
566+
void checkNumberOfNamedParameters(String query, int expectedSize, String label) {
573567

574568
DeclaredQuery declaredQuery = DeclaredQuery.of(query);
575569

0 commit comments

Comments
 (0)