DATAJPA-1652: Using || (pipes) along with named parameters in custom queries raises an exception

Author: reta

src/main/java/org/springframework/data/jpa/repository/query/QueryUtils.java

@@ -90,7 +90,7 @@ public abstract class QueryUtils {
 	// Cc Control
 	// Cf Format
 	// P Punctuation
-	private static final String IDENTIFIER = "[._[\\P{Z}&&\\P{Cc}&&\\P{Cf}&&\\P{P}]]+";
+	private static final String IDENTIFIER = "[._[\\P{Z}&&\\P{Cc}&&\\P{Cf}&&[\\P{P}&&[^|]]]]+";
 	static final String COLON_NO_DOUBLE_COLON = "(?<![:\\\\]):";
 	static final String IDENTIFIER_GROUP = String.format("(%s)", IDENTIFIER);
 

src/test/java/org/springframework/data/jpa/repository/UserCustomRepositoryFinderTests.java

@@ -0,0 +1,79 @@
+/*
+ * Copyright 2008-2019 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.springframework.data.jpa.repository;
+
+import static org.hamcrest.Matchers.*;
+import static org.junit.Assert.*;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.data.domain.Page;
+import org.springframework.data.domain.PageRequest;
+import org.springframework.data.jpa.domain.sample.User;
+import org.springframework.data.jpa.repository.custom.UserCustomExtendedRepository;
+import org.springframework.data.repository.query.QueryLookupStrategy;
+import org.springframework.test.context.ContextConfiguration;
+import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
+import org.springframework.transaction.annotation.Transactional;
+
+/**
+ * Integration test for executing custom finders, thus testing various query lookup strategies.
+ *
+ * @see QueryLookupStrategy
+ * @author Andriy Redko
+ */
+@RunWith(SpringJUnit4ClassRunner.class)
+@ContextConfiguration(locations = "classpath:config/namespace-customfactory-context.xml")
+@Transactional
+public class UserCustomRepositoryFinderTests {
+
+	@Autowired UserCustomExtendedRepository userRepository;
+
+	User dave, carter, oliver;
+
+	@Before
+	public void setUp() {
+		dave = userRepository.save(new User("Dave", "Matthews", "[email protected]"));
+		carter = userRepository.save(new User("Carter", "Beauford", "[email protected]"));
+		oliver = userRepository.save(new User("Oliver August", "Matthews", "[email protected]"));
+	}
+
+	@After
+	public void clearUp() {
+		userRepository.deleteAll();
+	}
+
+	@Test
+	public void executesNamedQueryWithPipes() {
+		Page<User> page = userRepository.findByNamedQueryWithLike("eau", PageRequest.of(0, 10));
+		assertThat(page.getNumberOfElements(), is(1));
+		assertThat(page.getTotalElements(), is(1L));
+		assertThat(page.getTotalPages(), is(1));
+		assertThat(page.getContent(), hasItems(carter));
+	}
+	
+	@Test
+	public void executesNamedQueryWithConcat() {
+		Page<User> page = userRepository.findByNamedQueryWithLikeConcat("eau", PageRequest.of(0, 10));
+		assertThat(page.getNumberOfElements(), is(1));
+		assertThat(page.getTotalElements(), is(1L));
+		assertThat(page.getTotalPages(), is(1));
+		assertThat(page.getContent(), hasItems(carter));
+	}
+}

src/test/java/org/springframework/data/jpa/repository/custom/UserCustomExtendedRepository.java

@@ -18,7 +18,11 @@
 import java.util.List;
 import java.util.Optional;
 
+import org.springframework.data.domain.Page;
+import org.springframework.data.domain.Pageable;
 import org.springframework.data.jpa.domain.sample.User;
+import org.springframework.data.jpa.repository.Query;
+import org.springframework.data.repository.query.Param;
 import org.springframework.transaction.annotation.Transactional;
 
 /**
@@ -37,4 +41,10 @@ public interface UserCustomExtendedRepository extends CustomGenericRepository<Us
 
 	@Transactional(readOnly = false, timeout = 10)
 	Optional<User> findById(Integer id);
+	
+	@Query(value = "SELECT u FROM User u WHERE u.lastname LIKE '%'||:name||'%'")
+	Page<User> findByNamedQueryWithLike(@Param("name") String name, Pageable page);
+
+	@Query(value = "SELECT u FROM User u WHERE u.lastname LIKE concat('%', :name, '%')")
+	Page<User> findByNamedQueryWithLikeConcat(@Param("name") String name, Pageable page);
 }