Recognize RIGHT, LEFT, OUTER, INNER and FULL as HQL reserved words.

RIGHT, LEFT, OUTER, INNER, and FULL are HQL tokens. This means they also need to be recognized as potential reserved words and thus possibly identifiers. This can show up if someone, for example, uses "right" as the name of a relationship in a JPA entity.

Resolves #2864.

Author: gregturn

spring-data-jpa/src/main/antlr4/org/springframework/data/jpa/repository/query/Hql.g4

@@ -700,7 +700,7 @@ reservedWord
 	| FOR
 	| FORMAT
 	| FROM
-//	| FULL
+	| FULL
 	| FUNCTION
 	| GROUP
 	| GROUPS
@@ -712,7 +712,7 @@ reservedWord
 	| IN
 	| INDEX
 	| INDICES
-//	| INNER
+	| INNER
 	| INSERT
 	| INSTANT
 	| INTERSECT
@@ -722,7 +722,7 @@ reservedWord
 	| KEY
 	| LAST
 	| LEADING
-//	| LEFT
+	| LEFT
 	| LIKE
 	| LIMIT
 	| LIST
@@ -760,7 +760,7 @@ reservedWord
 	| OR
 	| ORDER
 	| OTHERS
-//	| OUTER
+	| OUTER
 	| OVER
 	| OVERFLOW
 	| OVERLAY
@@ -773,7 +773,7 @@ reservedWord
 	| QUARTER
 	| RANGE
 	| RESPECT
-//	| RIGHT
+	| RIGHT
 	| ROLLUP
 	| ROW
 	| ROWS

spring-data-jpa/src/test/java/org/springframework/data/jpa/repository/query/HqlQueryTransformerTests.java

@@ -808,6 +808,121 @@ void countQueryShouldWorkEvenWithoutExplicitAlias() {
 				"select count(b) FROM BookError b WHERE portal = :portal");
 	}
 
+	@Test // GH-2864
+	void usingRightAsARelationshipNameShouldWork() {
+
+		HqlQueryParser.parseQuery("""
+				select u
+				from UserAccountEntity u
+				join fetch u.lossInspectorLimitConfiguration lil
+				join fetch u.companyTeam ct
+				where exists (
+					select iu
+					from UserAccountEntity  iu
+					join iu.roles u2r
+					join u2r.role r
+					join r.rights r2r
+					join r2r.right rt
+					where
+						rt.code = :rightCode
+						and iu = u
+				)
+				and ct.id = :teamId
+				""");
+	}
+
+	@Test // GH-2864
+	void usingLeftAsARelationshipNameShouldWork() {
+
+		HqlQueryParser.parseQuery("""
+				select u
+				from UserAccountEntity u
+				join fetch u.lossInspectorLimitConfiguration lil
+				join fetch u.companyTeam ct
+				where exists (
+					select iu
+					from UserAccountEntity  iu
+					join iu.roles u2r
+					join u2r.role r
+					join r.rights r2r
+					join r2r.left lt
+					where
+						lt.code = :rightCode
+						and iu = u
+				)
+				and ct.id = :teamId
+				""");
+	}
+
+	@Test // GH-2864
+	void usingOuterAsARelationshipNameShouldWork() {
+
+		HqlQueryParser.parseQuery("""
+				select u
+				from UserAccountEntity u
+				join fetch u.lossInspectorLimitConfiguration lil
+				join fetch u.companyTeam ct
+				where exists (
+					select iu
+					from UserAccountEntity  iu
+					join iu.roles u2r
+					join u2r.role r
+					join r.rights r2r
+					join r2r.outer ou
+					where
+						ou.code = :rightCode
+						and iu = u
+				)
+				and ct.id = :teamId
+				""");
+	}
+
+	@Test // GH-2864
+	void usingFullAsARelationshipNameShouldWork() {
+
+		HqlQueryParser.parseQuery("""
+				select u
+				from UserAccountEntity u
+				join fetch u.lossInspectorLimitConfiguration lil
+				join fetch u.companyTeam ct
+				where exists (
+					select iu
+					from UserAccountEntity  iu
+					join iu.roles u2r
+					join u2r.role r
+					join r.rights r2r
+					join r2r.full fu
+					where
+						fu.code = :rightCode
+						and iu = u
+				)
+				and ct.id = :teamId
+				""");
+	}
+
+	@Test // GH-2864
+	void usingInnerAsARelationshipNameShouldWork() {
+
+		HqlQueryParser.parseQuery("""
+				select u
+				from UserAccountEntity u
+				join fetch u.lossInspectorLimitConfiguration lil
+				join fetch u.companyTeam ct
+				where exists (
+					select iu
+					from UserAccountEntity  iu
+					join iu.roles u2r
+					join u2r.role r
+					join r.rights r2r
+					join r2r.inner in
+					where
+						in.code = :rightCode
+						and iu = u
+				)
+				and ct.id = :teamId
+				""");
+	}
+
 	private void assertCountQuery(String originalQuery, String countQuery) {
 		assertThat(createCountQueryFor(originalQuery)).isEqualTo(countQuery);
 	}