Skip to content

Commit 45863dc

Browse files
committed
DATAJPA-1827 - Polishing.
Fixing tests. Original pull request: #438.
1 parent 27bb58c commit 45863dc

File tree

4 files changed

+15
-1
lines changed

4 files changed

+15
-1
lines changed

src/test/java/org/springframework/data/jpa/repository/query/JpaQueryExecutionUnitTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ public void rejectsNullBinder() throws Exception {
9090
}
9191

9292
@Test // DATAJPA-1827
93-
void supportsModifyingResultsUsingWrappers() throws Exception {
93+
public void supportsModifyingResultsUsingWrappers() throws Exception {
9494

9595
Method method = VavrRepository.class.getMethod("updateUsingVavrMethod");
9696
DefaultRepositoryMetadata repositoryMetadata = new DefaultRepositoryMetadata(VavrRepository.class);

src/test/java/org/springframework/data/jpa/repository/query/JpaQueryMethodUnitTests.java

+6
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
import org.junit.Test;
3333
import org.junit.runner.RunWith;
3434
import org.mockito.Mock;
35+
import org.mockito.Mockito;
3536
import org.mockito.junit.MockitoJUnitRunner;
3637
import org.springframework.core.annotation.AliasFor;
3738
import org.springframework.data.domain.Page;
@@ -54,6 +55,8 @@
5455
import org.springframework.data.repository.core.support.DefaultRepositoryMetadata;
5556
import org.springframework.data.repository.query.Param;
5657
import org.springframework.data.repository.query.QueryMethod;
58+
import org.springframework.data.util.ClassTypeInformation;
59+
import org.springframework.data.util.TypeInformation;
5760

5861
/**
5962
* Unit test for {@link QueryMethod}.
@@ -94,6 +97,9 @@ public void setUp() throws Exception {
9497

9598
queryMethodWithCustomEntityFetchGraph = ValidRepository.class.getMethod("queryMethodWithCustomEntityFetchGraph",
9699
Integer.class);
100+
101+
when(metadata.getReturnType(Mockito.any(Method.class))).thenReturn((TypeInformation) ClassTypeInformation.from(Void.class));
102+
97103
}
98104

99105
@Test

src/test/java/org/springframework/data/jpa/repository/query/NamedQueryUnitTests.java

+5
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import org.junit.Test;
3030
import org.junit.runner.RunWith;
3131
import org.mockito.Mock;
32+
import org.mockito.Mockito;
3233
import org.mockito.junit.MockitoJUnitRunner;
3334
import org.springframework.data.domain.Page;
3435
import org.springframework.data.domain.Pageable;
@@ -37,13 +38,16 @@
3738
import org.springframework.data.projection.SpelAwareProxyProjectionFactory;
3839
import org.springframework.data.repository.core.RepositoryMetadata;
3940
import org.springframework.data.repository.query.QueryCreationException;
41+
import org.springframework.data.util.ClassTypeInformation;
42+
import org.springframework.data.util.TypeInformation;
4043

4144
/**
4245
* Unit tests for {@link NamedQuery}.
4346
*
4447
* @author Oliver Gierke
4548
* @author Thomas Darimont
4649
* @author Mark Paluch
50+
* @author Jens Schauder
4751
*/
4852
@RunWith(MockitoJUnitRunner.class)
4953
public class NamedQueryUnitTests {
@@ -65,6 +69,7 @@ public void setUp() throws SecurityException, NoSuchMethodException {
6569
method = SampleRepository.class.getMethod("foo", Pageable.class);
6670
when(metadata.getDomainType()).thenReturn((Class) String.class);
6771
when(metadata.getReturnedDomainClass(method)).thenReturn((Class) String.class);
72+
when(metadata.getReturnType(Mockito.any(Method.class))).thenReturn((TypeInformation) ClassTypeInformation.from(String.class));
6873

6974
when(em.getMetamodel()).thenReturn(metamodel);
7075
when(em.getEntityManagerFactory()).thenReturn(emf);

src/test/java/org/springframework/data/jpa/repository/query/SimpleJpaQueryUnitTests.java

+3
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@
5252
import org.springframework.data.repository.core.RepositoryMetadata;
5353
import org.springframework.data.repository.query.QueryMethodEvaluationContextProvider;
5454
import org.springframework.data.repository.query.RepositoryQuery;
55+
import org.springframework.data.util.ClassTypeInformation;
56+
import org.springframework.data.util.TypeInformation;
5557
import org.springframework.expression.spel.standard.SpelExpressionParser;
5658

5759
/**
@@ -96,6 +98,7 @@ public void setUp() throws SecurityException, NoSuchMethodException {
9698
when(emf.createEntityManager()).thenReturn(em);
9799
when(metadata.getDomainType()).thenReturn((Class) User.class);
98100
when(metadata.getReturnedDomainClass(Mockito.any(Method.class))).thenReturn((Class) User.class);
101+
when(metadata.getReturnType(Mockito.any(Method.class))).thenReturn((TypeInformation)ClassTypeInformation.from(User.class));
99102

100103
Method setUp = UserRepository.class.getMethod("findByLastname", String.class);
101104
method = new JpaQueryMethod(setUp, metadata, factory, extractor);

0 commit comments

Comments
 (0)