Properly handle Sort's that start with a join alias.

JOIN clauses can have aliases as well, despite not using an AS reserved word. The HQL query parser needs to handle this.

See #2960, #1066, #664
Original Pull Request: 2967

Author: gregturn

spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/HqlQueryTransformer.java

@@ -280,6 +280,30 @@ public List<JpaQueryParsingToken> visitJoin(HqlParser.JoinContext ctx) {
 		return tokens;
 	}
 
+	@Override
+	public List<JpaQueryParsingToken> visitJoinPath(HqlParser.JoinPathContext ctx) {
+
+		List<JpaQueryParsingToken> tokens = super.visitJoinPath(ctx);
+
+		if (ctx.variable() != null) {
+			transformerSupport.registerAlias(tokens.get(tokens.size() - 1).getToken());
+		}
+
+		return tokens;
+	}
+
+	@Override
+	public List<JpaQueryParsingToken> visitJoinSubquery(HqlParser.JoinSubqueryContext ctx) {
+
+		List<JpaQueryParsingToken> tokens = super.visitJoinSubquery(ctx);
+
+		if (ctx.variable() != null) {
+			transformerSupport.registerAlias(tokens.get(tokens.size() - 1).getToken());
+		}
+
+		return tokens;
+	}
+
 	@Override
 	public List<JpaQueryParsingToken> visitAlias(HqlParser.AliasContext ctx) {
 

spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/JpaQueryTransformerSupport.java

@@ -124,11 +124,16 @@ private boolean shouldPrefixWithAlias(Sort.Order order) {
 			return false;
 		}
 
-		// If the Sort references an alias
+		// If the Sort references an alias directly
 		if (projectionAliases.contains(order.getProperty())) {
 			return false;
 		}
 
+		// If the Sort property starts with an alias
+		if (projectionAliases.stream().anyMatch(alias -> order.getProperty().startsWith(alias))) {
+			return false;
+		}
+
 		return true;
 	}
 }

spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/JpqlQueryTransformer.java

@@ -219,6 +219,16 @@ public List<JpaQueryParsingToken> visitRange_variable_declaration(JpqlParser.Ran
 		return tokens;
 	}
 
+	@Override
+	public List<JpaQueryParsingToken> visitJoin(JpqlParser.JoinContext ctx) {
+
+		List<JpaQueryParsingToken> tokens = super.visitJoin(ctx);
+
+		transformerSupport.registerAlias(tokens.get(tokens.size() - 1).getToken());
+
+		return tokens;
+	}
+
 	@Override
 	public List<JpaQueryParsingToken> visitConstructor_expression(JpqlParser.Constructor_expressionContext ctx) {
 

spring-data-jpa/src/test/java/org/springframework/data/jpa/repository/query/HqlQueryTransformerTests.java

@@ -245,12 +245,12 @@ AND LOWER(COALESCE(vehicle.make, '')) LIKE :query)
 				""")).isEqualTo("o");
 	}
 
-	@Test // DATAJPA-252
+	@Test // DATAJPA-252, GH-664, GH-1066, GH-2960
 	void doesNotPrefixOrderReferenceIfOuterJoinAliasDetected() {
 
 		String query = "select p from Person p left join p.address address";
 		Sort sort = Sort.by("address.city");
-		assertThat(createQueryFor(query, sort)).endsWith("order by p.address.city asc");
+		assertThat(createQueryFor(query, sort)).endsWith("order by address.city asc");
 	}
 
 	@Test // DATAJPA-252
@@ -966,6 +966,28 @@ void shouldHandleAliasInsideCaseStatement() {
 						"order by newDateDue desc");
 	}
 
+	@Test // GH-664, GH-1066, GH-2960
+	void sortingRecognizesJoinAliases() {
+
+		String query = "select p from Customer c join c.productOrder p where p.delayed = true";
+
+		PageRequest page = PageRequest.of(0, 20, Sort.Direction.DESC, "lastName");
+		assertThat(createQueryFor(query, page.getSort())).isEqualToIgnoringWhitespace("""
+				select p from Customer c
+				join c.productOrder p
+				where p.delayed = true
+				order by c.lastName desc
+				""");
+
+		PageRequest page2 = PageRequest.of(0, 20, Sort.Direction.DESC, "p.lineItems");
+		assertThat(createQueryFor(query, page2.getSort())).isEqualToIgnoringWhitespace("""
+				select p from Customer c
+				join c.productOrder p
+				where p.delayed = true
+				order by p.lineItems desc
+				""");
+	}
+
 	private void assertCountQuery(String originalQuery, String countQuery) {
 		assertThat(createCountQueryFor(originalQuery)).isEqualTo(countQuery);
 	}

spring-data-jpa/src/test/java/org/springframework/data/jpa/repository/query/JpqlQueryTransformerTests.java

@@ -25,6 +25,7 @@
 import org.junit.jupiter.params.provider.Arguments;
 import org.junit.jupiter.params.provider.MethodSource;
 import org.springframework.dao.InvalidDataAccessApiUsageException;
+import org.springframework.data.domain.PageRequest;
 import org.springframework.data.domain.Sort;
 import org.springframework.data.jpa.domain.JpaSort;
 import org.springframework.lang.Nullable;
@@ -235,12 +236,12 @@ AND LOWER(COALESCE(vehicle.make, '')) LIKE :query)
 				""")).isEqualTo("o");
 	}
 
-	@Test // DATAJPA-252
+	@Test // DATAJPA-252, GH-664, GH-1066, GH-2960
 	void doesNotPrefixOrderReferenceIfOuterJoinAliasDetected() {
 
 		String query = "select p from Person p left join p.address address";
 		Sort sort = Sort.by("address.city");
-		assertThat(createQueryFor(query, sort)).endsWith("order by p.address.city asc");
+		assertThat(createQueryFor(query, sort)).endsWith("order by address.city asc");
 	}
 
 	@Test // DATAJPA-252
@@ -742,6 +743,28 @@ where exists (
 				""", relationshipName, joinAlias, joinAlias));
 	}
 
+	@Test // GH-664, GH-1066, GH-2960
+	void sortingRecognizesJoinAliases() {
+
+		String query = "select p from Customer c join c.productOrder p where p.delayed = true";
+
+		PageRequest page = PageRequest.of(0, 20, Sort.Direction.DESC, "lastName");
+		assertThat(createQueryFor(query, page.getSort())).isEqualToIgnoringWhitespace("""
+				select p from Customer c
+				join c.productOrder p
+				where p.delayed = true
+				order by c.lastName desc
+				""");
+
+		PageRequest page2 = PageRequest.of(0, 20, Sort.Direction.DESC, "p.lineItems");
+		assertThat(createQueryFor(query, page2.getSort())).isEqualToIgnoringWhitespace("""
+				select p from Customer c
+				join c.productOrder p
+				where p.delayed = true
+				order by p.lineItems desc
+				""");
+	}
+
 	static Stream<Arguments> queriesWithReservedWordsAsIdentifiers() {
 
 		return Stream.of( //