Skip to content

Commit 06212b5

Browse files
committed
Polishing.
Remove serialVersionUID for types that aren't serializable. See #3584
1 parent 55a3112 commit 06212b5

File tree

8 files changed

+11
-27
lines changed

8 files changed

+11
-27
lines changed

spring-data-jpa/src/main/java/org/springframework/data/jpa/domain/AbstractAuditable.java

+5-7
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,17 @@
1515
*/
1616
package org.springframework.data.jpa.domain;
1717

18+
import jakarta.persistence.ManyToOne;
19+
import jakarta.persistence.MappedSuperclass;
20+
import jakarta.persistence.Temporal;
21+
import jakarta.persistence.TemporalType;
22+
1823
import java.io.Serializable;
1924
import java.time.LocalDateTime;
2025
import java.time.ZoneId;
2126
import java.util.Date;
2227
import java.util.Optional;
2328

24-
import jakarta.persistence.ManyToOne;
25-
import jakarta.persistence.MappedSuperclass;
26-
import jakarta.persistence.Temporal;
27-
import jakarta.persistence.TemporalType;
28-
2929
import org.springframework.data.domain.Auditable;
3030
import org.springframework.lang.Nullable;
3131

@@ -42,8 +42,6 @@
4242
public abstract class AbstractAuditable<U, PK extends Serializable> extends AbstractPersistable<PK>
4343
implements Auditable<U, PK, LocalDateTime> {
4444

45-
private static final long serialVersionUID = 141481953116476081L;
46-
4745
@ManyToOne //
4846
private @Nullable U createdBy;
4947

spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/Account.java

-3
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
*/
1616
package org.springframework.data.jpa.domain.sample;
1717

18-
import java.io.Serial;
19-
2018
import jakarta.persistence.Entity;
2119

2220
import org.springframework.data.jpa.domain.AbstractPersistable;
@@ -27,5 +25,4 @@
2725
@Entity
2826
public class Account extends AbstractPersistable<Long> {
2927

30-
private static final long serialVersionUID = -5719129808165758887L;
3128
}

spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/AuditableRole.java

-2
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@
2727
@Entity
2828
public class AuditableRole extends AbstractAuditable<AuditableUser, Long> {
2929

30-
private static final long serialVersionUID = 5997359055260303863L;
31-
3230
private String name;
3331

3432
public void setName(String name) {

spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/AuditableUser.java

+3-5
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,14 @@
1515
*/
1616
package org.springframework.data.jpa.domain.sample;
1717

18-
import java.util.HashSet;
19-
import java.util.Set;
20-
2118
import jakarta.persistence.CascadeType;
2219
import jakarta.persistence.Entity;
2320
import jakarta.persistence.ManyToMany;
2421
import jakarta.persistence.NamedQuery;
2522

23+
import java.util.HashSet;
24+
import java.util.Set;
25+
2626
import org.springframework.data.jpa.domain.AbstractAuditable;
2727
import org.springframework.lang.Nullable;
2828

@@ -37,8 +37,6 @@
3737
@NamedQuery(name = "AuditableUser.findByFirstname", query = "SELECT u FROM AuditableUser u WHERE u.firstname = ?1")
3838
public class AuditableUser extends AbstractAuditable<AuditableUser, Integer> {
3939

40-
private static final long serialVersionUID = 7409344446795693011L;
41-
4240
private String firstname;
4341

4442
@ManyToMany(

spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/CustomAbstractPersistable.java

-1
Original file line numberDiff line numberDiff line change
@@ -27,5 +27,4 @@
2727
@Table(name = "customAbstractPersistable")
2828
public class CustomAbstractPersistable extends AbstractPersistable<Long> {
2929

30-
private static final long serialVersionUID = 1L;
3130
}

spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/Parent.java

+3-5
Original file line numberDiff line numberDiff line change
@@ -15,24 +15,22 @@
1515
*/
1616
package org.springframework.data.jpa.domain.sample;
1717

18-
import java.util.HashSet;
19-
import java.util.Set;
20-
2118
import jakarta.persistence.CascadeType;
2219
import jakarta.persistence.Entity;
2320
import jakarta.persistence.GeneratedValue;
2421
import jakarta.persistence.Id;
2522
import jakarta.persistence.ManyToMany;
2623

24+
import java.util.HashSet;
25+
import java.util.Set;
26+
2727
@Entity
2828
public class Parent {
2929

3030
@Id
3131
@GeneratedValue
3232
Long id;
3333

34-
static final long serialVersionUID = -89717120680485957L;
35-
3634
@ManyToMany(cascade = CascadeType.ALL)
3735
Set<Child> children = new HashSet<>();
3836

spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/PersistableWithIdClass.java

-2
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@
3030
@IdClass(PersistableWithIdClassPK.class)
3131
public class PersistableWithIdClass implements Persistable<PersistableWithIdClassPK> {
3232

33-
private static final long serialVersionUID = 1L;
34-
3533
@Id
3634
private
3735
Long first;

spring-data-jpa/src/test/java/org/springframework/data/jpa/domain/sample/PersistableWithSingleIdClass.java

-2
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@
2828
@IdClass(PersistableWithSingleIdClassPK.class)
2929
public class PersistableWithSingleIdClass {
3030

31-
private static final long serialVersionUID = 1L;
32-
3331
@Id private Long first;
3432

3533
protected PersistableWithSingleIdClass() {

0 commit comments

Comments
 (0)