Skip to content

Commit 1f4395c

Browse files
committed
Polishing.
Extract Docker and Artifactory credentials into properties file. See #569
1 parent 85f63ea commit 1f4395c

File tree

2 files changed

+19
-69
lines changed

2 files changed

+19
-69
lines changed

Jenkinsfile

+4-65
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@ pipeline {
3131
}
3232
options { timeout(time: 30, unit: 'MINUTES') }
3333
environment {
34-
ARTIFACTORY = credentials('02bd1690-b54f-4c9f-819d-a77cb7a9822c')
34+
ARTIFACTORY = credentials("${p['artifactory.credentials']}")
3535
}
3636
steps {
3737
script {
38-
docker.withRegistry('', 'hub.docker.com-springbuildmaster') {
38+
docker.withRegistry(p['docker.registry'], p['docker.credentials']) {
3939
docker.image(p['docker.java.main.image']).inside(p['docker.java.inside.basic']) {
4040
sh 'rm -Rf `find . -name "BACKUPDEFAULT*"`'
4141
sh 'rm -Rf `find . -name "ConfigDiskDir*"`'
@@ -50,67 +50,6 @@ pipeline {
5050
}
5151
}
5252

53-
stage("Test other configurations") {
54-
when {
55-
beforeAgent(true)
56-
allOf {
57-
branch(pattern: "main|(\\d\\.\\d\\.x)", comparator: "REGEXP")
58-
not { triggeredBy 'UpstreamCause' }
59-
}
60-
}
61-
parallel {
62-
stage("test: baseline (next)") {
63-
agent {
64-
label 'data'
65-
}
66-
options { timeout(time: 30, unit: 'MINUTES') }
67-
environment {
68-
ARTIFACTORY = credentials('02bd1690-b54f-4c9f-819d-a77cb7a9822c')
69-
}
70-
steps {
71-
script {
72-
docker.withRegistry('', 'hub.docker.com-springbuildmaster') {
73-
docker.image(p['docker.java.next.image']).inside(p['docker.java.inside.basic']) {
74-
sh 'rm -Rf `find . -name "BACKUPDEFAULT*"`'
75-
sh 'rm -Rf `find . -name "ConfigDiskDir*"`'
76-
sh 'rm -Rf `find . -name "locator*" | grep -v "src"`'
77-
sh 'rm -Rf `find . -name "newDB"`'
78-
sh 'rm -Rf `find . -name "server" | grep -v "src"`'
79-
sh 'rm -Rf `find . -name "*.log"`'
80-
sh 'MAVEN_OPTS="-Duser.name=jenkins -Duser.home=/tmp/jenkins-home -Duser.dir=$PWD -Djava.io.tmpdir=/tmp" ./mvnw -s settings.xml -Pjava11 clean dependency:list test -Dsort -U -B'
81-
}
82-
}
83-
}
84-
}
85-
}
86-
87-
stage("test: baseline (LTS)") {
88-
agent {
89-
label 'data'
90-
}
91-
options { timeout(time: 30, unit: 'MINUTES') }
92-
environment {
93-
ARTIFACTORY = credentials('02bd1690-b54f-4c9f-819d-a77cb7a9822c')
94-
}
95-
steps {
96-
script {
97-
docker.withRegistry('', 'hub.docker.com-springbuildmaster') {
98-
docker.image(p['docker.java.lts.image']).inside(p['docker.java.inside.basic']) {
99-
sh 'rm -Rf `find . -name "BACKUPDEFAULT*"`'
100-
sh 'rm -Rf `find . -name "ConfigDiskDir*"`'
101-
sh 'rm -Rf `find . -name "locator*" | grep -v "src"`'
102-
sh 'rm -Rf `find . -name "newDB"`'
103-
sh 'rm -Rf `find . -name "server" | grep -v "src"`'
104-
sh 'rm -Rf `find . -name "*.log"`'
105-
sh 'MAVEN_OPTS="-Duser.name=jenkins -Duser.home=/tmp/jenkins-home -Duser.dir=$PWD -Djava.io.tmpdir=/tmp" ./mvnw -s settings.xml -P java11,remote-java17 clean dependency:list test -Dsort -U -B'
106-
}
107-
}
108-
}
109-
}
110-
}
111-
}
112-
}
113-
11453
stage('Release to artifactory') {
11554
when {
11655
beforeAgent(true)
@@ -125,12 +64,12 @@ pipeline {
12564
options { timeout(time: 20, unit: 'MINUTES') }
12665

12766
environment {
128-
ARTIFACTORY = credentials('02bd1690-b54f-4c9f-819d-a77cb7a9822c')
67+
ARTIFACTORY = credentials("${p['artifactory.credentials']}")
12968
}
13069

13170
steps {
13271
script {
133-
docker.withRegistry('', 'hub.docker.com-springbuildmaster') {
72+
docker.withRegistry(p['docker.registry'], p['docker.credentials']) {
13473
docker.image(p['docker.java.main.image']).inside(p['docker.java.inside.basic']) {
13574
sh 'rm -Rf `find . -name "BACKUPDEFAULT*"`'
13675
sh 'rm -Rf `find . -name "ConfigDiskDir*"`'

ci/pipeline.properties

+15-4
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,24 @@
11
# Java versions
22
java.main.tag=17.0.2_8-jdk
3-
java.next.tag=17.0.2_8-jdk
4-
java.lts.tag=17.0.2_8-jdk
53

64
# Docker container images - standard
75
docker.java.main.image=eclipse-temurin:${java.main.tag}
8-
docker.java.next.image=eclipse-temurin:${java.next.tag}
9-
docker.java.lts.image=eclipse-temurin:${java.lts.tag}
6+
7+
# Supported versions of MongoDB
8+
docker.mongodb.4.4.version=4.4.4
9+
docker.mongodb.5.0.version=5.0.3
10+
11+
# Supported versions of Redis
12+
docker.redis.6.version=6.2.4
13+
14+
# Supported versions of Cassandra
15+
docker.cassandra.3.version=3.11.11
1016

1117
# Docker environment settings
1218
docker.java.inside.basic=-v $HOME:/tmp/jenkins-home
1319
docker.java.inside.docker=-u root -v /var/run/docker.sock:/var/run/docker.sock -v /usr/bin/docker:/usr/bin/docker -v $HOME:/tmp/jenkins-home
20+
21+
# Credentials
22+
docker.registry=
23+
docker.credentials=hub.docker.com-springbuildmaster
24+
artifactory.credentials=02bd1690-b54f-4c9f-819d-a77cb7a9822c

0 commit comments

Comments
 (0)