Skip to content

Use pattern matching instead of type casting. #2784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 3, 2023
Merged

Use pattern matching instead of type casting. #2784

merged 3 commits into from
Dec 3, 2023

Conversation

junghoon-vans
Copy link
Contributor

@junghoon-vans junghoon-vans commented Nov 30, 2023 •
edited
Loading

This PR is an additional application of #2742 that was missing from the previous work i did.

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our issue tracker. Add the issue number to the Closes #issue-number line below
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Closes #2785

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 30, 2023
@sothawo
Copy link
Collaborator

sothawo commented Nov 30, 2023

Did you read the Pull Request commit message template?

  • There is a ticket in the bug tracker for the project in our issue tracker. Add the issue number to the Closes #issue-number line below

When you check these points, please make sure that what they say is done.

@junghoon-vans junghoon-vans force-pushed the use-pattern-matching-instead-of-type-casting branch from c00d8b0 to 4f4c0ed Compare November 30, 2023 05:44
@junghoon-vans junghoon-vans force-pushed the use-pattern-matching-instead-of-type-casting branch from 4f4c0ed to 1278a60 Compare November 30, 2023 05:49
@junghoon-vans
Copy link
Contributor Author

junghoon-vans commented Nov 30, 2023 •
edited
Loading

@sothawo
Sorry about that. I missed registering an issue because it's the same thing I did before. #2741
I've now added it, so please check it out.

@sothawo sothawo merged commit 8613eb2 into spring-projects:main Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use pattern matching instead of type casting.
3 participants
@junghoon-vans @sothawo @spring-projects-issues