Adds support for dense_vector type #1708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
sothawo
requested changes
Feb 25, 2021
| @@ -191,6 +197,8 @@ private MappingParameters(InnerField field) { | |||
| || (maxShingleSize >= 2 && maxShingleSize <= 4), // | |||
| "maxShingleSize must be in inclusive range from 2 to 4 for field type search_as_you_type"); | |||
| positiveScoreImpact = field.positiveScoreImpact(); | |||
| dims = field.dims(); | |||
| Assert.isTrue(dims <= 2048, "The maximum number of dimensions that can be in a vector should not exceed 2048."); | |||
There was a problem hiding this comment.
Suggested change
| Assert.isTrue(dims <= 2048, "The maximum number of dimensions that can be in a vector should not exceed 2048."); | |
| Assert.isTrue(dims <= 2048, "The maximum number of dimensions that can be in a vector must not exceed 2048."); |
| @@ -153,6 +157,8 @@ private MappingParameters(Field field) { | |||
| || (maxShingleSize >= 2 && maxShingleSize <= 4), // | |||
| "maxShingleSize must be in inclusive range from 2 to 4 for field type search_as_you_type"); | |||
| positiveScoreImpact = field.positiveScoreImpact(); | |||
| dims = field.dims(); | |||
| Assert.isTrue(dims <= 2048, "The maximum number of dimensions that can be in a vector should not exceed 2048."); | |||
There was a problem hiding this comment.
Suggested change
| Assert.isTrue(dims <= 2048, "The maximum number of dimensions that can be in a vector should not exceed 2048."); | |
| Assert.isTrue(dims <= 2048, "The maximum number of dimensions that can be in a vector must not exceed 2048."); |
Comment on lines
334
to
341
| if (dims >= 1) { | ||
| builder.field(FIELD_PARAM_DIMS, dims); | ||
| } | ||
|
|
There was a problem hiding this comment.
According to https://www.elastic.co/guide/en/elasticsearch/reference/current/dense-vector.html dims is a required parameter. So it should be checked that if type == FieldType.DenseVector then the dims value must be greater or equal 1.
spring-projects-issues
added
the
status: waiting-for-triage
A dense_vector field stores dense vectors of float values. The maximum number of dimensions that can be in a vector should not exceed 2048. A dense_vector field is a single-valued field. Closes spring-projects#1700
morganlutz
force-pushed
the
dense-vector-support
branch
from
8484b00 to
d9cbaa5
Compare
|
@sothawo thanks so much for the quick review and help!! 🙏 |
sothawo
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all. We need to support a
dense_vectorfield for our elastic search implementation. I saw you have an open ticket to support this here #1700. I only includeddense_vectorsincesparse_vectoris deprecated and bothrank_featureandrank_featuresappear to already be supported.Closes #1700