Skip to content

The number of pages cannot be set by scrolling, and it is fixed to 500 pages, which is not conducive to data paging. #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lzzkey opened this issue Mar 17, 2023 · 1 comment
Labels
status: waiting-for-triage An issue we've not yet triaged

Comments

@lzzkey
Copy link

lzzkey commented Mar 17, 2023

image

The version is version 5.0.4. If the number of pages is set at the beginning of turning the page, the final code here will not take effect, because it is fixed to 500 records one page, but as a user, it needs a more flexible paging method, so I hope to modify this part of the code.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 17, 2023
@sothawo
Copy link
Collaborator

sothawo commented Mar 18, 2023

There is no version 5.0.4 of Spring Data Elasticsearch. The latest patch version for the 5.0 branch is 5.0.3, released on 03.03.2023.

The code you show in that image for setting the batch size is from before 7.12.2022 when this was changed by #2392.
But the reactive code doesn't now even use this scroll search any longer, since #2393 (12.12.2022) it uses the point-in-time API.

So you are looking at code that is not up to date.

@sothawo sothawo closed this as completed Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

No branches or pull requests

3 participants