Skip to content

TransportClientFactoryBean does not parse clusterNodes correctly [DATAES-470] #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue Jul 10, 2018 · 1 comment
Assignees
Labels
type: bug A general bug

Comments

@spring-projects-issues
Copy link

Andy Wilkinson opened DATAES-470 and commented

The referenced commit has introduced two regressions:

  1. StringUtils.split returns null if the input does not contain a comma. This means that a transport client that tries to use one node uses zero nodes instead.
  2. When the input does contain a comma, the parsing is incorrect as it checks for a : in the clusterName field rather than the clusterNode local variable. This leads to an assertion failure stating that the port is missing

Reference URL: d66b2a6#diff-5e09aa5ede62dc7823cb0cf515cd5eadR97

Backported to: 3.0.9 (Kay SR9)

@spring-projects-issues
Copy link
Author

Oliver Drotbohm commented

That's in place. I took the chance to extract the parsing logic into a value object to finally properly unit test it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants