Skip to content

Is org.elasticsearch:elasticsearch a necessary dependency? [DATAES-469] #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue Jun 27, 2018 · 3 comments
Labels
type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link

Petar Tahchiev opened DATAES-469 and commented

The project builds fine without org.elasticsearch:elasticsearch and it seems too much to force this 10MB jar in the users' classpath. I believe elasticsearch-cli should be enough, and if any user wants to run elasticsearch embedded they can add the other one manually


Referenced from: pull request #215, and commits e58c43f, 0fbb4ca

Backported to: 3.0.9 (Kay SR9)

@spring-projects-issues
Copy link
Author

Oliver Drotbohm commented

Sascha Woo, Mohsin Husen, Artur Konczak – Do you have any insight? Do you think we can remove that dependency or at least put it into test scope?

@spring-projects-issues
Copy link
Author

Sascha Woo commented

Do you think we can remove that dependency or at least put it into test scope?

Since it is not needed for the tests, we can safely remove the dependency

@spring-projects-issues
Copy link
Author

Sascha Woo commented

I just created a pull request for it. #215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant