Skip to content

Commit d4f23a5

Browse files
authored
DATAES-316 - Revert: NodeClientFactoryBean doesn't shutdown ES on destroy life-cycle.
Original PR: #335
1 parent 29f34b0 commit d4f23a5

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

src/main/java/org/springframework/data/elasticsearch/client/NodeClientFactoryBean.java

+6-3
Original file line numberDiff line numberDiff line change
@@ -152,9 +152,12 @@ public void destroy() throws Exception {
152152
try {
153153
// NodeClient.close() is a noop, no need to call it here
154154
logger.info("Closing elasticSearch node");
155-
if (node != null) {
156-
node.close();
157-
}
155+
// closing the Node causes tests to fail in the pipeline build and on some
156+
// "mvn test" runs, there seem still to be tests relying on a running instance that
157+
// is not properly set up.
158+
// if (node != null) {
159+
// node.close();
160+
// }
158161
} catch (final Exception e) {
159162
logger.error("Error closing ElasticSearch client: ", e);
160163
}

0 commit comments

Comments
 (0)