Skip to content

Commit ba76986

Browse files
committed
DATAES-619 - Migrate remaining tests to AssertJ.
1 parent c4bb59e commit ba76986

File tree

1 file changed

+18
-17
lines changed

1 file changed

+18
-17
lines changed

src/test/java/org/springframework/data/elasticsearch/client/util/RequestConvertersTest.java

+18-17
Original file line numberDiff line numberDiff line change
@@ -15,62 +15,62 @@
1515
*/
1616
package org.springframework.data.elasticsearch.client.util;
1717

18-
import static org.hamcrest.Matchers.*;
19-
import static org.junit.Assert.*;
20-
21-
import java.util.HashMap;
18+
import java.util.Collections;
2219

2320
import org.elasticsearch.action.delete.DeleteRequest;
2421
import org.elasticsearch.action.index.IndexRequest;
2522
import org.elasticsearch.client.Request;
2623
import org.junit.Test;
2724

25+
import static org.assertj.core.api.Assertions.*;
26+
2827
/**
2928
* Unit tests for {@link RequestConverters}.
3029
*
3130
* @author Roman Puchkovskiy
31+
* @author Mark Paluch
3232
*/
3333
public class RequestConvertersTest {
34+
3435
@Test // DATAES-652
3536
public void shouldNotAddIfSeqNoAndIfPrimaryTermToResultIfInputDoesNotcontainThemWhenConvertingIndexRequest() {
3637
IndexRequest request = createMinimalIndexRequest();
3738

3839
Request result = RequestConverters.index(request);
3940

40-
assertThat(result.getParameters(), not(hasKey("if_seq_no")));
41-
assertThat(result.getParameters(), not(hasKey("if_primary_term")));
41+
assertThat(result.getParameters())
42+
.doesNotContainKeys("if_seq_no", "if_primary_term");
4243
}
4344

4445
private IndexRequest createMinimalIndexRequest() {
46+
4547
IndexRequest request = new IndexRequest("the-index", "the-type", "id");
46-
request.source(new HashMap<String, String>() {
47-
{
48-
put("test", "test");
49-
}
50-
});
48+
request.source(Collections.singletonMap("test", "test"));
5149
return request;
5250
}
5351

5452
@Test // DATAES-652
5553
public void shouldAddIfSeqNoAndIfPrimaryTermToResultIfInputcontainsThemWhenConvertingIndexRequest() {
54+
5655
IndexRequest request = createMinimalIndexRequest();
5756
request.setIfSeqNo(3);
5857
request.setIfPrimaryTerm(4);
5958

6059
Request result = RequestConverters.index(request);
6160

62-
assertThat(result.getParameters(), hasEntry("if_seq_no", "3"));
63-
assertThat(result.getParameters(), hasEntry("if_primary_term", "4"));
61+
assertThat(result.getParameters()).containsEntry("if_seq_no", "3")
62+
.containsEntry("if_primary_term", "4");
6463
}
6564

6665
@Test // DATAES-652
6766
public void shouldNotAddIfSeqNoAndIfPrimaryTermToResultIfInputDoesNotcontainThemWhenConvertingDeleteRequest() {
67+
6868
DeleteRequest request = createMinimalDeleteRequest();
6969

7070
Request result = RequestConverters.delete(request);
7171

72-
assertThat(result.getParameters(), not(hasKey("if_seq_no")));
73-
assertThat(result.getParameters(), not(hasKey("if_primary_term")));
72+
assertThat(result.getParameters())
73+
.doesNotContainKeys("if_seq_no", "if_primary_term");
7474
}
7575

7676
private DeleteRequest createMinimalDeleteRequest() {
@@ -79,13 +79,14 @@ private DeleteRequest createMinimalDeleteRequest() {
7979

8080
@Test // DATAES-652
8181
public void shouldAddIfSeqNoAndIfPrimaryTermToResultIfInputcontainsThemWhenConvertingDeleteRequest() {
82+
8283
DeleteRequest request = createMinimalDeleteRequest();
8384
request.setIfSeqNo(3);
8485
request.setIfPrimaryTerm(4);
8586

8687
Request result = RequestConverters.delete(request);
8788

88-
assertThat(result.getParameters(), hasEntry("if_seq_no", "3"));
89-
assertThat(result.getParameters(), hasEntry("if_primary_term", "4"));
89+
assertThat(result.getParameters()).containsEntry("if_seq_no", "3");
90+
assertThat(result.getParameters()).containsEntry("if_primary_term", "4");
9091
}
9192
}

0 commit comments

Comments
 (0)