Don't try to write non-writeable properties.

Original Pull Request #2249
Closes #2230

(cherry picked from commit acf02a1)

# Conflicts:
#	src/main/java/org/springframework/data/elasticsearch/core/convert/MappingElasticsearchConverter.java

Author: sothawo

src/main/java/org/springframework/data/elasticsearch/core/AbstractElasticsearchTemplate.java

@@ -478,7 +478,7 @@ protected <T> T updateIndexedObject(T entity, IndexedObjectInformation indexedOb
 			ElasticsearchPersistentProperty idProperty = persistentEntity.getIdProperty();
 
 			// Only deal with text because ES generated Ids are strings!
-			if (indexedObjectInformation.getId() != null && idProperty != null
+			if (indexedObjectInformation.getId() != null && idProperty != null && idProperty.isWritable()
 					&& idProperty.getType().isAssignableFrom(String.class)) {
 				propertyAccessor.setProperty(idProperty, indexedObjectInformation.getId());
 			}

src/main/java/org/springframework/data/elasticsearch/core/AbstractReactiveElasticsearchTemplate.java

@@ -259,7 +259,7 @@ protected <T> T updateIndexedObject(T entity, IndexedObjectInformation indexedOb
 			ElasticsearchPersistentProperty idProperty = persistentEntity.getIdProperty();
 
 			// Only deal with text because ES generated Ids are strings!
-			if (indexedObjectInformation.getId() != null && idProperty != null
+			if (indexedObjectInformation.getId() != null && idProperty != null && idProperty.isWritable()
 					&& idProperty.getType().isAssignableFrom(String.class)) {
 				propertyAccessor.setProperty(idProperty, indexedObjectInformation.getId());
 			}

src/main/java/org/springframework/data/elasticsearch/core/convert/MappingElasticsearchConverter.java

@@ -45,7 +45,9 @@
 import org.springframework.dao.DataAccessException;
 import org.springframework.dao.InvalidDataAccessApiUsageException;
 import org.springframework.dao.OptimisticLockingFailureException;
+import org.springframework.data.annotation.AccessType;
 import org.springframework.data.annotation.Id;
+import org.springframework.data.annotation.ReadOnlyProperty;
 import org.springframework.data.annotation.Version;
 import org.springframework.data.domain.PageRequest;
 import org.springframework.data.domain.Pageable;
@@ -3718,6 +3720,21 @@ public int hashCode() {
 		}
 	}
 
+	@Test // #2230
+	@DisplayName("should work with readonly id")
+	void shouldWorkWithReadonlyId() {
+
+		ReadonlyIdEntity entity = new ReadonlyIdEntity();
+		entity.setPart1("foo");
+		entity.setPart2("bar");
+		operations.save(entity);
+
+		ReadonlyIdEntity readEntity = operations.get(entity.getId(), ReadonlyIdEntity.class);
+
+		assertThat(readEntity.getPart1()).isEqualTo(entity.getPart1());
+		assertThat(readEntity.getPart2()).isEqualTo(entity.getPart2());
+	}
+
 	@Document(indexName = "#{@indexNameProvider.indexName()}")
 	private static class SampleEntityUUIDKeyed {
 		@Nullable
@@ -4463,5 +4480,36 @@ public String toString() {
 					+ '}';
 		}
 	}
+
+	@Document(indexName = "#{@indexNameProvider.indexName()}-readonly-id")
+	static class ReadonlyIdEntity {
+		@Field(type = FieldType.Keyword) private String part1;
+
+		@Field(type = FieldType.Keyword) private String part2;
+
+		@Id
+		@ReadOnlyProperty
+		@AccessType(AccessType.Type.PROPERTY)
+		public String getId() {
+			return part1 + '-' + part2;
+		}
+
+		public String getPart1() {
+			return part1;
+		}
+
+		public void setPart1(String part1) {
+			this.part1 = part1;
+		}
+
+		public String getPart2() {
+			return part2;
+		}
+
+		public void setPart2(String part2) {
+			this.part2 = part2;
+		}
+	}
+
 	// endregion
 }

src/test/java/org/springframework/data/elasticsearch/core/ElasticsearchIntegrationTests.java

@@ -49,7 +49,9 @@
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.dao.DataAccessException;
 import org.springframework.dao.OptimisticLockingFailureException;
+import org.springframework.data.annotation.AccessType;
 import org.springframework.data.annotation.Id;
+import org.springframework.data.annotation.ReadOnlyProperty;
 import org.springframework.data.annotation.Version;
 import org.springframework.data.domain.PageRequest;
 import org.springframework.data.domain.Pageable;
@@ -1156,6 +1158,23 @@ void shouldReturnMonoOfReactiveSearchHits() {
 				.verifyComplete();
 	}
 
+	@Test // #2230
+	@DisplayName("should work with readonly id")
+	void shouldWorkWithReadonlyId() {
+
+		ReadonlyIdEntity entity = new ReadonlyIdEntity();
+		entity.setPart1("foo");
+		entity.setPart2("bar");
+
+		operations.save(entity).block();
+
+		operations.get(entity.getId(), ReadonlyIdEntity.class) //
+				.as(StepVerifier::create) //
+				.assertNext(readEntity -> { //
+					assertThat(readEntity.getPart1()).isEqualTo(entity.getPart1()); //
+					assertThat(readEntity.getPart2()).isEqualTo(entity.getPart2()); //
+				}).verifyComplete();
+	}
 	// endregion
 
 	// region Helper functions
@@ -1489,5 +1508,35 @@ public String toString() {
 					+ seqNoPrimaryTerm + '}';
 		}
 	}
+
+	@Document(indexName = "#{@indexNameProvider.indexName()}-readonly-id")
+	static class ReadonlyIdEntity {
+		@Field(type = FieldType.Keyword) private String part1;
+
+		@Field(type = FieldType.Keyword) private String part2;
+
+		@Id
+		@ReadOnlyProperty
+		@AccessType(AccessType.Type.PROPERTY)
+		public String getId() {
+			return part1 + '-' + part2;
+		}
+
+		public String getPart1() {
+			return part1;
+		}
+
+		public void setPart1(String part1) {
+			this.part1 = part1;
+		}
+
+		public String getPart2() {
+			return part2;
+		}
+
+		public void setPart2(String part2) {
+			this.part2 = part2;
+		}
+	}
 	// endregion
 }

src/test/java/org/springframework/data/elasticsearch/core/ReactiveElasticsearchIntegrationTests.java

@@ -241,7 +241,7 @@ static class SampleEntity {
 		@Id private String id;
 		@Nullable private String text;
 
-		@ReadOnlyProperty
+//		@ReadOnlyProperty
 		@Nullable private String className;
 
 		@Nullable

src/test/java/org/springframework/data/elasticsearch/core/event/CallbackIntegrationTests.java

@@ -27,7 +27,6 @@
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.data.annotation.Id;
-import org.springframework.data.annotation.ReadOnlyProperty;
 import org.springframework.data.elasticsearch.annotations.Document;
 import org.springframework.data.elasticsearch.core.ReactiveElasticsearchOperations;
 import org.springframework.data.elasticsearch.core.ReactiveIndexOperations;
@@ -119,7 +118,6 @@ static class SampleEntity {
 		@Id private String id;
 		private String text;
 
-		@ReadOnlyProperty
 		@Nullable private String className;
 
 		public SampleEntity(String id, String text) {