Skip to content

CouchbasePersistentEntity#isTouchOnRead never used? [DATACOUCH-629] #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue Oct 8, 2020 · 3 comments
Assignees
Labels
in: repository Repositories abstraction status: duplicate A duplicate of another issue type: bug A general bug

Comments

@spring-projects-issues
Copy link

David Prevost opened DATACOUCH-629 and commented

I was checking to use the expiry feature and I noticed that we can configure the touchAndRead on Document#touchOnRead.

However, even though it is read by CouchbasePersistentEntity#isTouchOnRead, no one is actually checking if the entity expiry date need to be touchAndRead.

By analysing MappingCouchbaseConverter#writeInternal(), we can see that the expiry is always updated instead of doing it by checking if the touchAndRead is activated... unless this is a feature of JPA then is it probably a bug.

Fortunately for me, I need the expiry to be updated so not a major bug for me...


No further details from DATACOUCH-629

@spring-projects-issues
Copy link
Author

Michael Reiche commented

"By analysing MappingCouchbaseConverter#writeInternal(), we can see that the expiry is always updated instead of doing it by checking if the touchAndRead is activated."

touchOnRead does not affect writes

@spring-projects-issues
Copy link
Author

David Prevost commented

Michael Reiche the fact that the isTouchOnRead is never used is still a problem unless it is fixed by antoher Jira though....

@spring-projects-issues spring-projects-issues added type: bug A general bug in: repository Repositories abstraction labels Dec 31, 2020
@mikereiche mikereiche added the status: duplicate A duplicate of another issue label Aug 14, 2021
@mikereiche
Copy link
Collaborator

Thanks for your input. Will handle this in
#982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: repository Repositories abstraction status: duplicate A duplicate of another issue type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants