Polishing.

Reorder methods. Tweak Javadoc, add references to parameter naming. Add usage to newly introduced methods.

See #3088
Original pull request: #3272

Author: mp911de

Diff for: src/main/java/org/springframework/data/mapping/Parameter.java

@@ -91,19 +91,32 @@ public Parameter(@Nullable String name, TypeInformation<T> type, Annotation[] an
 	}
 
 	/**
-	 * Returns the name of the parameter.
+	 * Returns the name of the parameter (through constructor/method parameter naming).
 	 *
-	 * @return
+	 * @return the name of the parameter.
+	 * @see org.springframework.core.ParameterNameDiscoverer
 	 */
 	public @Nullable String getName() {
 		return name;
 	}
 
 	/**
-	 * Returns the required parameter name.
+	 * Returns whether the parameter has a name.
+	 *
+	 * @return whether the parameter has a name.
+	 * @since 3.5
+	 */
+	public boolean hasName() {
+		return this.name != null;
+	}
+
+	/**
+	 * Returns the required name of the parameter (through constructor/method parameter naming) or throws
+	 * {@link IllegalStateException} if the parameter has no name.
 	 *
-	 * @return the parameter name or throws {@link IllegalStateException} if the parameter does not have a name
+	 * @return the parameter name or throws {@link IllegalStateException} if the parameter does not have a name.
 	 * @since 3.5
+	 * @see org.springframework.core.ParameterNameDiscoverer
 	 */
 	public String getRequiredName() {
 
@@ -114,16 +127,6 @@ public String getRequiredName() {
 		return getName();
 	}
 
-	/**
-	 * Returns whether the parameter has a name.
-	 *
-	 * @return whether the parameter has a name
-	 * @since 3.5
-	 */
-	public boolean hasName() {
-		return this.name != null;
-	}
-
 	/**
 	 * Returns the {@link TypeInformation} of the parameter.
 	 *

Diff for: src/main/java/org/springframework/data/mapping/model/InstantiationAwarePropertyAccessor.java

@@ -96,7 +96,7 @@ public void setProperty(PersistentProperty<?> property, @Nullable Object value)
 
 		creator.getParameters().forEach(it -> {
 
-			if (it.getName() == null) {
+			if (!it.hasName()) {
 				throw new IllegalStateException(
 						String.format("Cannot detect parameter names of copy creator of %s", owner.getType()));
 			}

Diff for: src/main/java/org/springframework/data/repository/query/Parameter.java

@@ -154,10 +154,23 @@ public boolean isNamedParameter() {
 		return !isSpecialParameter() && getName().isPresent();
 	}
 
+	/**
+	 * Returns whether the parameter is named explicitly, i.e. annotated with {@link Param}.
+	 *
+	 * @return
+	 * @since 1.11
+	 * @see Param
+	 */
+	public boolean isExplicitlyNamed() {
+		return parameter.hasParameterAnnotation(Param.class);
+	}
+
 	/**
 	 * Returns the name of the parameter (through {@link Param} annotation or method parameter naming).
 	 *
 	 * @return the optional name of the parameter.
+	 * @see Param
+	 * @see org.springframework.core.ParameterNameDiscoverer
 	 */
 	public Optional<String> getName() {
 		return this.name.get();
@@ -170,6 +183,8 @@ public Optional<String> getName() {
 	 * @return the required parameter name.
 	 * @throws IllegalStateException if the parameter has no name.
 	 * @since 3.4
+	 * @see Param
+	 * @see org.springframework.core.ParameterNameDiscoverer
 	 */
 	public String getRequiredName() {
 
@@ -186,15 +201,6 @@ public Class<?> getType() {
 		return parameterType;
 	}
 
-	/**
-	 * Returns whether the parameter is named explicitly, i.e. annotated with {@link Param}.
-	 *
-	 * @return
-	 * @since 1.11
-	 */
-	public boolean isExplicitlyNamed() {
-		return parameter.hasParameterAnnotation(Param.class);
-	}
 
 	@Override
 	public String toString() {

Diff for: src/main/java/org/springframework/data/repository/query/ReturnedType.java

@@ -303,8 +303,8 @@ private List<String> detectConstructorParameterNames(Class<?> type) {
 			List<String> properties = new ArrayList<>(parameterCount);
 
 			for (Parameter<Object, ?> parameter : constructor.getParameters()) {
-				if (parameter.getName() != null) {
-					properties.add(parameter.getName());
+				if (parameter.hasName()) {
+					properties.add(parameter.getRequiredName());
 				}
 			}