Skip applying Sort if Pageable is unpaged

Fix
java.lang.UnsupportedOperationException
	at org.springframework.data.domain.Unpaged.getPageNumber(Unpaged.java)
	at org.springframework.data.web.ReactivePageableHandlerMethodArgumentResolver.resolveArgumentValue(ReactivePageableHandlerMethodArgumentResolver.java)

Author: quaff

src/main/java/org/springframework/data/web/PageableHandlerMethodArgumentResolver.java

@@ -34,6 +34,7 @@
  * @author Nick Williams
  * @author Mark Paluch
  * @author Christoph Strobl
+ * @author Yanming Zhou
  */
 public class PageableHandlerMethodArgumentResolver extends PageableHandlerMethodArgumentResolverSupport
 		implements PageableArgumentResolver {
@@ -79,11 +80,13 @@ public Pageable resolveArgument(MethodParameter methodParameter, @Nullable Model
 		String page = webRequest.getParameter(getParameterNameToUse(getPageParameterName(), methodParameter));
 		String pageSize = webRequest.getParameter(getParameterNameToUse(getSizeParameterName(), methodParameter));
 
-		Sort sort = sortResolver.resolveArgument(methodParameter, mavContainer, webRequest, binderFactory);
 		Pageable pageable = getPageable(methodParameter, page, pageSize);
 
-		if (sort.isSorted()) {
-			return PageRequest.of(pageable.getPageNumber(), pageable.getPageSize(), sort);
+		if (pageable.isPaged()) {
+			Sort sort = sortResolver.resolveArgument(methodParameter, mavContainer, webRequest, binderFactory);
+			if (sort.isSorted()) {
+				pageable = PageRequest.of(pageable.getPageNumber(), pageable.getPageSize(), sort);
+			}
 		}
 
 		return pageable;

src/main/java/org/springframework/data/web/ReactivePageableHandlerMethodArgumentResolver.java

@@ -33,6 +33,7 @@
  *
  * @since 2.2
  * @author Mark Paluch
+ * @author Yanming Zhou
  */
 public class ReactivePageableHandlerMethodArgumentResolver extends PageableHandlerMethodArgumentResolverSupport
 		implements SyncHandlerMethodArgumentResolver {
@@ -74,10 +75,15 @@ public Pageable resolveArgumentValue(MethodParameter parameter, BindingContext b
 		String page = queryParams.getFirst(getParameterNameToUse(getPageParameterName(), parameter));
 		String pageSize = queryParams.getFirst(getParameterNameToUse(getSizeParameterName(), parameter));
 
-		Sort sort = sortResolver.resolveArgumentValue(parameter, bindingContext, exchange);
-
 		Pageable pageable = getPageable(parameter, page, pageSize);
 
-		return sort.isSorted() ? PageRequest.of(pageable.getPageNumber(), pageable.getPageSize(), sort) : pageable;
+		if (pageable.isPaged()) {
+			Sort sort = sortResolver.resolveArgumentValue(parameter, bindingContext, exchange);
+			if (sort.isSorted()) {
+				pageable = PageRequest.of(pageable.getPageNumber(), pageable.getPageSize(), sort);
+			}
+		}
+
+		return pageable;
 	}
 }

src/test/java/org/springframework/data/web/PageableHandlerMethodArgumentResolverUnitTests.java

@@ -37,6 +37,7 @@
  * @author Nick Williams
  * @author Vedran Pavic
  * @author Mark Paluch
+ * @author Yanming Zhou
  */
 class PageableHandlerMethodArgumentResolverUnitTests extends PageableDefaultUnitTests {
 
@@ -171,6 +172,20 @@ void returnsFallbackIfOnlyPageIsGiven() throws Exception {
 				.isEqualTo(Pageable.unpaged());
 	}
 
+	@Test
+	void returnsFallbackIfOnlyPageAndSortIsGiven() throws Exception {
+
+		var resolver = getResolver();
+		resolver.setFallbackPageable(Pageable.unpaged());
+
+		var request = new MockHttpServletRequest();
+		request.addParameter("page", "20");
+		request.addParameter("sort", "foo");
+
+		assertThat(resolver.resolveArgument(supportedMethodParameter, null, new ServletWebRequest(request), null))
+				.isEqualTo(Pageable.unpaged());
+	}
+
 	@Test // DATACMNS-477
 	void returnsFallbackIfFallbackIsUnpagedAndOnlySizeIsGiven() throws Exception {
 

src/test/java/org/springframework/data/web/ReactivePageableHandlerMethodArgumentResolverUnitTests.java

@@ -35,6 +35,7 @@
  * Unit tests for {@link ReactivePageableHandlerMethodArgumentResolver}.
  *
  * @author Mark Paluch
+ * @author Yanming Zhou
  */
 class ReactivePageableHandlerMethodArgumentResolverUnitTests {
 
@@ -150,6 +151,17 @@ void returnsFallbackIfOnlyPageIsGiven() {
 		assertThat(resolve(resolver, request)).isEqualTo(Pageable.unpaged());
 	}
 
+	@Test
+	void returnsFallbackIfOnlyPageAndSortIsGiven() {
+
+		var resolver = getReactiveResolver();
+		resolver.setFallbackPageable(Pageable.unpaged());
+
+		var request = MockServerHttpRequest.get("foo?page=20&sort=test").build();
+
+		assertThat(resolve(resolver, request)).isEqualTo(Pageable.unpaged());
+	}
+
 	@Test // DATACMNS-1211
 	void returnsFallbackIfFallbackIsUnpagedAndOnlySizeIsGiven() {