Skip to content

Commit 23fbff0

Browse files
snicollmp911de
authored andcommitted
Polishing.
A public bean method that returns a private type is unusual and prevents the processing of such bean in reflection-free use cases. There was also an unnecessary qualifier in the implementation. Closes #2399
1 parent 88128e5 commit 23fbff0

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/main/java/org/springframework/data/web/config/ProjectingArgumentResolverRegistrar.java

+3-4
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public class ProjectingArgumentResolverRegistrar {
5454
* @return
5555
*/
5656
@Bean
57-
public static ProjectingArgumentResolverBeanPostProcessor projectingArgumentResolverBeanPostProcessor(
57+
static ProjectingArgumentResolverBeanPostProcessor projectingArgumentResolverBeanPostProcessor(
5858
@Qualifier("mvcConversionService") ObjectFactory<ConversionService> conversionService) {
5959
return new ProjectingArgumentResolverBeanPostProcessor(conversionService);
6060
}
@@ -66,7 +66,7 @@ public static ProjectingArgumentResolverBeanPostProcessor projectingArgumentReso
6666
* @author Oliver Gierke
6767
* @soundtrack Apparat With Soap & Skin - Goodbye (Dark Theme Song - https://www.youtube.com/watch?v=66VnOdk6oto)
6868
*/
69-
private static class ProjectingArgumentResolverBeanPostProcessor
69+
static class ProjectingArgumentResolverBeanPostProcessor
7070
implements BeanPostProcessor, BeanFactoryAware, BeanClassLoaderAware {
7171

7272
private ProxyingHandlerMethodArgumentResolver resolver;
@@ -78,8 +78,7 @@ private static class ProjectingArgumentResolverBeanPostProcessor
7878
* @param conversionService the Spring MVC {@link ConversionService} in a lazy fashion, so that its initialization
7979
* is not triggered yet.
8080
*/
81-
public ProjectingArgumentResolverBeanPostProcessor(
82-
@Qualifier("mvcConversionService") ObjectFactory<ConversionService> conversionService) {
81+
ProjectingArgumentResolverBeanPostProcessor(ObjectFactory<ConversionService> conversionService) {
8382
this.resolver = new ProxyingHandlerMethodArgumentResolver(conversionService, false);
8483
}
8584

0 commit comments

Comments
 (0)