Skip to content

Commit c92bb06

Browse files
committed
Adopt to deprecation removals in Commons.
Closes #1540
1 parent e8dd09a commit c92bb06

19 files changed

+29
-313
lines changed

spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/convert/BasicCassandraRowValueProvider.java

-62
This file was deleted.

spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/convert/CassandraTupleValueProvider.java

-45
This file was deleted.

spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/convert/CassandraUDTValueProvider.java

-60
This file was deleted.

spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/convert/MappingCassandraConverter.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ private <R> R doReadProjection(ConversionContext context, CassandraValueProvider
411411
if (mappedEntity.requiresPropertyPopulation()) {
412412

413413
PersistentPropertyAccessor<R> accessor = mappedEntity.getPropertyAccessor(instance);
414-
readProperties(context, mappedEntity, valueProviderToUse, accessor, isConstructorArgument(mappedEntity).negate());
414+
readProperties(context, mappedEntity, valueProviderToUse, accessor, isCreatorArgument(mappedEntity).negate());
415415
return accessor.getBean();
416416
}
417417

@@ -590,7 +590,7 @@ private <S> S populateProperties(ConversionContext context, CassandraPersistentE
590590
}
591591

592592
ConvertingPropertyAccessor<S> propertyAccessor = newConvertingPropertyAccessor(instance, entity);
593-
readProperties(context, entity, valueProvider, propertyAccessor, isConstructorArgument(entity).negate());
593+
readProperties(context, entity, valueProvider, propertyAccessor, isCreatorArgument(entity).negate());
594594
return propertyAccessor.getBean();
595595
}
596596

@@ -1306,8 +1306,8 @@ private static Class<?> resolveMapType(TypeInformation<?> typeInformation) {
13061306
return Map.class.isAssignableFrom(mapType) ? mapType : Map.class;
13071307
}
13081308

1309-
static Predicate<CassandraPersistentProperty> isConstructorArgument(PersistentEntity<?, ?> entity) {
1310-
return entity::isConstructorArgument;
1309+
static Predicate<CassandraPersistentProperty> isCreatorArgument(PersistentEntity<?, ?> entity) {
1310+
return entity::isCreatorArgument;
13111311
}
13121312

13131313
enum NoOpParameterValueProvider implements ParameterValueProvider<CassandraPersistentProperty> {

spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/mapping/EmbeddedEntityOperations.java

+1-11
Original file line numberDiff line numberDiff line change
@@ -139,21 +139,11 @@ public String getName() {
139139
}
140140

141141
@Override
142-
@org.springframework.lang.Nullable
143-
public PreferredConstructor<T, CassandraPersistentProperty> getPersistenceConstructor() {
144-
return delegate.getPersistenceConstructor();
145-
}
146-
147-
@Override
142+
@Nullable
148143
public InstanceCreatorMetadata<CassandraPersistentProperty> getInstanceCreatorMetadata() {
149144
return delegate.getInstanceCreatorMetadata();
150145
}
151146

152-
@Override
153-
public boolean isConstructorArgument(PersistentProperty<?> property) {
154-
return delegate.isConstructorArgument(property);
155-
}
156-
157147
@Override
158148
public boolean isCreatorArgument(PersistentProperty<?> property) {
159149
return delegate.isCreatorArgument(property);

spring-data-cassandra/src/main/java/org/springframework/data/cassandra/repository/query/CassandraParameters.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
import org.springframework.data.repository.query.ParametersSource;
3333
import org.springframework.data.repository.util.QueryExecutionConverters;
3434
import org.springframework.data.repository.util.ReactiveWrapperConverters;
35-
import org.springframework.data.repository.util.ReactiveWrappers;
35+
import org.springframework.data.util.ReactiveWrappers;
3636
import org.springframework.data.util.TypeInformation;
3737
import org.springframework.lang.Nullable;
3838

spring-data-cassandra/src/main/java/org/springframework/data/cassandra/repository/query/ReactiveCassandraParameterAccessor.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@
2626

2727
import org.reactivestreams.Publisher;
2828
import org.springframework.data.repository.util.ReactiveWrapperConverters;
29-
import org.springframework.data.repository.util.ReactiveWrappers;
29+
import org.springframework.data.util.ReactiveWrappers;
3030

3131
/**
3232
* Reactive {@link org.springframework.data.repository.query.ParametersParameterAccessor} implementation that subscribes
33-
* to reactive parameter wrapper types upon creation. This class performs synchronization when acessing parameters.
33+
* to reactive parameter wrapper types upon creation. This class performs synchronization when accessing parameters.
3434
*
3535
* @author Mark Paluch
3636
* @since 2.0

spring-data-cassandra/src/main/java/org/springframework/data/cassandra/repository/query/ReactiveCassandraQueryMethod.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424
import org.springframework.data.projection.ProjectionFactory;
2525
import org.springframework.data.repository.core.RepositoryMetadata;
2626
import org.springframework.data.repository.util.ReactiveWrapperConverters;
27-
import org.springframework.data.repository.util.ReactiveWrappers;
2827
import org.springframework.data.util.Lazy;
28+
import org.springframework.data.util.ReactiveWrappers;
2929

3030
/**
3131
* Reactive specific implementation of {@link CassandraQueryMethod}.

spring-data-cassandra/src/main/java/org/springframework/data/cassandra/repository/query/ReactiveStringBasedCassandraQuery.java

+3-53
Original file line numberDiff line numberDiff line change
@@ -17,19 +17,13 @@
1717

1818
import reactor.core.publisher.Mono;
1919

20-
import org.springframework.core.env.StandardEnvironment;
2120
import org.springframework.data.cassandra.core.ReactiveCassandraOperations;
2221
import org.springframework.data.cassandra.repository.Query;
2322
import org.springframework.data.expression.ReactiveValueEvaluationContextProvider;
2423
import org.springframework.data.expression.ValueEvaluationContextProvider;
25-
import org.springframework.data.expression.ValueExpressionParser;
2624
import org.springframework.data.mapping.model.ValueExpressionEvaluator;
27-
import org.springframework.data.repository.query.QueryMethodEvaluationContextProvider;
28-
import org.springframework.data.repository.query.QueryMethodValueEvaluationContextAccessor;
29-
import org.springframework.data.repository.query.ReactiveQueryMethodEvaluationContextProvider;
3025
import org.springframework.data.repository.query.ValueExpressionDelegate;
3126
import org.springframework.data.spel.ExpressionDependencies;
32-
import org.springframework.expression.ExpressionParser;
3327
import org.springframework.expression.spel.standard.SpelExpressionParser;
3428
import org.springframework.util.Assert;
3529

@@ -62,50 +56,6 @@ public class ReactiveStringBasedCassandraQuery extends AbstractReactiveCassandra
6256

6357
private final ReactiveValueEvaluationContextProvider valueEvaluationContextProvider;
6458

65-
/**
66-
* Create a new {@link ReactiveStringBasedCassandraQuery} for the given {@link CassandraQueryMethod},
67-
* {@link ReactiveCassandraOperations}, {@link SpelExpressionParser}, and
68-
* {@link QueryMethodEvaluationContextProvider}.
69-
*
70-
* @param queryMethod {@link ReactiveCassandraQueryMethod} on which this query is based.
71-
* @param operations {@link ReactiveCassandraOperations} used to perform data access in Cassandra.
72-
* @param expressionParser {@link SpelExpressionParser} used to parse expressions in the query.
73-
* @param evaluationContextProvider {@link QueryMethodEvaluationContextProvider} used to access the potentially shared
74-
* {@link org.springframework.expression.spel.support.StandardEvaluationContext}.
75-
* @see org.springframework.data.cassandra.repository.query.ReactiveCassandraQueryMethod
76-
* @see org.springframework.data.cassandra.core.ReactiveCassandraOperations
77-
* @deprecated since 4.4, use the constructors accepting {@link ValueExpressionDelegate} instead.
78-
*/
79-
@Deprecated(since = "4.4")
80-
public ReactiveStringBasedCassandraQuery(ReactiveCassandraQueryMethod queryMethod,
81-
ReactiveCassandraOperations operations, ExpressionParser expressionParser,
82-
ReactiveQueryMethodEvaluationContextProvider evaluationContextProvider) {
83-
84-
this(queryMethod.getRequiredAnnotatedQuery(), queryMethod, operations, expressionParser, evaluationContextProvider);
85-
}
86-
87-
/**
88-
* Create a new {@link ReactiveStringBasedCassandraQuery} for the given {@code query}, {@link CassandraQueryMethod},
89-
* {@link ReactiveCassandraOperations}, {@link SpelExpressionParser}, and
90-
* {@link QueryMethodEvaluationContextProvider}.
91-
*
92-
* @param method {@link ReactiveCassandraQueryMethod} on which this query is based.
93-
* @param operations {@link ReactiveCassandraOperations} used to perform data access in Cassandra.
94-
* @param expressionParser {@link SpelExpressionParser} used to parse expressions in the query.
95-
* @param evaluationContextProvider {@link QueryMethodEvaluationContextProvider} used to access the potentially shared
96-
* {@link org.springframework.expression.spel.support.StandardEvaluationContext}.
97-
* @see org.springframework.data.cassandra.repository.query.ReactiveCassandraQueryMethod
98-
* @see org.springframework.data.cassandra.core.ReactiveCassandraOperations
99-
* @deprecated since 4.4, use the constructors accepting {@link ValueExpressionDelegate} instead.
100-
*/
101-
@Deprecated(since = "4.4")
102-
public ReactiveStringBasedCassandraQuery(String query, ReactiveCassandraQueryMethod method,
103-
ReactiveCassandraOperations operations, ExpressionParser expressionParser,
104-
ReactiveQueryMethodEvaluationContextProvider evaluationContextProvider) {
105-
106-
this(query, method, operations, new ValueExpressionDelegate(new QueryMethodValueEvaluationContextAccessor(new StandardEnvironment(), evaluationContextProvider.getEvaluationContextProvider()), ValueExpressionParser.create(() -> expressionParser)));
107-
}
108-
10959
/**
11060
* Create a new {@link ReactiveStringBasedCassandraQuery} for the given {@link CassandraQueryMethod},
11161
* {@link ReactiveCassandraOperations}, {@link ValueExpressionDelegate}
@@ -145,9 +95,9 @@ public ReactiveStringBasedCassandraQuery(String query, ReactiveCassandraQueryMet
14595

14696
this.stringBasedQuery = new StringBasedQuery(query, method.getParameters(), delegate);
14797

148-
ValueEvaluationContextProvider valueContextProvider = delegate.createValueContextProvider(
149-
method.getParameters());
150-
Assert.isInstanceOf(ReactiveValueEvaluationContextProvider.class, valueContextProvider, "ValueEvaluationContextProvider must be reactive");
98+
ValueEvaluationContextProvider valueContextProvider = delegate.createValueContextProvider(method.getParameters());
99+
Assert.isInstanceOf(ReactiveValueEvaluationContextProvider.class, valueContextProvider,
100+
"ValueEvaluationContextProvider must be reactive");
151101
this.valueEvaluationContextProvider = (ReactiveValueEvaluationContextProvider) valueContextProvider;
152102

153103
if (method.hasAnnotatedQuery()) {

0 commit comments

Comments
 (0)