Skip to content

Deprecate @ConfigurationProperites#locations #5129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue Feb 11, 2016 · 3 comments
Closed

Deprecate @ConfigurationProperites#locations #5129

snicoll opened this issue Feb 11, 2016 · 3 comments
Assignees
@snicoll
Milestone
1.4.0.M2

Comments

@snicoll
Copy link
Member

snicoll commented Feb 11, 2016

I really wonder why we're having a way to bind one particular POJO to a different configuration. IMO this breaks the nice "configuration environment" story in Spring Boot by adding something on the side that doesn't play well with the rest.

And people got confused.
@wilkinsona
Copy link
Member

People also got confused about the configuration being totally isolated so we added the merge attribute. With hindsight, I think that was a mistake. I'm in favour of getting rid of locations.

@wilkinsona wilkinsona mentioned this issue Feb 12, 2016
Closed
@wilkinsona
Copy link
Member

Related to #2750

@philwebb
Copy link
Member

+1, but we should probably just deprecate in 1.4 then drop in 2.0

@philwebb philwebb added this to the 1.4.0.M2 milestone Feb 26, 2016
@philwebb philwebb added for: team-attention An issue we'd like other members of the team to review and removed for: team-attention An issue we'd like other members of the team to review labels Feb 26, 2016
@wilkinsona wilkinsona changed the title Consider removing @ConfigurationProperites#locations Deprecate @ConfigurationProperites#locations Mar 2, 2016
@snicoll snicoll self-assigned this Mar 4, 2016
@snicoll snicoll closed this as completed in b8dc4e7 Mar 9, 2016
@wilkinsona wilkinsona mentioned this issue Mar 10, 2021
Open
@wilkinsona wilkinsona mentioned this issue Nov 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
None yet
Projects
None yet
Milestone
1.4.0.M2
Development

No branches or pull requests
3 participants
@snicoll @philwebb @wilkinsona